search for: findprogrampath

...ct at gmail.com> Cc: rsync at lists.samba.org Subject: RE: new release 3.4.0 - critical security release Here is my fix for the situation: diff --git a/popt/findme.c b/popt/findme.c index ac4cbae..4fe8a18 100644 --- a/popt/findme.c +++ b/popt/findme.c @@ -25,12 +25,23 @@ const char * findProgramPath(const char * argv0) if (path == NULL) return NULL; bufsize = strlen(path) + 1; +#if defined __TANDEM + start = pathbuf = malloc(bufsize); +#else start = pathbuf = alloca(bufsize); +#endif if (pathbuf == NULL) return NULL; /* XXX can't happen */ strlcpy(p...

Here is my fix for the situation: diff --git a/popt/findme.c b/popt/findme.c index ac4cbae..4fe8a18 100644 --- a/popt/findme.c +++ b/popt/findme.c @@ -25,12 +25,23 @@ const char * findProgramPath(const char * argv0) if (path == NULL) return NULL; bufsize = strlen(path) + 1; +#if defined __TANDEM + start = pathbuf = malloc(bufsize); +#else start = pathbuf = alloca(bufsize); +#endif if (pathbuf == NULL) return NULL; /* XXX can't happen */ strlcpy(p...

...4.0 - critical security release > > > > Here is my fix for the situation: > > > > *diff --git a/popt/findme.c b/popt/findme.c* > > *index ac4cbae..4fe8a18 100644* > > *--- a/popt/findme.c* > > *+++ b/popt/findme.c* > > @@ -25,12 +25,23 @@ const char * findProgramPath(const char * argv0) > > if (path == NULL) return NULL; > > > > bufsize = strlen(path) + 1; > > +#if defined __TANDEM > > + start = pathbuf = malloc(bufsize); > > +#else > > start = pathbuf = alloca(bufsize); > > +#endif > >...

...gt; Here is my fix for the situation: >> >> >> >> *diff --git a/popt/findme.c b/popt/findme.c* >> >> *index ac4cbae..4fe8a18 100644* >> >> *--- a/popt/findme.c* >> >> *+++ b/popt/findme.c* >> >> @@ -25,12 +25,23 @@ const char * findProgramPath(const char * argv0) >> >> if (path == NULL) return NULL; >> >> >> >> bufsize = strlen(path) + 1; >> >> +#if defined __TANDEM >> >> + start = pathbuf = malloc(bufsize); >> >> +#else >> >> start = pa...

...mba.org <mailto:rsync at lists.samba.org> Subject: RE: new release 3.4.0 - critical security release Here is my fix for the situation: diff --git a/popt/findme.c b/popt/findme.c index ac4cbae..4fe8a18 100644 --- a/popt/findme.c +++ b/popt/findme.c @@ -25,12 +25,23 @@ const char * findProgramPath(const char * argv0) if (path == NULL) return NULL; bufsize = strlen(path) + 1; +#if defined __TANDEM + start = pathbuf = malloc(bufsize); +#else start = pathbuf = alloca(bufsize); +#endif if (pathbuf == NULL) return NULL; /* XXX can't happen */ strlcpy(p...

This happens on NonStop x86 and ia64. I have been building/packaging Rsync for years ? almost a decade in fact. I think this happened once before this year, in fact. It is equivalent to the more portable malloc/free, which I would prefer to have in this series even if it has to be wrapped in a #if defined (__TANDEM) block. This call is considered not portable and allocates on the stack

...warning: right shift count >= width of type flist.c: In function `make_file': flist.c:1178: warning: comparison between signed and unsigned flist.c:1224: warning: comparison between signed and unsigned flist.c:1226: warning: right shift count >= width of type popt/findme.c: In function `findProgramPath': popt/findme.c:28: warning: implicit declaration of function `alloca' gcc -std=gnu99 -I. -I. -D_ALL_SOURCE -DHAVE_CONFIG_H -Wall -W -I./popt -Wno-unused-parameter -D_ALL_SOURCE -I/usr/local/include -I/usr/local/ssl/include -c popt/popt.c -o popt/popt.o popt/popt.c: In function `execComma...

...QAContact: rsync-qa at samba.org Build problem with alloca() Using GCC on Tru64 and HP-UX causes complaints like this (HP-UX shown): gcc -std=gnu99 -I. -I. -g -O2 -DHAVE_CONFIG_H -Wall -W -I./popt -Wno-unu sed-parameter -c popt/findme.c -o popt/findme.o popt/findme.c: In function 'findProgramPath': popt/findme.c:28: warning: implicit declaration of function 'alloca' popt/findme.c:28: warning: incompatible implicit declaration of built-in functio n 'alloca' Suggestion: dyi # gdiff -u ./popt/system.h_orig ./popt/system.h --- ./popt/system.h_orig 2006-11-08 20:3...

...b/getnameinfo.c: In function `getnameinfo': lib/getnameinfo.c:115: warning: comparison between signed and unsigned In file included from popt/system.h:82, from popt/findme.c:9: popt/popt.h:377: warning: type qualifiers ignored on function return type popt/findme.c: In function `findProgramPath': popt/findme.c:25: warning: implicit declaration of function `alloca' In file included from popt/system.h:82, from popt/popt.c:11: popt/popt.h:377: warning: type qualifiers ignored on function return type popt/popt.c: In function `execCommand': popt/popt.c:369: warning...

...r32.o gcc -I. -I. -g -O2 -DHAVE_CONFIG_H -Wall -W -I./popt -c zlib/compress.c -o zlib/compress.o gcc -I. -I. -g -O2 -DHAVE_CONFIG_H -Wall -W -I./popt -c zlib/crc32.c -o zlib/crc32.o gcc -I. -I. -g -O2 -DHAVE_CONFIG_H -Wall -W -I./popt -c popt/findme.c -o popt/findme.o popt/findme.c: In function `findProgramPath': popt/findme.c:25: warning: implicit declaration of function `alloca' gcc -I. -I. -g -O2 -DHAVE_CONFIG_H -Wall -W -I./popt -c popt/popt.c -o popt/popt.o popt/popt.c: In function `execCommand': popt/popt.c:369: warning: implicit declaration of function `alloca' gcc -I. -I. -g -O2 -...