search for: find_vrhs

On Fri, Feb 22, 2013 at 1:42 AM, Rusty Russell <rusty at rustcorp.com.au> wrote: > Ohad Ben-Cohen <ohad at wizery.com> writes: >> On Thu, Feb 21, 2013 at 8:37 AM, Rusty Russell <rusty at rustcorp.com.au> wrote: >> What do you think about creating some virtio-level wrappers for the >> vringh handlers? >> >> I don't think we're going to stop

On Fri, Feb 22, 2013 at 1:42 AM, Rusty Russell <rusty at rustcorp.com.au> wrote: > Ohad Ben-Cohen <ohad at wizery.com> writes: >> On Thu, Feb 21, 2013 at 8:37 AM, Rusty Russell <rusty at rustcorp.com.au> wrote: >> What do you think about creating some virtio-level wrappers for the >> vringh handlers? >> >> I don't think we're going to stop

From: Sjur Br?ndeland <sjur.brandeland at stericsson.com> Add wrappers for the host vrings to support loose coupling between the virtio device and driver. The functions find_vrhs() and del_vrhs() are added to struct virtio_config_ops to manage the host vrings. The function vringh_notify() is added so the guest can be kicked when buffers are added to the used-ring. This enables the virtio drivers to manage the virtio rings without knowledge of how the host vrings are manage...

From: Sjur Br?ndeland <sjur.brandeland at stericsson.com> Add wrappers for the host vrings to support loose coupling between the virtio device and driver. The functions find_vrhs() and del_vrhs() are added to struct virtio_config_ops to manage the host vrings. The function vringh_notify() is added so the guest can be kicked when buffers are added to the used-ring. This enables the virtio drivers to manage the virtio rings without knowledge of how the host vrings are manage...

From: Sjur Br?ndeland <sjur.brandeland at stericsson.com> Add wrappers for the host vrings to support loose coupling between the virtio device and driver. A new struct vringh_config_ops with the functions find_vrhs() and del_vrhs() is added to the virtio_device struct. This enables virtio drivers to manage virtio host rings without detailed knowledge of how the vrings are created and deleted. The function vringh_notify() is added so vringh clients can notify the other side that buffers are added to the used-...

From: Sjur Br?ndeland <sjur.brandeland at stericsson.com> Add wrappers for the host vrings to support loose coupling between the virtio device and driver. A new struct vringh_config_ops with the functions find_vrhs() and del_vrhs() is added to the virtio_device struct. This enables virtio drivers to manage virtio host rings without detailed knowledge of how the vrings are created and deleted. The function vringh_notify() is added so vringh clients can notify the other side that buffers are added to the used-...

Check on the correct return value from vringh_notify_enable_kern(). It returns false if more packets are available, not true. Signed-off-by: Sjur Br?ndeland <sjur.brandeland at stericsson.com> --- Hi, This patch applies to Rusty's virtio-next branch. Thanks, Sjur drivers/net/caif/caif_virtio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Check on the correct return value from vringh_notify_enable_kern(). It returns false if more packets are available, not true. Signed-off-by: Sjur Br?ndeland <sjur.brandeland at stericsson.com> --- Hi, This patch applies to Rusty's virtio-next branch. Thanks, Sjur drivers/net/caif/caif_virtio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

...+ /* we're temporarily limited to two virtqueues per rvdev */ + if (id >= ARRAY_SIZE(rvdev->vring)) + return ERR_PTR(-EINVAL); + + /* Find available slot for a new host vring */ + for (i = id; i < ARRAY_SIZE(rvdev->vring); i++) { + rvring = &rvdev->vring[i]; + + /* Calling find_vrhs twice is bad */ + if (rvring->rvringh) + return ERR_PTR(-EINVAL); + + /* Use vring not already in use */ + if (!rvring->vq) + break; + } + + if (i == ARRAY_SIZE(rvdev->vring)) + return ERR_PTR(-ENODEV); + + ret = rproc_alloc_vring(rvdev, i); + if (ret) + return ERR_PTR(ret); + + a...

...+ /* we're temporarily limited to two virtqueues per rvdev */ + if (id >= ARRAY_SIZE(rvdev->vring)) + return ERR_PTR(-EINVAL); + + /* Find available slot for a new host vring */ + for (i = id; i < ARRAY_SIZE(rvdev->vring); i++) { + rvring = &rvdev->vring[i]; + + /* Calling find_vrhs twice is bad */ + if (rvring->rvringh) + return ERR_PTR(-EINVAL); + + /* Use vring not already in use */ + if (!rvring->vq) + break; + } + + if (i == ARRAY_SIZE(rvdev->vring)) + return ERR_PTR(-ENODEV); + + ret = rproc_alloc_vring(rvdev, i); + if (ret) + return ERR_PTR(ret); + + a...

From: Erwan Yvin <erwan.yvin at stericsson.com> This driver depends on Rusty's new host virtio ring implementation, so this patch-set is based on the vringh branch in Rusty's git. with the vringh wrapper patch on top. They do not apply cleanly on top of the remoteproc virtio config patches from Sjur, but it merges fine. CAIF will use this new host virtio ring implementation. Ido,

From: Erwan Yvin <erwan.yvin at stericsson.com> This driver depends on Rusty's new host virtio ring implementation, so this patch-set is based on the vringh branch in Rusty's git. with the vringh wrapper patch on top. They do not apply cleanly on top of the remoteproc virtio config patches from Sjur, but it merges fine. CAIF will use this new host virtio ring implementation. Ido,

...v_name, + cfv_netdev_setup); + if (!netdev) + return -ENOMEM; + + cfv = netdev_priv(netdev); + cfv->vdev = vdev; + cfv->ndev = netdev; + + spin_lock_init(&cfv->tx_lock); + + /* Get the RX virtio ring. This is a "host side vring". */ + err = vdev->vringh_config->find_vrhs(vdev, 1, &cfv->vr_rx, &vrh_cbs); + if (err) + goto err; + + /* Get the TX virtio ring. This is a "guest side vring". */ + err = vdev->config->find_vqs(vdev, 1, &cfv->vq_tx, &vq_cbs, &names); + if (err) + goto err; + + /* Get the CAIF configuration from vi...

...v_name, + cfv_netdev_setup); + if (!netdev) + return -ENOMEM; + + cfv = netdev_priv(netdev); + cfv->vdev = vdev; + cfv->ndev = netdev; + + spin_lock_init(&cfv->tx_lock); + + /* Get the RX virtio ring. This is a "host side vring". */ + err = vdev->vringh_config->find_vrhs(vdev, 1, &cfv->vr_rx, &vrh_cbs); + if (err) + goto err; + + /* Get the TX virtio ring. This is a "guest side vring". */ + err = vdev->config->find_vqs(vdev, 1, &cfv->vq_tx, &vq_cbs, &names); + if (err) + goto err; + + /* Get the CAIF configuration from vi...