search for: find_modpath

This patch series fixes several problems in the way that supermin handles kernels. The most pressing problem is that supermin doesn't handle bogus vmlinuz files which aren't actual kernels. Along the way there is a lot of clean up. The patches look much better if you view them with ‘-w’. This series will require plenty of time to be tested in Fedora, especially on non-x86 arches.

...= - find_kernel debug host_cpu copy_kernel kernel in - - (* If the user passed --dtb option, locate dtb. *) - (match dtb_wildcard with - | None -> () - | Some wildcard -> - find_dtb debug copy_kernel kernel_name wildcard dtb - ); - - (* Get the kernel modules. *) - let modpath = find_modpath debug kernel_version in - - if debug >= 1 then ( - printf "supermin: kernel: kernel_version %s\n" kernel_version; - printf "supermin: kernel: modules %s\n%!" modpath; - ); - - (kernel_version, modpath) - -and find_kernel debug host_cpu copy_kernel kernel = - let ker...

...1d8..b4e89da 100644 --- a/src/kernel.ml +++ b/src/kernel.ml @@ -22,6 +22,7 @@ open Printf open Utils open Ext2fs open Fnmatch +open Glob let patt_of_cpu host_cpu = let models = @@ -60,7 +61,28 @@ let rec build_kernel debug host_cpu dtb_wildcard copy_kernel kernel dtb = let modpath = find_modpath debug kernel_version in kernel_env, kernel_name, kernel_version, modpath with Not_found -> - find_kernel debug host_cpu kernel in + let kernels = + let files = glob "/lib/modules/*/vmlinuz" [GLOB_NOSORT; GLOB_NOESCAPE] in + let files = Array.to_list...

Hi Rich But there is no src/kernel.ml file on my ubuntu powerpc to which the above patch is reffering. I have installed supermin as supermin_5.1.8-2_powerpc.deb debian package. Thanks On Tue, Jun 3, 2014 at 7:16 PM, Richard W.M. Jones <rjones@redhat.com> wrote: > On Tue, Jun 03, 2014 at 06:55:49PM +0530, abhishek jain wrote: > > supermin: failed to find a suitable kernel

...y_kernel kernel in > > (* If the user passed --dtb option, locate dtb. *) > (match dtb_wildcard with > | None -> () > | Some wildcard -> > find_dtb debug copy_kernel kernel_name wildcard dtb > ); > > (* Get the kernel modules. *) > let modpath = find_modpath debug kernel_version in > > if debug >= 1 then ( > printf "supermin: kernel: kernel_version %s\n" kernel_version; > printf "supermin: kernel: modules %s\n%!" modpath; > ); > > (kernel_version, modpath) > > and find_kernel debug host_cp...

...file matching '%s' in directory '%s'. You can set SUPERMIN_KERNEL, SUPERMIN_MODULES and SUPERMIN_DTB -to override automatic selection. See supermin(1).\n" - wildcard dtb_dir; - exit 1 +to override automatic selection. See supermin(1)." + wildcard dtb_dir and find_modpath debug kernel_version = try diff --git a/src/package_handler.ml b/src/package_handler.ml index 64b8f66..0409438 100644 --- a/src/package_handler.ml +++ b/src/package_handler.ml @@ -116,8 +116,8 @@ let check_system settings = handler := Some h; ph.ph_init settings with Not_found ->...

Hi, few cleanups in the supermin codebase; no actual functional change. Thanks, -- Pino Toscano (3): ext2: simplify tracking of visited modules utils: remove unused run_python function Add and use an helper error function src/build.ml | 20 +++++----------- src/dpkg.ml | 4 +--- src/ext2_initrd.ml | 10 ++++---- src/kernel.ml | 27

Document what each module does, using *.mli files. Remove the --dtb option, it's obsolete. Rename modules according to their purpose. Rich.

...= + find_kernel debug host_cpu copy_kernel kernel in + + (* If the user passed --dtb option, locate dtb. *) + (match dtb_wildcard with + | None -> () + | Some wildcard -> + find_dtb debug copy_kernel kernel_name wildcard dtb + ); + + (* Get the kernel modules. *) + let modpath = find_modpath debug kernel_version in + + if debug >= 1 then ( + printf "supermin: kernel: kernel_version %s\n" kernel_version; + printf "supermin: kernel: modules %s\n%!" modpath; + ); + + (kernel_version, modpath) + +and find_kernel debug host_cpu copy_kernel kernel = + let ker...