search for: finalize_transf

...erification step - Error in open() - by injecting error in imageio OPTIONS handler - Error in zero() - by injecting error in imageio PATCH handler - Error in flush() - by injecting error in imageio PATCH handler Nir Soffer (2): rhv-upload: Extract cancel_transfer() function rhv-upload: Extract finalize_transfer() function v2v/rhv-upload-plugin.py | 118 ++++++++++++++++++++++++++------------- 1 file changed, 78 insertions(+), 40 deletions(-) -- 2.21.0

...> NameError: name 'transfer_service' is not defined > > > >Does this fix the error for you? > > > https://github.com/nirs/virt-v2v/commit/2f93dbffad81a26445831293ecac213eadffbd57 > > > >I did not test it yet. > > > > If I remove the stray `def finalize_transfer(...)` it works, yes. > Right, belongs to the next patch. > In the meantime I managed to fix the original issue (which I needed to > revert to > test this patch =) ), thankfully it was just caused by my oVirt host setup. > > Unfortunately I am getting another issue. Now nbdki...

...gt; > >>> >Does this fix the error for you? >>> > >>> https://github.com/nirs/virt-v2v/commit/2f93dbffad81a26445831293ecac213eadffbd57 >>> > >>> >I did not test it yet. >>> > >>> >>> If I remove the stray `def finalize_transfer(...)` it works, yes. >>> >> >>Right, belongs to the next patch. >> >> >>> In the meantime I managed to fix the original issue (which I needed to >>> revert to >>> test this patch =) ), thankfully it was just caused by my oVirt host setup...

Fixes the majority of the pycodestyle issues in the Python scripts, and fix the existing test-v2v-python-syntax.sh to use pycodestyle to actually perform style checks. Pino Toscano (6): PEP 8: adapt whitespaces in lines PEP 8: move imports at the top PEP 8: adapt empty lines tests: find all the Python scripts for syntax checks -o rhv-upload: remove unused Python imports Revamp check

...extra["format"] = types.DiskFormat.RAW + transfer = transfers_service.add( types.ImageTransfer( disk = types.Disk(id = disk.id), host = host, inactivity_timeout = 3600, + **extra, ) ) @@ -591,6 +599,17 @@ def finalize_transfer(connection, transfer, disk_id): "timed out waiting for transfer %s to finalize" % transfer.id) +def transfer_supports_format(): + """ + Return True if transfer supports the "format" argument, enabing the NBD + bakend...

On Tue, Nov 19, 2019 at 11:17 AM Martin Kletzander <mkletzan@redhat.com> wrote: > > On Mon, Nov 18, 2019 at 11:53:39PM +0200, Nir Soffer wrote: > >This series extract oVirt SDK and imageio code to make it eaiser to follow the > >code and improve error handing in open() and close(). > > > >Tested with virt-v2v master. > > > >Changes since v1: >

...the error for you? > >>> > > >>> > https://github.com/nirs/virt-v2v/commit/2f93dbffad81a26445831293ecac213eadffbd57 > >>> > > >>> >I did not test it yet. > >>> > > >>> > >>> If I remove the stray `def finalize_transfer(...)` it works, yes. > >>> > >> > >>Right, belongs to the next patch. > >> > >> > >>> In the meantime I managed to fix the original issue (which I needed to > >>> revert to > >>> test this patch =) ), thankfully i...

...n >> transfer_service.cancel() >> NameError: name 'transfer_service' is not defined > >Does this fix the error for you? >https://github.com/nirs/virt-v2v/commit/2f93dbffad81a26445831293ecac213eadffbd57 > >I did not test it yet. > If I remove the stray `def finalize_transfer(...)` it works, yes. In the meantime I managed to fix the original issue (which I needed to revert to test this patch =) ), thankfully it was just caused by my oVirt host setup. Unfortunately I am getting another issue. Now nbdkit fails after all the data is written and it is trying to write t...

...;> > >> https://github.com/nirs/virt-v2v/commit/2f93dbffad81a26445831293ecac213eadffbd57 > >> >>> > > >> >>> >I did not test it yet. > >> >>> > > >> >>> > >> >>> If I remove the stray `def finalize_transfer(...)` it works, yes. > >> >>> > >> >> > >> >>Right, belongs to the next patch. > >> >> > >> >> > >> >>> In the meantime I managed to fix the original issue (which I needed to > >> >>>...

...ervice' is not defined >> > >> >Does this fix the error for you? >> > >> https://github.com/nirs/virt-v2v/commit/2f93dbffad81a26445831293ecac213eadffbd57 >> > >> >I did not test it yet. >> > >> >> If I remove the stray `def finalize_transfer(...)` it works, yes. >> > >Right, belongs to the next patch. > > >> In the meantime I managed to fix the original issue (which I needed to >> revert to >> test this patch =) ), thankfully it was just caused by my oVirt host setup. >> >> Unfortunatel...

...>> > >> >>> >> https://github.com/nirs/virt-v2v/commit/2f93dbffad81a26445831293ecac213eadffbd57 >> >>> > >> >>> >I did not test it yet. >> >>> > >> >>> >> >>> If I remove the stray `def finalize_transfer(...)` it works, yes. >> >>> >> >> >> >>Right, belongs to the next patch. >> >> >> >> >> >>> In the meantime I managed to fix the original issue (which I needed to >> >>> revert to >> >>> te...

Add support for qcow2 disk format, enabled by imageio NBD backend in RHV 4.3. To use this feature manually, you can run virt-v2v with "-of qcow2". Here is example run: Source disk: $ qemu-img info /var/tmp/fedora-30.img image: /var/tmp/fedora-30.img file format: raw virtual size: 6 GiB (6442450944 bytes) disk size: 1.15 GiB virt-v2v: $ ./run virt-v2v \ -v \ -i disk