search for: filldir

Since the d_off in the first dirent for "." (that originates from the 4th argument "offset" of filldir() for the 2nd dirent for "..") is wrongly assigned in btrfs_real_readdir(), telldir returns same offset for different locations. | # mkfs.btrfs /dev/sdb1 | # mount /dev/sdb1 fs0 | # cd fs0 | # touch file0 file1 | # ../test | telldir: 0 | readdir: d_off = 2, d_name = "."...

filldir_t can take this, so don't turn de->inode into a 32 bit value. Right now this doesn't make a difference since no ocfs2 inodes overflow that, but it could be a nasty surprise later on if some kernel code is calling ocfs2_dir_foreach_blk() and expecting real inode numbers back... Signed-of...

...ffff8010ee63>{call_softirq+31} <ffffffff80110a55>{do_softirq+53} <ffffffff8010e5c8>{apic_timer_interrupt+132} <EOI> <ffffffff801fb8a6>{do_get_write_access+118} <ffffffff801fb88e>{do_get_write_access+94} <ffffffff80185d1f>{__getblk+47} <ffffffff80195170>{filldir+0} <ffffffff801fbf69>{journal_get_write_access+41} <ffffffff801ec41c>{ext3_reserve_inode+write+76} <ffffffff80195170>{filldir+0} <ffffffff801ec4d8>{ext3_mark_inode_dirty+56} <ffffffff801fa9e5>{journal_start_229} <ffffffff801ee571>{ext3_dirty_inode+113} <ffff...

...00000 00000000 00000000 cf5bfd80 Jun 12 09:31:55 lemans kernel: c5c3e220 5d812e9f 00e74a2a 64fa5aec 00000000 00000000 cfb99000 00000004 Jun 12 09:31:55 lemans kernel: 00000000 00000000 00000001 00000006 ccaea335 cafb77c0 cd53ffb0 c013fec0 Jun 12 09:31:55 lemans kernel: Call Trace: [filldir+0/216] [nls_cp437:__insmod_nls_cp437_O/lib/modules/2.4.18-4GB/kernel/fs/nls/n+-9829579/96] [filldir+0/216] [filldir+0/216] [nls_cp437:__insmod_nls_cp437_O/lib/modules/2.4.18-4GB/kernel/fs/nls/n+-9829438/96] Jun 12 09:31:55 lemans kernel: [filldir+0/216] [nls_cp437:__insmod_nls_cp437_O/lib/module...

...task ffff880c6aeeeea0) Stack: ffff880c6c8b3ee8 0000000002347078 ffff88086c4b23a0 ffffffff8116bea0 <0> ffff880c6c8b3f38 ffff88086c4b2410 ffff880c6c8b3ef8 ffff88046bfbe0c0 <0> ffff880c6c8b3f38 ffffffff8116bea0 ffff88086e109720 ffff88086e109668 Call Trace: [<ffffffff8116bea0>] ? filldir+0x0/0xe0 [<ffffffff8116bea0>] ? filldir+0x0/0xe0 [<ffffffff8116c120>] vfs_readdir+0xc0/0xe0 [<ffffffff8116c2a9>] sys_getdents+0x89/0xf0 [<ffffffff8100c172>] system_call_fastpath+0x16/0x1b Code: 48 83 f8 02 4d 8d 7e 08 48 89 55 c8 0f 84 15 01 00 00 49 8b 5e 08 48 3b 5...

...task ffff880c6aeeeea0) Stack: ffff880c6c8b3ee8 0000000002347078 ffff88086c4b23a0 ffffffff8116bea0 <0> ffff880c6c8b3f38 ffff88086c4b2410 ffff880c6c8b3ef8 ffff88046bfbe0c0 <0> ffff880c6c8b3f38 ffffffff8116bea0 ffff88086e109720 ffff88086e109668 Call Trace: [<ffffffff8116bea0>] ? filldir+0x0/0xe0 [<ffffffff8116bea0>] ? filldir+0x0/0xe0 [<ffffffff8116c120>] vfs_readdir+0xc0/0xe0 [<ffffffff8116c2a9>] sys_getdents+0x89/0xf0 [<ffffffff8100c172>] system_call_fastpath+0x16/0x1b Code: 48 83 f8 02 4d 8d 7e 08 48 89 55 c8 0f 84 15 01 00 00 49 8b 5e 08 48 3b 5...

...ix_O/lib/modules/2.4.17/kernel/net/unix/unix.o_M+-1642892/96] [unix:__insmod_unix_O/lib/modules/2.4.17/kernel/net/unix/unix.o_M+-1656581/96] [unix:__insmod_unix_O/lib/modules/2.4.17/kernel/net/unix/unix.o_M+-1608504/96] [unix:__insmod_unix_O/lib/modules/2.4.17/kernel/net/unix/unix.o_M+-1608260/96] [filldir+174/224] [__mark_inode_dirty+46/160] [update_atime+81/96] [unix:__insmod_unix_O/lib/modules/2.4.17/kernel/net/unix/unix.o_M+-1627672/96] [open_namei+805/1680] [dentry_open+171/400] [kfree_skbmem+12/112] [filldir+0/224] [vfs_readdir+126/208] [filldir+0/224] [sys_getdents+71/160] [filldir+0/224...

...r_pos; - info->extra_fname = fname->next; + info->extra_fname = fname; return error; } fname = fname->next; @@ -457,9 +457,12 @@ * If there are any leftover names on the hash collision * chain, return them first. */ - if (info->extra_fname && - call_filldir(filp, dirent, filldir, info->extra_fname)) - goto finished; + if (info->extra_fname) { + if(call_filldir(filp, dirent, filldir, info->extra_fname)) + goto finished; + else + goto next_entry; + } if (!info->curr_node) info->curr_node = rb_first(&info->root); @@ -4...

...const char *error_msg = NULL; const int rlen = le16_to_cpu(de->rec_len); @@ -532,6 +532,26 @@ out: } /* + * This is intended to be called from inside other kernel functions, + * so we fake some arguments. + */ +int ocfs2_dir_foreach(struct inode *inode, loff_t *f_pos, void *priv, + filldir_t filldir) +{ + int ret = 0; + unsigned long version = inode->i_version; + + while (*f_pos < i_size_read(inode)) { + ret = ocfs2_dir_foreach_blk(inode, &version, f_pos, priv, + filldir); + if (ret) + break; + } + + return 0; +} + +/* * ocfs2_readdir() * */ diff --git a/f...

...9 06:28:53 vm2 kernel: [53400.204235] [<ffffffffa04d135b>] ? ocfs2_inode_lock_atime+0x73/0x23f [ocfs2] Aug 29 06:28:53 vm2 kernel: [53400.204243] [<ffffffffa04c8564>] ? ocfs2_dir_foreach_blk+0x48/0x435 [ocfs2] Aug 29 06:28:53 vm2 kernel: [53400.204248] [<ffffffff810fc34c>] ? filldir+0x0/0xb7 Aug 29 06:28:53 vm2 kernel: [53400.204257] [<ffffffffa04d13d5>] ? ocfs2_inode_lock_atime+0xed/0x23f [ocfs2] Aug 29 06:28:53 vm2 kernel: [53400.204261] [<ffffffff810fc34c>] ? filldir+0x0/0xb7 Aug 29 06:28:53 vm2 kernel: [53400.204269] [<ffffffffa04c9af3>] ? ocfs2_rea...

...irty_sync (mnt=0xffff88007862fd00, dentry=<value optimized out>) at include/linux/fs.h:1687 #2 touch_atime (mnt=0xffff88007862fd00, dentry=<value optimized out>) at fs/inode.c:1505 #3 0xffffffff810dfeb4 in file_accessed (file=0xffff88006afed600, filler=0xffffffff810dfcf8 <filldir>, buf=0xffff88007762bf38) at include/linux/fs.h:1763 #4 vfs_readdir (file=0xffff88006afed600, filler=0xffffffff810dfcf8 <filldir>, buf=0xffff88007762bf38) at fs/readdir.c:41 #5 0xffffffff810e001a in sys_getdents (fd=<value optimized out>, dirent=0x1f61468, count=32768) at f...

...ffffff810b0655>] ? dput+0x23/0x13d [902361.152475] [<ffffffff810faba9>] ? ext3_htree_fill_tree+0x7c/0x1e7 [902361.152479] [<ffffffff8109d927>] ? __kmalloc+0xf2/0x102 [902361.152483] [<ffffffff810f20d1>] ? ext3_readdir+0x173/0x554 [902361.152486] [<ffffffff810ae180>] ? filldir+0x0/0xb7 [902361.152490] [<ffffffff810a56e3>] ? cp_new_stat+0xe9/0xfc [902361.152493] [<ffffffff810ae180>] ? filldir+0x0/0xb7 [902361.152496] [<ffffffff810ae33f>] ? vfs_readdir+0x75/0xa7 [902361.152499] [<ffffffff810ae4a9>] ? sys_getdents+0x7a/0xc1 [902361.152503] [<...

...inodes+190/260] [ext3_getblk+198/568] [grow_inodes+32/428] [cprt+14006/37792] [ext3_find_entry+532/792] [get_new_inode+197/312] [iget4+117/128] [__brelse+29/192] [iget+22/32] [ext3_lookup+90/140] [real_lookup+91/180] [permission+32/56] [lookup_dentry+304/504] [getname+95/156] [__namei+49/104] [filldir+0/136] [sys_newlstat+20/116] [system_call+52/56] Code: 8b 47 08 3d 2b 2f c3 a5 0f 85 be 01 00 00 f6 46 05 01 0f 85 May 2 11:32:04 - Trying to remove the directory the du segfaulted in (i did not discover the oops of du before) Unable to handle kernel paging request at virtual addre...

On 6/29/07, Wojtek.Pilorz <wpilorz at bdk.pl> wrote: > On Fedora6, I have noted the folowing problems when using cifs to connect to > NT shares: > > - cp -vip does not copy mtime; tar x does copy mtime > (it seems setting modtime by fname does work, setting by handle does not) > - when there is a share mounted from a NT/2000 server which is not used for long time >

Here is the original set of fixes, split out into 14 individual ones. In addition to splitting them out, I also changed the ones that were HAS_* to NO_* as requested. The last two patches are needed to build on openSUSE 10.3 which is based on 2.6.22. I used it as a sanity check and found those failures. -Jeff -- Jeff Mahoney SUSE Labs

Can someone share the smbfs-2.4.19-pre9-readdir.patch. -----Original Message----- From: David.Lee@bisus.com [mailto:David.Lee@bisus.com] Sent: Tuesday, June 25, 2002 4:21 PM To: vlads@sympatico.ca; urban@teststation.com Cc: samba@lists.samba.org; David.Lee@bisus.com Subject: [Samba] RE: [PATCH] smbfs readdir fix (CFT: NetApp, OS/2) Vlad. I still got the same problem - 'ls | wc -l'

Hi, Here''s an implementation of NFS support for btrfs. It does not work in one particular case as described in http://www.mail-archive.com/linux-btrfs@vger.kernel.org/msg00298.html. This uses the btrfs_iget helper introduced previously. Comments ? --- Signed-off-by: Balaji Rao <balajirrao@gmail.com> diff -r 3f0eee804974 Makefile --- a/Makefile Thu Jun 26 10:34:20 2008 -0400

...ay 17 00:03:43 core kernel: Call Trace: [smb_init_dircache+11/28] [smb_proc_readdir_long+183/968] [start_next_request+78/96] [ide_intr+228/240] [smb_proc_readdir+35/60] [smb_refill_dircache+31/100] [smb_readdir+81/384] May 17 00:03:43 core kernel: [smb_dir_open+67/80] [sys_getdents+245/352] [filldir+0/132] [smb_readdir+0/384] [system_call+52/64] May 17 00:03:43 core kernel: Code: 8b 43 18 a8 01 75 0d 68 a9 0f 26 c0 e8 12 49 ff ff 83 c4 04 6. Run updatedb across the network with a recursive link, or manually cd through each directory. 7. See 2. for the test environment 7.1 server: -- Version...

I'm running a bit late with the e-mail this time around, but I think that's ok since there really isn't any major new features here - the bulk of the Ocfs2 update is bug fixes, or cleanups. The same goes for configfs. The only two things that could be described as features would be: - Sunil has updated Ocfs2 to provide even more live cluster locking information via debugfs. - Joel

The following patches implement indexed directory support in Ocfs2, mostly according to the design doc I wrote up a while ago: http://oss.oracle.com/osswiki/OCFS2/DesignDocs/IndexedDirectories The patches have been rebased on top of 2.6.29-rc2. It should be trivial to put them into merge_window. Things are what I'd call complete now. I'd like to get these into the merge_window branch