search for: filesystemstatcach

llvm[2]: Compiling FileSystemStatCache.cpp for Release+Asserts build FileSystemStatCache.cpp: In static member function 'static bool clang::FileSystemStatCache::get(const char*, stat&, bool, int*, clang::FileSystemStatCache*)': FileSystemStatCache.cpp:63: error: 'openFileForRead' is not a member of 'llvm::sys::f...

...changes and comment on them. Here's a brief explanation of what I did: - Convert argv to utf8 using current system locale for win32 (this is done as soon as possible inside ExpandArgv). This makes the driver happy since calls to llvm::sys::path::exists succeed. - Change calls to ::open (inside FileSystemStatCache and MemoryBuffer) to ::_wopen on win32 by converting the path to utf16. - In order to do the conversions I had to expose two functions, one of them was already there but wasn't visible, the other one was added by me Known issues: - I should probably use LLVM_ON_WIN32 instead of WIN32 but thi...

Nikola, Your patchset does not work; e>bin\clang.exe -S なかむら\たくみ.c error: error reading '邵コ・ェ邵コ荵昴・郢ァ蝎らクコ貅假ソ・邵コ・ソ.c' 1 error generated. - Would it be not enough in somewhere? I suspect clang still might be pathv1-dependent. (I guess, pathv1 would assume ansi) - raw_ostream does not handle utf8, but ansi, on win32. I would like to propose; - converting utf8 and utf16

The patch should work for unicode filename, I just realized that it doesn't work for unicode directories. FileSystemStatCache calls ::stat for directories, and this doesn't work for utf8 input the same way ::open doesn't work. I tried to replace it with ::_wstat but this function has a different signature. I think we should take a different approach: 1. convert all command line input to utf8 2. rework FileSystem...

Op 1 sep. 2011 14:12 schreef "NAKAMURA Takumi" <geek4civic at gmail.com> het volgende: > > Guys, welcome to the too weird i18n world! > We, Japanese, has got suffered for multibyte charset for 20 years. > > I have added a comment in http://llvm.org/bugs/show_bug.cgi?id=10348 . > Of course I know, I don't think it would be a practical resolution. > > FYI,

Guys, welcome to the too weird i18n world! We, Japanese, has got suffered for multibyte charset for 20 years. I have added a comment in http://llvm.org/bugs/show_bug.cgi?id=10348 . Of course I know, I don't think it would be a practical resolution. FYI, it seems clang can retrieve mbcs path with s/CP_UTF8/CP_ACP/g. E>bin\clang.exe -S なかむら\たくみ.c なかむら\たくみ.c:4:2: error: #error #error ^ 1

...t solution, it seems it would be better to use inode like the unix code does. Windows doesn't support inode (the s_ino field in stat), but it does have nFileIndexHigh/nFileIndexLow which are exposed via ::GetFileInformationByHandle and is basically the same thing. This would require refactoring FileSystemStatCache to use a new structure in place of stat that could be shared between Windows and Unix. This would be a lot of small changes but seems like it would be fairly straightforward. On Oct 3, 2011, at 9:21 AM, Nikola Smiljanic wrote: > towlower doesn't seem to work with my test string in Cyrill...

...it would be better to use > inode like the unix code does. Windows doesn't support inode (the s_ino > field in stat), but it does have nFileIndexHigh/nFileIndexLow which are > exposed via ::GetFileInformationByHandle and is basically the same thing. > This would require refactoring FileSystemStatCache to use a new structure in > place of stat that could be shared between Windows and Unix. This would be a > lot of small changes but seems like it would be fairly straightforward. > > > On Oct 3, 2011, at 9:21 AM, Nikola Smiljanic wrote: > > towlower doesn't seem to work wi...

...t solution, it seems it would be better to use inode like the unix code does. Windows doesn't support inode (the s_ino field in stat), but it does have nFileIndexHigh/nFileIndexLow which are exposed via ::GetFileInformationByHandle and is basically the same thing. This would require refactoring FileSystemStatCache to use a new structure in place of stat that could be shared between Windows and Unix. This would be a lot of small changes but seems like it would be fairly straightforward. > > > On Oct 3, 2011, at 9:21 AM, Nikola Smiljanic wrote: > >> towlower doesn't seem to work with...

towlower doesn't seem to work with my test string in Cyrillic. This function does locale-specific conversion, is this what we want? Here's the whole thing, with all the calls to ::stat replaced with llvm::sys::fs::Stat. On Fri, Sep 30, 2011 at 8:04 PM, Bryce Cogswell <bryceco at gmail.com> wrote: > You can use _iswupper and _towlower instead of CharLowerBuffW. They don't

You can use _iswupper and _towlower instead of CharLowerBuffW. They don't require windows.h and work with /Za. On Sep 30, 2011, at 12:24 AM, Nikola Smiljanic wrote: > I tried to do the conversion to lowercase inside GetFullPath by adding an additional bool parameter to this function. It's not perfect but seems much better than repeating the whole UTF8 to UTF16 and UTF16 to UTF8