search for: filesystem_available

Signed-off-by: Hu Tao <hutao@cn.fujitsu.com> --- daemon/available.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/daemon/available.c b/daemon/available.c index 7a8ede0..54c6b9b 100644 --- a/daemon/available.c +++ b/daemon/available.c @@ -166,7 +166,7 @@ do_filesystem_available (const char *filesystem) r = filesystem_available (filesystem); if (r == -1) { reply_with_error ("error testing for filesystem availability; " - "enable verbose mode and look at preceeding output"); + "enable verbose mode...

...sresize-force 32bitok 128-sector-alignment alignment align-first infile-uri btrfs xfs >./run guestfish -a /dev/null run : available error: incorrect number of arguments usage: available groups type 'help available' for more help on available >./run guestfish -a /dev/null run : filesystem_available ntfs true

...>device); + return get_blkid_tag (mountable->device, "LABEL"); } diff --git a/daemon/btrfs.c b/daemon/btrfs.c index 150c089..cf1507d 100644 --- a/daemon/btrfs.c +++ b/daemon/btrfs.c @@ -44,6 +44,30 @@ optgroup_btrfs_available (void) return prog_exists (str_btrfs) && filesystem_available ("btrfs") > 0; } +char * +btrfs_get_label (const char *device) +{ + int r; + CLEANUP_FREE char *err = NULL; + char *out = NULL; + size_t len; + + r = command (&out, &err, str_btrfs, "filesystem", "label", + device, NULL); + if (r == -1...

...evice); + } + return get_blkid_tag (mountable->device, "LABEL"); } diff --git a/daemon/btrfs.c b/daemon/btrfs.c index 150c089..cf1507d 100644 --- a/daemon/btrfs.c +++ b/daemon/btrfs.c @@ -44,6 +44,30 @@ optgroup_btrfs_available (void) return prog_exists (str_btrfs) && filesystem_available ("btrfs") > 0; } +char * +btrfs_get_label (const char *device) +{ + int r; + CLEANUP_FREE char *err = NULL; + char *out = NULL; + size_t len; + + r = command (&out, &err, str_btrfs, "filesystem", "label", + device, NULL); + if (r == -1...

..., or # delete the test if we are confident that all common filesystems are # supported. -# -# The reason why vfat is significant is because UEFI guests use it. set -e set -x @@ -36,13 +34,14 @@ $TEST_FUNCTIONS skip_if_skipped # UML does not support discard. skip_if_backend uml +skip_unless_filesystem_available minix img=test-virt-sparsify-in-place-fstrim-unsupported.img log=test-virt-sparsify-in-place-fstrim-unsupported.log rm -f $img $log -# Create a test filesystem with a single vfat filesystem. -guestfish -N $img=fs:vfat exit +# Create a test filesystem with a single minix filesystem. +guestfis...

This addresses the feedback on v1 here: https://www.redhat.com/archives/libguestfs/2018-September/msg00023.html Rich.

...tfs, +because there is no proper package in the host with utilities for it. +This is usually the case for C<btrfs>, C<ntfs>, and C<xfs> +filesystems. + +Check the results of: + + virt-resize --machine-readable + guestfish -a /dev/null run : available + guestfish -a /dev/null run : filesystem_available TYPE + +In this case, it is enough to install the proper packages +adding support for them. For example, C<libguestfs-xfs> on +Red Hat Enterprise Linux, CentOS, Debian, Ubuntu, and distributions +derived from them, for supporting the C<xfs> filesystem. + +=item 2. + +Virt-resize has no...

Although the commit message ties this to https://bugzilla.redhat.com/1804207, in fact I believe this commit could be applied independently. It's a simple optimization. Rich.

Since Linux commit f663b5b38fff trimming vfat is now supported by Linux. This broke the test which assumed it was not supported. Use another filesystem (minix) which does not support trimming instead. Thanks: Daniel P. Berrangé and Pino Toscano. --- ...virt-sparsify-in-place-fstrim-unsupported.sh | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git

Currently we are unable to properly run guestfsd (the daemon) under valgrind. Attempts to run valgrind inside the appliance have not been successful (see patch 1/7). However we desperately need better valgrind coverage of the daemon, particularly because it is doing a lot of complex parsing of program output. This has been a problem for a long time. A better way to attack this problem is to

In v2: - Kernel command line parsing now moved to the appliance. - In the captive daemon test, the daemon cleanly shuts down on exit. - Add another btrfs test. Rich.

...; #include "optgroups.h" +GUESTFS_EXT_CMD(str_btrfs, btrfs); +GUESTFS_EXT_CMD(str_btrfstune, btrfstune); +GUESTFS_EXT_CMD(str_btrfsck, btrfsck); +GUESTFS_EXT_CMD(str_mkfs_btrfs, mkfs.btrfs); + int optgroup_btrfs_available (void) { - return prog_exists ("btrfs") && filesystem_available ("btrfs") > 0; + return prog_exists (str_btrfs) && filesystem_available ("btrfs") > 0; } /* Takes optional arguments, consult optargs_bitmask. */ @@ -46,7 +51,7 @@ do_btrfs_filesystem_resize (const char *filesystem, int64_t size) size_t i = 0; char size_...

...include "optgroups.h" +GUESTFSD_EXT_CMD(str_btrfs, btrfs); +GUESTFSD_EXT_CMD(str_btrfstune, btrfstune); +GUESTFSD_EXT_CMD(str_btrfsck, btrfsck); +GUESTFSD_EXT_CMD(str_mkfs_btrfs, mkfs.btrfs); + int optgroup_btrfs_available (void) { - return prog_exists ("btrfs") && filesystem_available ("btrfs") > 0; + return prog_exists (str_btrfs) && filesystem_available ("btrfs") > 0; } /* Takes optional arguments, consult optargs_bitmask. */ @@ -46,7 +51,7 @@ do_btrfs_filesystem_resize (const char *filesystem, int64_t size) size_t i = 0; char size_...

...MD(str_btrfsimage, btrfs-image); - COMPILE_REGEXP (re_btrfs_subvolume_list, "ID\\s+(\\d+).*\\s" "top level\\s+(\\d+).*\\s" @@ -51,7 +44,7 @@ int optgroup_btrfs_available (void) { return test_mode || - (prog_exists (str_btrfs) && filesystem_available ("btrfs") > 0); + (prog_exists ("btrfs") && filesystem_available ("btrfs") > 0); } char * @@ -62,7 +55,7 @@ btrfs_get_label (const char *device) char *out = NULL; size_t len; - r = command (&out, &err, str_btrfs, "filesystem&q...

....btrfs", + "umount", "btrfs-image") COMPILE_REGEXP (re_btrfs_subvolume_list, "ID\\s+(\\d+).*\\s" @@ -51,7 +47,7 @@ int optgroup_btrfs_available (void) { return test_mode || - (prog_exists (str_btrfs) && filesystem_available ("btrfs") > 0); + (prog_exists ("btrfs") && filesystem_available ("btrfs") > 0); } char * @@ -62,7 +58,7 @@ btrfs_get_label (const char *device) char *out = NULL; size_t len; - r = command (&out, &err, str_btrfs, "filesystem&q...

Replace GUESTFSD_EXT_CMD with a command line option ‘./guestfsd --print-external-commands’

This is a follow-up to the other generator changes in: https://www.redhat.com/archives/libguestfs/2017-February/msg00217.html Rich.

This is a simpler patch that removes GUESTFSD_EXT_CMD completely.

...e"; added = (1, 0, 80); - style = RErr, [StringList "groups"], []; + style = RErr, [StringList (PlainString, "groups")], []; tests = [ InitNone, Always, TestRun [["available"; ""]], [] ]; @@ -1711,7 +1711,7 @@ See also C<guestfs_filesystem_available>." }; { defaults with name = "feature_available"; added = (1, 21, 26); - style = RBool "isavailable", [StringList "groups"], []; + style = RBool "isavailable", [StringList (PlainString, "groups")], []; tests = [ I...

Very large but mechanical change to the generator. Rich.