search for: fileops

Needs some work still, see in particular the commit message for patch 3. Rich.

Writing "file-like" plugins is hard because you have to implement your own .zero, .trim, .extents, etc, and that is very complicated. However implementations of these functions already exist in the file plugin. By factoring out the file plugin into a separate "fileops" mini-library we can reuse these implementations in other plugins. This refactoring commit creates a new mini-library called fileops, and uses it to implement the file plugin. Note that the name or prefix "file" leaks into fileops in a few places: the debug option is still called ‘...

...would be nice to reuse elsewhere. One possible approach (as outlined here) is simply to move the file callbacks (like file.pread, file.pwrite, file.zero etc) to a new mini-library. They can then be consumed by other plugins fairly easily by doing: static void * foo_open (int readonly) { struct fileops *fops; int fd, flags; /* Allocate *fops */ /* Set up fd however you want */ if (init_fileops (fd, fops) == -1) { free (fops); return NULL; } return fops; } static struct nbdkit_plugin plugin = { .name = "foo", .open = foo_open, .clos...

...plugins/iso/Makefile.am index a0fd337a..44ecbc8a 100644 --- a/plugins/iso/Makefile.am +++ b/plugins/iso/Makefile.am @@ -43,8 +43,9 @@ nbdkit_iso_plugin_la_SOURCES = \ $(NULL) nbdkit_iso_plugin_la_CPPFLAGS = \ - -I$(top_srcdir)/common/utils \ -I$(top_srcdir)/include \ + -I$(top_srcdir)/common/fileops \ + -I$(top_srcdir)/common/utils \ -I. \ $(NULL) nbdkit_iso_plugin_la_CFLAGS = $(WARNINGS_CFLAGS) @@ -53,6 +54,7 @@ nbdkit_iso_plugin_la_LDFLAGS = \ -Wl,--version-script=$(top_srcdir)/plugins/plugins.syms \ $(NULL) nbdkit_iso_plugin_la_LIBADD = \ + $(top_builddir)/common/fileops/libfileop...

...cient zeroing, pre-fetch and extents, which should give quite a performance boost. XXX On the flip side, it no longer ignores flush and FUA (which we can ignore because these are temporary disks), which very likely has a large negative impact on performance. Fixing this would involve generalising fileops a little. --- plugins/tmpdisk/Makefile.am | 2 + plugins/tmpdisk/tmpdisk.c | 247 +++++------------------------------- 2 files changed, 32 insertions(+), 217 deletions(-) diff --git a/plugins/tmpdisk/Makefile.am b/plugins/tmpdisk/Makefile.am index 20aeb05f..471a0f6a 100644 --- a/plugins/tmpdi...

...lugins/iso/iso.c | 99 +++++++++++++++++++---------------------- > 2 files changed, 48 insertions(+), 55 deletions(-) > > @@ -193,25 +195,43 @@ iso_get_ready (void) > static void * > iso_open (int readonly) > { > - return NBDKIT_HANDLE_NOT_NEEDED; > + struct fileops *fops; > + int fd; > + > + fops = malloc (sizeof *fops); > + if (fops == NULL) { > + nbdkit_error ("malloc: %m"); > + return NULL; > + } > + > + /* Copy the fd because fileops needs to have its own file descriptor. */ > + fd = dup (iso_fd); We us...

...-- >>   plugins/iso/Makefile.am |  4 +- >>   plugins/iso/iso.c       | 99 +++++++++++++++++++---------------------- >>   2 files changed, 48 insertions(+), 55 deletions(-) >> > Oops, you forgot to set #define NBDKIT_API_VERSION 2 Maybe in patch 1 you should add this to fileops.h: #if NBDKIT_API_VERSION - 0 != 2 # error This header requires API version 2 #endif -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Well, that wasn't as nasty as I feared it would be. Turns out that in the general case it's possible to partition a mixed-branch revision into branch cliques and generate multiple import-stream commits, one for each affected branch. We lose only if the split commit is the source of a later directory copy; I have a check for that that says, basically, "if you see this fatal error,

...s diff --git a/lib/sanitizer_common/tests/sanitizer_libc_test.cc b/lib/sanitizer_common/tests/sanitizer_libc_test.cc index 689c6ed..a304458 100644 --- a/lib/sanitizer_common/tests/sanitizer_libc_test.cc +++ b/lib/sanitizer_common/tests/sanitizer_libc_test.cc @@ -85,7 +85,7 @@ TEST(SanitizerCommon, FileOps) { EXPECT_EQ(len2, internal_write(fd, str2, len2)); internal_close(fd); - openrv = OpenFile(tmpfile, WrOnly); + openrv = OpenFile(tmpfile, RdWr); EXPECT_FALSE(internal_iserror(openrv)); fd = openrv; uptr fsize = internal_filesize(fd); @@ -134,7 +134,7 @@ TEST(SanitizerCommon, Inte...

I can reproduce your list of missing files; I've written a make production to generate it. Something extremely odd is happening here. I looked at the first such case, clients/cgilib.h. When I grep for it in my generated nut.fi, I see this: grep -nH -e clients/cgilib.h nut.fi nut.fi:77309:M 100644 :14 clients/cgilib.h nut.fi:9602662:M 100644 :14 clients/cgilib.h nut.fi:10381358:M 100644 :14

...n-mips64-with-call-Test/MemorySanitizer.UnalignedStore32 MemorySanitizer-Unit :: Msan-mips64-with-call-Test/MemorySanitizer.gethostbyname_r_erange MemorySanitizer-Unit :: Msan-mips64-with-call-Test/MemorySanitizer.ptrtoint SanitizerCommon-Unit :: Sanitizer-mips64-Test/SanitizerCommon.FileOps SanitizerCommon-Unit :: Sanitizer-mips64-Test/SanitizerIoctl.KVM_GET_LAPIC SanitizerCommon-Unit :: Sanitizer-mips64-Test/SanitizerIoctl.KVM_GET_MP_STATE SanitizerCommon-asan :: Linux/getpwnam_r_invalid_user.cc SanitizerCommon-lsan :: Linux/getpwnam_r_invalid_user.cc ThreadS...

Dear testers, Release Candidate 3 has just been tagged [1]. Please build, test, and upload to the sftp. If there are no regressions from previous release candidates, this will be the last release candidate before the final release. Release notes can still go into the branch. Thanks again for all your work! Hans [1] http://lists.llvm.org/pipermail/llvm-branch-commits/2016-February/009866.html

This is a consolidated reply to your four most recent emails. > I am trying to leverage reposurgeon to automate the process of finding merge > points, and I seem to be spinning my wheels. Can you provide an example of how > you are searching for merges? Not a working one, yet. That code is buggy. It's my next thing to work on. >reposurgeon% merge (apcsmart-dev)

...zer.UnalignedStore32 > MemorySanitizer-Unit :: Msan-mips64-with-call-Test/MemorySanitizer.gethostbyname_r_erange > MemorySanitizer-Unit :: Msan-mips64-with-call-Test/MemorySanitizer.ptrtoint > SanitizerCommon-Unit :: Sanitizer-mips64-Test/SanitizerCommon.FileOps > SanitizerCommon-Unit :: Sanitizer-mips64-Test/SanitizerIoctl.KVM_GET_LAPIC > SanitizerCommon-Unit :: Sanitizer-mips64-Test/SanitizerIoctl.KVM_GET_MP_STATE > SanitizerCommon-asan :: Linux/getpwnam_r_invalid_user.cc > SanitizerCommon-lsan...

...tributeBuffer & UnlockAttributeBuffer. d3dx9: Implement GetAttributeTable and SetAttributeTable. d3dx9: Implement ID3DXMesh::DrawSubset. Eric Pouech (3): services: Be sure to unlock the current database in all error cases in service_start_process. msvcrt: Added tests in fileops with different buffer management modes. msvcrt: ungetc must create a buffer, even if _IONBF has been set with setvbuf. Francois Gouget (11): setupapi: Fix the SetupDiGetActualSectionToInstallEx() definition. mshtml: get_channelbsc_mon() is unused so remove it. msi: Move msi...

https://bugs.freedesktop.org/show_bug.cgi?id=98039 Bug ID: 98039 Summary: KMail crash on starting (nouveau-related) Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: critical Priority: medium Component: Drivers/DRI/nouveau Assignee: