search for: filenamelist

...\");\n"; pr " }\n"; | OptString n -> pr " fprintf (fp, \"%%s\\n\", %s ? %s : \"null\");\n" n n - | StringList n | DeviceList n -> pr " print_strings (g, %s);\n" n + | StringList n | DeviceList n | FilenameList n -> + pr " print_strings (g, %s);\n" n | Bool n -> pr " fprintf (fp, \"%%s\\n\", %s ? \"true\" : \"false\");\n" n | Int n -> pr " fprintf (fp, \"%%d\\n\", %s);\n" n | Int64 n ->...

Very large but mechanical change to the generator. Rich.

...| Pathname n - | Dev_or_Path n | Mountable_or_Path n - | OptString n - | Key n - | FileIn n - | FileOut n - | GUID n -> + | String (_, n) + | OptString n -> pr "const gchar *%s" n - | StringList n - | DeviceList n - | FilenameList n -> + | StringList (_, n) -> pr "gchar *const *%s" n | BufferIn n -> pr "const guint8 *%s, gsize %s_size" n n @@ -1047,17 +1038,17 @@ guestfs_session_close (GuestfsSession *session, GError **err) pr " (type gint32):"...

...eck_arg_type args; ) (actions |> daemon_functions); + (* Some String/stringt and StringList/stringt combinations are + * not permitted. + *) + List.iter ( + fun { name = name; style = _, args, _ } -> + let check_arg_type = function + (* Previously only DeviceList and FilenameList were special list + * types. We could permit more here in future. + *) + | StringList (FileIn, _) + | StringList (FileOut, _) + | StringList (Mountable, _) + | StringList (Pathname, _) + | StringList (Dev_or_Path, _) + | StringList (Mountab...

...quot; guestfs_string_length %s_size;\n" n | OptString n -> pr " char *%s = NULL;\n" n; - pr " int %s_size;\n" n + pr " guestfs_string_length %s_size;\n" n | StringList n | DeviceList n | FilenameList n -> @@ -270,7 +317,7 @@ PHP_FUNCTION (guestfs_last_error) | OInt n | OInt64 n -> pr " long optargs_t_%s = -1;\n" n | OString n -> pr " char *optargs_t_%s = NULL;\n" n; - pr " int optargs_t_%s_size = -1;\n"...

Hi, this patch series fixes some issues discovered by Coverity. Most of them are memory leaks, usually on error; there are also invalid memory access issues. Thanks, Pino Toscano (11): java: link libguestfs_jni against libutils java: fix invalid memory access for FBuffer in struct lists daemon: tsk: properly use GUESTFS_MAX_CHUNK_SIZE edit: fix small memory leak on error java: fix

The safe_malloc (etc) functions call g->abort_fn on failure. That's not appropriate for language bindings, and we never intended that these internal functions be used from language bindings, that was just a historical accident. This patch series removes any external use of the safe_* functions. Rich.

This is a series of simplifications to the stubs code. It's all refactoring, there is no functional change. Rich.

...;guestfs_add_drive_ro> but it allows you @@ -88,7 +88,7 @@ to specify the QEMU interface emulation to use at run time." }; { defaults with name = "lstatlist"; added = (1, 0, 77); style = RStructList ("statbufs", "stat"), [Pathname "path"; FilenameList "names"], []; - deprecated_by = Some "lstatnslist"; + deprecated_by = Replaced_by "lstatnslist"; shortdesc = "lstat on multiple files"; longdesc = "\ This call allows you to perform the C<guestfs_lstat> operation @@ -108,7 +108,7 @...

This is a follow-up to the other generator changes in: https://www.redhat.com/archives/libguestfs/2017-February/msg00217.html Rich.

...inter is not supported for daemon function %s." @@ -158,7 +158,7 @@ let () = * not permitted. *) List.iter ( - fun { name = name; style = _, args, _ } -> + fun { name; style = _, args, _ } -> let check_arg_type = function (* Previously only DeviceList and FilenameList were special list * types. We could permit more here in future. @@ -179,7 +179,7 @@ let () = (* Check short descriptions. *) List.iter ( - fun { name = name; shortdesc = shortdesc } -> + fun { name; shortdesc } -> if shortdesc.[0] <> Char.lowercase_ascii...

Split up the huge generator/actions.ml into several smaller files. Rich.

Hi, this series cleans up the Python sources, either static or generated, including also tests, to make them PEP 8 compliant; see https://www.python.org/dev/peps/pep-0008/ and tools like pep8. Almost all the issues reported by pep8 are fixed, reducing the issues from 3818 to 7. The changes should have no effect on the actual code, while it will help Python users with consistency with other

...ascii test_name) + (String.uppercase_ascii name); if not_disabled then ( generate_test_perform name i test_name test; @@ -441,7 +444,7 @@ and generate_test_command_call ?(expect_error = false) ?(do_return = true) ?test | StringList _, arg, sym | DeviceList _, arg, sym | FilenameList _, arg, sym -> - let strs = string_split " " arg in + let strs = String.nsplit " " arg in iteri ( fun i str -> pr " const char *%s_%d = \"%s\";\n" sym i (c_quote str); @@ -489,7 +492,7 @@ and generate_test_command_c...

Per my previous email: https://www.redhat.com/archives/libguestfs/2017-September/msg00203.html I'd like to talk about requiring a more modern version of the OCaml compiler. These commits show some of the code changes which would be possible with OCaml >= 3.12 [which it turns out we already require by accident] and also with OCaml >= 4.02. The latter is my favoured option. Rich.