search for: filemap_fdatawrite

I removed this in an earlier commit and I was wrong. Because compression can return from filemap_fdatawrite() without having actually set any of it''s pages as writeback() it can make filemap_fdatawait() do essentially nothing, and then we won''t find any ordered extents because they may not have been created yet. So not only does this make fsync() completely useless, but it will also sc...

...3:10:05 devil kernel: Call Trace: [mpage_writepages+990/1971] [filemap_nopage+243/612] [do_no_page+617/784] [handle_mm_fault+149/360] [__set_page_dirty_buffers+344/404] Sep 21 23:10:05 devil kernel: [filemap_sync_pte+106/116] [ext3_writepages+31/48] [ext3_get_block+0/104] [do_writepages+24/44] [filemap_fdatawrite+93/112] [msync_interval+102/196] Sep 21 23:10:05 devil kernel: [sys_msync+169/250] [syscall_call+7/11] Sep 21 23:10:05 devil kernel: Sep 21 23:10:05 devil kernel: Code: 0f 0b 55 03 7a 24 2f c0 83 c4 14 6a 01 56 8b 44 24 1c 50 8b

...s/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c index e622013..e335541 100644 --- a/fs/ocfs2/dlmglue.c +++ b/fs/ocfs2/dlmglue.c @@ -2718,6 +2718,15 @@ static int ocfs2_data_convert_worker(str inode = ocfs2_lock_res_inode(lockres); mapping = inode->i_mapping; + /* + * We need this before the filemap_fdatawrite() so that it can + * transfer the dirty bit from the PTE to the + * page. Unfortunately this means that even for EX->PR + * downconverts, we'll lose our mappings and have to build + * them up again. + */ + unmap_mapping_range(mapping, 0, 0, 0); + if (filemap_fdatawrite(mapping)) {...

Hello, We found that fsync and fdatasync syscalls sometimes don't sync data in an ext3 file system under the following conditions. 1. Kernel version is 2.6.6 or later (including 2.6.8.1 and 2.6.9-rc2). 2. Ext3's journalling mode is "data=journal". 3. Create a file (whose size is 1Mbytes) and execute umount/mount. 4. lseek to a random position within the file, write 8192 bytes

...0x1ce/0x3f0 [btrfs] Aug 4 02:26:06 rohan kernel: [ 3878.951105] [<ffffffffa0506ff8>] btrfs_writepages+0x28/0x30 [btrfs] Aug 4 02:26:06 rohan kernel: [ 3878.951105] [<ffffffff811245c1>] do_writepages+0x21/0x40 Aug 4 02:26:06 rohan kernel: [ 3878.951105] [<ffffffff8111a8bb>] __filemap_fdatawrite_range+0x5b/0x60 Aug 4 02:26:06 rohan kernel: [ 3878.951105] [<ffffffff8111b2af>] filemap_fdatawrite+0x1f/0x30 Aug 4 02:26:06 rohan kernel: [ 3878.951105] [<ffffffff8111b2f5>] filemap_write_and_wait+0x35/0x60 Aug 4 02:26:06 rohan kernel: [ 3878.951105] [<ffffffffa053ad2f>] __...

..._writepage+0x70/0x70 [btrfs] [ 153.914871] [<ffffffffa01b191e>] ? free_extent_state+0x1e/0x30 [btrfs] [ 153.914919] [<ffffffffa0193338>] btrfs_writepages+0x28/0x30 [btrfs] [ 153.916201] [<ffffffff81118082>] do_writepages+0x22/0x50 [ 153.916315] [<ffffffff8110d5fb>] __filemap_fdatawrite_range+0x5b/0x60 [ 153.916315] [<ffffffff8110d61f>] filemap_fdatawrite+0x1f/0x30 [ 153.920013] [<ffffffff8110d665>] filemap_write_and_wait+0x35/0x60 [ 153.920013] [<ffffffffa01cf622>] __btrfs_write_out_cache+0x792/0x9a0 [btrfs] [ 153.920013] [<ffffffffa0175b25>] ? __f...

...fs.h 2005-01-04 19:58:48.000000000 +0900 @@ -1341,7 +1341,7 @@ invalidate_inode_pages(inode->i_mapping); } extern void invalidate_inode_pages2(struct address_space *mapping); -extern void write_inode_now(struct inode *, int); +extern int write_inode_now(struct inode *, int); extern int filemap_fdatawrite(struct address_space *); extern int filemap_flush(struct address_space *); extern int filemap_fdatawait(struct address_space *); diff -Nru linux-2.4.29-pre3-bk2/fs/ext3/fsync.c linux-2.4.29-pre3-bk2_fix/fs/ext3/fsync.c --- linux-2.4.29-pre3-bk2/fs/ext3/fsync.c 2002-11-29 08:53:15.0000000...