search for: filecheck_dump_input_on_error

...d attempt. The new behavior is as follows: 1. In case of errors we always dump output to a temporary file and print Saving input file "<stdin>" to "/tmp/filecheck.txt-Jno73y" 2. If --dump-input-on-error option is passed, FileCheck will also dump input to stderr. 3. If FILECHECK_DUMP_INPUT_ON_ERROR env var is set, lit will replace "%FileCheck" with "FileCheck --dump-input-on-error". I will fix all tests in LLVM and Clang if we decide this is the way to go. Dmitri -- main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if (j){printf("%d\n",i);}}}...

...to me. It's really common in a normal development scenario to do something, test and have stuff fail. It doesn't make sense to dump things into /tmp in this case. > 2. If --dump-input-on-error option is passed, FileCheck will also dump > input to stderr. This is fine. > 3. If FILECHECK_DUMP_INPUT_ON_ERROR env var is set, lit will replace > "%FileCheck" with "FileCheck --dump-input-on-error". Sounds good for lit. > I will fix all tests in LLVM and Clang if we decide this is the way to go. What tests need to be fixed? FileCheck -> %FileCheck? You should check with Dan...

On Wed, Jan 16, 2013 at 9:24 PM, Chris Lattner <clattner at apple.com> wrote: > > On Jan 16, 2013, at 10:32 AM, Dmitri Gribenko <gribozavr at gmail.com> wrote: > >> Hello, >> >> When someone breaks a FileCheck-based test on some buildbot, sometimes >> it may not be obvious *why* did it fail. If the failure can not be >> reproduced locally, it can

...on in a normal development scenario to do something, test and have stuff fail. It doesn't make sense to dump things into /tmp in this case. > >> 2. If --dump-input-on-error option is passed, FileCheck will also dump >> input to stderr. > > This is fine. > >> 3. If FILECHECK_DUMP_INPUT_ON_ERROR env var is set, lit will replace >> "%FileCheck" with "FileCheck --dump-input-on-error". > > Sounds good for lit. > >> I will fix all tests in LLVM and Clang if we decide this is the way to go. > > What tests need to be fixed? FileCheck -> %FileChe...

...ea sounds awesome, and I'd be happy to see any variation of it on the bots ASAP. > > Saving input file "<stdin>" to "/tmp/filecheck.txt-Jno73y" > > 2. If --dump-input-on-error option is passed, FileCheck will also dump > input to stderr. > > 3. If FILECHECK_DUMP_INPUT_ON_ERROR env var is set, lit will replace > "%FileCheck" with "FileCheck --dump-input-on-error". > > I will fix all tests in LLVM and Clang if we decide this is the way to go. > > Dmitri > > -- > main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}i...