search for: file_architectur

The previously library-side ‘file_architecture’ API is reimplemented in the daemon, in OCaml. There are some significant differences compared to the C implementation: - The C code used libmagic. That is replaced by calling the ‘file’ command (because that is simpler than using the library). - The C code had extra cases to deal with co...

Patch extracts MSB/LSB info from /bin/file output and passes it as separate parameret from elf_arch. Then it is sent to impl_file_architecture and checked/ Modified magic_for_file to handle regex changes. Now with tests for file_architecture. Fixes: RHBZ#1211996 Maros Zatko (2): inspector: recognize ppc64 and ppc64le archs (RHBZ#1211996) tests: ppc64 and ppc64le for file_architecture generator/actions.ml | 8 ++++++++ src/file...

...ns(-) diff --git a/generator/actions.ml b/generator/actions.ml index 4447de6..6648d63 100644 --- a/generator/actions.ml +++ b/generator/actions.ml @@ -788,6 +788,10 @@ to specify the QEMU interface emulation to use at run time." }; InitISOFS, Always, TestResultString ( [["file_architecture"; "/bin-i586-dynamic"]], "i386"), []; InitISOFS, Always, TestResultString ( + [["file_architecture"; "/bin-ppc64-dynamic"]], "ppc64"), []; + InitISOFS, Always, TestResultString ( + [["file_architecture"; &qu...

Patch extracts MSB/LSB info from /bin/file output and passes it as separate parameret from elf_arch. Then it is sent to impl_file_architecture and checked/ Modified magic_for_file to handle regex changes. Now with tests for file_architecture, and error reporting for unknown endianness. Fixes: RHBZ#1211996 Maros Zatko (1): inspector: recognize ppc64 and ppc64le archs (RHBZ#1211996) generator/actions.ml | 8 ++++++++ src/filearch....

...ls.ml index 3313aabc7..889ec2f2a 100644 --- a/v2v/linux_kernels.ml +++ b/v2v/linux_kernels.ml @@ -189,7 +189,7 @@ let detect_kernels (g : G.guestfs) inspect family bootloader = *) let arch = let any_module = modpath ^ List.hd modules in - g#file_architecture any_module in + g#file_architecture (g#realpath any_module) in (* Just return the module names, without path or extension. *) let modules = List.filter_map ( -- 2.20.1

...ats, logging, etc. http://et.redhat.com/~rjones/virt-top -------------- next part -------------- >From 22bddca227ebe52fc668ff0bddee7ddfeb3dd475 Mon Sep 17 00:00:00 2001 From: Richard Jones <rjones at trick.home.annexia.org> Date: Tue, 28 Jul 2009 17:55:35 +0100 Subject: [PATCH] Lib.pm: Add file_architecture command. This command detects the architecture of some types of binaries, libraries, kernel modules and initrd images. --- .gitignore | 6 ++- images/Makefile.am | 44 +++++++++++- images/README-binfiles | 13 ++++ images/bin-i586-dynamic | Bin 0 ->...

...90x.so diff --git a/generator/actions.ml b/generator/actions.ml index 91a1819..43de38b 100644 --- a/generator/actions.ml +++ b/generator/actions.ml @@ -798,6 +798,8 @@ to specify the QEMU interface emulation to use at run time." }; InitISOFS, Always, TestResultString ( [["file_architecture"; "/bin-riscv64-dynamic"]], "riscv64"), []; InitISOFS, Always, TestResultString ( + [["file_architecture"; "/bin-s390x-dynamic"]], "s390x"), []; + InitISOFS, Always, TestResultString ( [["file_architecture&quot...

Version 1 was here: https://www.redhat.com/archives/libguestfs/2017-June/msg00003.html This patch series reimplements a few more APIs in OCaml, including some very important core APIs like ?list_filesystems? and ?mount?. All the tests pass after this. The selection of APIs that I have moved may look a little random, but in fact they are all APIs consumed by the inspection code (and some more

...lename, bool *loading_ok, if (matched) *matched = true; - return canonical_elf_arch (g, endianness, elf_arch); + return canonical_elf_arch (g, bits, endianness, elf_arch); } /* Download and uncompress the cpio file to find binaries within. */ @@ -319,6 +327,7 @@ char * guestfs_impl_file_architecture (guestfs_h *g, const char *path) { CLEANUP_FREE char *file = NULL; + CLEANUP_FREE char *bits = NULL; CLEANUP_FREE char *elf_arch = NULL; CLEANUP_FREE char *endianness = NULL; char *ret = NULL; @@ -330,8 +339,8 @@ guestfs_impl_file_architecture (guestfs_h *g, const char *path) if (...

...- a/src/inspect-fs-unix.c +++ b/src/inspect-fs-unix.c @@ -1082,10 +1082,22 @@ check_architecture (guestfs_h *g, struct inspect_fs *fs) char *arch; for (i = 0; i < sizeof binaries / sizeof binaries[0]; ++i) { - if (guestfs_is_file (g, binaries[i]) > 0) { - /* Ignore errors from file_architecture call. */ + /* Allow symlinks when checking the binaries:,so in case they are + * relative ones (which can be resolved within the same partition), + * then we can check the architecture of their target. + */ + if (guestfs_is_file_opts (g, binaries[i], +...

...rty + * modules (RHBZ#1690574), try to pick one of the well + * known modules, if available. Otherwise, an arbitrary + * module is used. *) let arch = - let any_module = modpath ^ List.hd modules in - g#file_architecture any_module in + (* Well known kernel modules. *) + let candidates = [ "virtio"; "kvm" ] in + let all_candidates = List.flatten ( + List.map ( + fun f -> + [ "/" ^ f ^ &q...

...er starting conversation, at the time of decompressing kernel, after loading modules by iso we are getting below error, *file -zb /sysroot/lib/modules/3.17.4-301.fc21.x86_64/kernel/arch/x86/crypto/blowfish-x86_64.ko.xz* *libguestfs: trace: file = "XZ compressed data"* *libguestfs: trace: file_architecture = NULL (error)* *virt-v2v: error: libguestfs error: file_architecture: unknown architecture: * */lib/modules/3.17.4-301.fc21.x86_64/kernel/arch/x86/crypto/blowfish-x86_64.ko.xz* *If reporting bugs, run virt-v2v with debugging enabled and include the * *complete output:* * virt-v2v -v -x [...]*...

All the files in /bin are links to busybox. guestfs_file_architecture doesn't follow symlinks so it fails. Therefore check /bin/busybox (not a symlink) to find the architecture. --- src/inspect-fs-unix.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/inspect-fs-unix.c b/src/inspect-fs-unix.c index f915e86..6aaf5a1 100644 --- a/src/in...

v2 was here: https://www.redhat.com/archives/libguestfs/2017-June/msg00008.html This series gets as far as a working (and faster) reimplementation of ‘guestfs_list_filesystems’. I also have another patch series on top of this one which reimplements the inspection APIs inside the daemon, but that needs a bit more work still, since inspection turns out to be a very large piece of code. Rich.

I think this fixes everything mentioned: - Added the Optgroups module as suggested. - Remove command temporary files. - Replace command ~flags with ?fold_stdout_on_stderr. - Nest _with_mounted function. - Rebase & retest. Rich.

v1 was posted here: https://www.redhat.com/archives/libguestfs/2017-July/msg00098.html This series now depends on two small patches which I posted separately: https://www.redhat.com/archives/libguestfs/2017-July/msg00207.html https://www.redhat.com/archives/libguestfs/2017-July/msg00209.html v1 -> v2: - Previously changes to generator/daemon.ml were made incrementally through the patch

Previously posted as part of the mega utilities/inspection series here: https://www.redhat.com/archives/libguestfs/2017-June/msg00232.html What I've done is to extract just the parts related to rewriting daemon APIs in OCaml, rebase them on top of the current master, fix a few things, and recompile and test everything. Rich.

...0644 > --- a/v2v/linux_kernels.ml > +++ b/v2v/linux_kernels.ml > @@ -189,7 +189,7 @@ let detect_kernels (g : G.guestfs) inspect family bootloader = > *) > let arch = > let any_module = modpath ^ List.hd modules in > - g#file_architecture any_module in > + g#file_architecture (g#realpath any_module) in I don't mind this, but would it better to fix the actual API? Anyway either way is fine so ACK. Rich. > (* Just return the module names, without path or extension. *) > let m...

...he time of decompressing kernel, after > loading modules by iso we are getting below error, > > *file -zb > /sysroot/lib/modules/3.17.4-301.fc21.x86_64/kernel/arch/x86/crypto/blowfish-x86_64.ko.xz* > *libguestfs: trace: file = "XZ compressed data"* > *libguestfs: trace: file_architecture = NULL (error)* > *virt-v2v: error: libguestfs error: file_architecture: unknown > architecture: * > */lib/modules/3.17.4-301.fc21.x86_64/kernel/arch/x86/crypto/blowfish-x86_64.ko.xz* This was fixed upstream: https://github.com/libguestfs/libguestfs/commit/7291b226d1b08c762ae2f2715a2ac9...

...sysfs defaults 0 0 proc /proc proc defaults 0 0 LABEL=SWAP-sda2 swap swap defaults 0 0 " libguestfs: trace: is_file "/bin/bash" libguestfs: trace: is_file = 1 libguestfs: trace: file_architecture "/bin/bash" libguestfs: trace: file "/bin/bash" libguestfs: trace: file = "ELF 32-bit LSB executable, Intel 80386, version 1 (SYSV), dynamically linked (uses shared libs), for GNU/Linux 2.6.9, stripped" libguestfs: trace: file_architecture = "i386" libguestf...