search for: fetch_windows_environment

...ure from OpenSSH 3.8.1p1 to Cygwin 1.7 (which includes OpenSSH 5.4p1) and noticed that when running commands via ssh on my Windows machines I no longer have access to the full set of Windows environment variables. Digging through source, I see that this change was introduced in v4.0 (the "fetch_windows_environment()" function in openbsd-compat/bsd-cygwin_util.c). Can anyone shed light on why this was thought to be a "bug" needing fixing? And, more importantly, is there a way to work around this? Our build system relies on having access to the full set of Windows environment variables such...

On Wed, 20 Feb 2019 at 23:54, Corinna Vinschen <vinschen at redhat.com> wrote: > The previous revert enabled case-insensitive user names again. This > patch implements the case-insensitive user and group name matching. > To allow Unicode chars, implement the matcher using wchar_t chars in > Cygwin-specific code. Keep the generic code changes as small as possible. > Cygwin:

...le: /usr/local/src/security/openssh/cvs/openssh_cvs/openbsd-compat/bsd-cygwin_util.c,v retrieving revision 1.16 diff -u -p -r1.16 bsd-cygwin_util.c --- openbsd-compat/bsd-cygwin_util.c 25 Mar 2006 13:03:24 -0000 1.16 +++ openbsd-compat/bsd-cygwin_util.c 4 May 2006 02:02:57 -0000 @@ -268,7 +268,7 @@ fetch_windows_environment(void) char **e, **p; unsigned int i, idx = 0; - p = xmalloc((WENV_SIZ + 1) * sizeof(char *)); + p = xcalloc(WENV_SIZ + 1, sizeof(char *)); for (e = environ; *e != NULL; ++e) { for (i = 0; i < WENV_SIZ; ++i) { if (!strncmp(*e, wenv_arr[i].name, wenv_arr[i].namelen)) -- Darren Tuc...

...diff --git a/openbsd-compat/bsd-cygwin_util.h b/openbsd-compat/bsd-cygwin_util.h index 202c055dbae7..55c5a5b81b44 100644 --- a/openbsd-compat/bsd-cygwin_util.h +++ b/openbsd-compat/bsd-cygwin_util.h @@ -55,6 +55,7 @@ int binary_open(const char *, int , ...); int check_ntsec(const char *); char **fetch_windows_environment(void); void free_windows_environment(char **); +int cygwin_ug_match_pattern_list(const char *, const char *); #ifndef NO_BINARY_OPEN #define open binary_open diff --git a/servconf.c b/servconf.c index 4fa896fd4576..2365e15bca93 100644 --- a/servconf.c +++ b/servconf.c @@ -1049,11 +1049,7 @@ ma...

Hi, OpenSSH 5.9 is almost ready for release, so we would appreciate testing on as many platforms and systems as possible. This release contains a couple of new features and changes and bug fixes. Testing of the new sandboxed privilege separation mode (see below) would be particularly appreciated. Snapshot releases for portable OpenSSH are available from http://www.mindrot.org/openssh_snap/ The