search for: ferror_xfer

...the patch can go as follows: https://gist.github.com/anonymous/96ba8bf10f864a93fd9203f75c43ffe9 . Basically we need to do two changes: (1) in options.c, make sure that the "missing_args" value is transferred when set ; and (2) in rsync.c, in the "missing_args" case, replace FERROR_XFER with something else, since apparently any log message with logcode FERROR_XFER sets the flag 'got_xfer_error' in log.c, and that finally leads to exit code RERR_PARTIAL (23), which is what we are trying to avoid. I am currently testing this on fairly big datasets to see if there's...

...X_DIGEST_LEN]; static char file_sum2[MAX_DIGEST_LEN]; struct map_struct *mapbuf; @@ -285,10 +287,14 @@ goto report_write_error; #ifdef HAVE_FTRUNCATE - if (inplace && fd != -1 - && ftruncate(fd, offset) < 0) { - rsyserr(FERROR_XFER, errno, "ftruncate failed on %s", - full_fname(fname)); + (void)do_fstat(fd,&st); + /* Makes no sense to attempt to ftruncate() a block device: */ + if (!(IS_DEVICE(st.st_mode))) { + if (inplace && fd != -1 +...

...e(fnametmp, fname)) + goto cleanup; + if (!mktemp(fnametmp)) + goto cleanup; + if (do_symlink(sl, fnametmp) != 0) { + rsyserr(FERROR_XFER, errno, "symlink %s -> \"%s\" failed", + full_fname(fnametmp), sl); + goto cleanup; + } + set_file_attrs(fnametmp, file, NULL, NULL,...

...; https://gist.github.com/anonymous/96ba8bf10f864a93fd9203f75c43ffe9 . > > Basically we need to do two changes: > > (1) in options.c, make sure that the "missing_args" value is transferred > when set ; and > (2) in rsync.c, in the "missing_args" case, replace FERROR_XFER with > something else, since apparently any log message with logcode > FERROR_XFER sets the flag 'got_xfer_error' in log.c, and that finally > leads to exit code RERR_PARTIAL (23), which is what we are trying to avoid. > > I am currently testing this on fairly big datasets t...

...gt; https://gist.github.com/anonymous/96ba8bf10f864a93fd9203f75c43ffe9 . > > Basically we need to do two changes: > > (1) in options.c, make sure that the "missing_args" value is transferred > when set ; and > (2) in rsync.c, in the "missing_args" case, replace FERROR_XFER with > something else, since apparently any log message with logcode FERROR_XFER > sets the flag 'got_xfer_error' in log.c, and that finally leads to exit > code RERR_PARTIAL (23), which is what we are trying to avoid. > > I am currently testing this on fairly big datasets to...

While going through an old todo list I found that these patches had fallen by the way-side. About a year ago I initiated a discussion[1] with the Linux kernel folks regarding the lack of any useable fadvise support on the kernel side. As a result, I was observing extremely poor performance on my server after backup as executable pages were being swapped out in favor of data waiting to be flushed

...b.com/anonymous/96ba8bf10f864a93fd9203f75c43ffe9> . > > Basically we need to do two changes: > > (1) in options.c, make sure that the "missing_args" value is > transferred when set ; and > (2) in rsync.c, in the "missing_args" case, replace FERROR_XFER with > something else, since apparently any log message with logcode > FERROR_XFER sets the flag 'got_xfer_error' in log.c, and that > finally leads to exit code RERR_PARTIAL (23), which is what we are > trying to avoid. > > I am currently testing this...

...fnametmp[length++] = '.'; } // End Modified Code /* The maxname value is bufsize, and includes space for the '\0'. * (Note that NAME_MAX get -8 for the leading '.' above.) */ maxname = MIN(MAXPATHLEN - 7 - length, NAME_MAX - 8); if (maxname < 1) { rprintf(FERROR_XFER, "temporary filename too long: %s\n", fname); fnametmp[0] = '\0'; return 0; } added = strlcpy(fnametmp + length, f, maxname); if (added >= maxname) added = maxname - 1; memcpy(fnametmp + length + added, ".XXXXXX", 8); return 1; }

This is a PoC patch for NFSv4/ZFS ACLs. The objective of the patch is that rsync --acls support NFSv4/ZFS ACLs without requiring a new command line option NFSv4 ACLs can't be represented using POSIX draft ACLs, if an NFSv4 ACL is present a separate POSIX draft ACL will not be present and there are new APIs to access NFSv4 ACLs. So we need to distinguish between NFSv4 ACLs and POSIX ACLs in

The security.evm extended attribute is fully owned by the Linux kernel and cannot be directly written from userspace. Therefore, we can always skip it. --- xattrs.c | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/xattrs.c b/xattrs.c index b105392..3b72e61 100644 --- a/xattrs.c +++ b/xattrs.c @@ -255,6 +255,9 @@ static int rsync_xal_get(const char *fname,

...har *dn = file->dirname ? file->dirname : "."; if (parent_dirname != dn && strcmp(parent_dirname, dn) != 0) { if (relative_paths && !implied_dirs - && do_stat(dn, &sx.st) < 0 - && create_directory_path(fname) < 0) { - rsyserr(FERROR_XFER, errno, - "recv_generator: mkdir %s failed", - full_fname(dn)); + && do_stat(dn, &sx.st) < 0) { + if (dry_run) + goto parent_is_dry_missing; + if (create_directory_path(fname) < 0) { + rsyserr(FERROR_XFER, errno, + "recv_generator: mkdi...

...tern struct stats stats; extern char *tmpdir; @@ -286,7 +287,7 @@ static int receive_data(int f_in, char * #ifdef HAVE_FTRUNCATE if (inplace && fd != -1 - && ftruncate(fd, offset) < 0) { + && offset < size_r && ftruncate(fd, offset) < 0) { rsyserr(FERROR_XFER, errno, "ftruncate failed on %s", full_fname(fname)); } @@ -668,11 +669,25 @@ int recv_files(int f_in, char *local_nam continue; } - if (fd1 != -1 && !S_ISREG(st.st_mode)) { + if (fd1 != -1 && !(S_ISREG(st.st_mode) || (copy_devices && IS_DEVICE(st....

...if (force_change && make_mutable(file->dirname, sx.st.st_mode, sx.st.st_flags, force_change) > 0) { + fd = do_mkstemp(fnametmp, file->mode & INITACCESSPERMS); + undo_make_mutable(file->dirname, sx.st.st_flags); + } + } + } +#endif + if (fd == -1) { rsyserr(FERROR_XFER, errno, "mkstemp %s failed", full_fname(fnametmp)); -------------- next part -------------- HTML attachment scrubbed and removed

...+ rsync-3.0.5/receiver.c 2009-03-10 22:18:20.000000000 -0500 @@ -297,6 +315,16 @@ if (fd != -1 && offset > 0 && sparse_end(fd) != 0) { report_write_error: + fprintf(stderr, "rsync: write failed on %s: %s\n", full_fname(fname), strerror(errno)); rsyserr(FERROR_XFER, errno, "write failed on %s", full_fname(fname)); exit_cleanup(RERR_FILEIO);

Hi All Some time rsync just return error code 23 that some files are not transferred. Is there a way to get a list of these files so we can retry it later time? For example, we scan the whole file system and N files are not transferred. Instead of scan the whole file system later again, we can use files-from which is much faster. Thanks. -- Ming Zhang @#$%^ purging memory... (*!%

...nerator.c.old 2008-05-31 00:35:33.000000000 -0400 +++ generator.c 2008-05-31 00:35:55.000000000 -0400 @@ -1292,7 +1292,7 @@ if (F_IS_HLINKED(file)) handle_skipped_hlink(file, itemizing, code, f_out); #endif - rprintf(FERROR_XFER, + rprintf(FINFO, "skipping daemon-excluded %s \"%s\"\n", is_dir ? "directory" : "file", fname); if (is_dir) -- Configure bugmail: https://bugzill...

...extern int cleanup_got_literal; @@ -285,7 +286,7 @@ goto report_write_error; #ifdef HAVE_FTRUNCATE - if (inplace && fd != -1 + if (inplace && !copy_devices && fd != -1 && ftruncate(fd, offset) < 0) { rsyserr(FERROR_XFER, errno, "ftruncate failed on %s", full_fname(fname)); Only in rsync-HEAD-20081115-2333GMT/: rsync.1 Only in rsync-HEAD-20081115-2333GMT/: rsyncd.conf.5 diff -u -r rsync-HEAD-20081115-2333GMT/syscall.c rsync-HEAD-20081115-2333GMT-d2d/syscall.c --- rsync-HEAD-200811...

...uot;don't change this field", rsync silently fails to preserve the source ownership. This problem came up on the rsnapshot list: https://sourceforge.net/mailarchive/forum.php?thread_name=1259202707.2009.382.camel%40mattlaptop2.local&forum_name=rsnapshot-discuss Rsync should issue an FERROR_XFER in this case. I was inclined to have the receiving side do it because the limitation is in the receiving side's chown call, but it also looks like -1 has a special meaning to the uid-mapping code, so maybe the sender needs to catch the value before it causes trouble there. -- Configure bugm...

...git a/sender.c b/sender.c index 59dae7d..a934bfe 100644 --- a/sender.c +++ b/sender.c @@ -338,6 +338,12 @@ void send_files(int f_in, int f_out) if (do_progress) end_progress(st.st_size); + if (do_fadvise(fd, 0, 0, POSIX_FADV_DONTNEED) != 0) { + rsyserr(FERROR_XFER, errno, + "fadvise failed in sending %s", + full_fname(fname)); + } + log_item(log_code, file, &initial_stats, iflags, NULL); if (mbuf) { -- 1.7.1

.../receiver.c +++ b/receiver.c @@ -721,6 +721,12 @@ int recv_files(int f_in, char *local_name) recv_ok = receive_data(f_in, fnamecmp, fd1, st.st_size, fname, fd2, F_LENGTH(file)); + if (do_fadvise(fd2, 0, 0, POSIX_FADV_DONTNEED) != 0) { + rsyserr(FERROR_XFER, errno, + "fadvise failed in writing %s", + full_fname(fname)); + } + log_item(log_code, file, &initial_stats, iflags, NULL); if (fd1 != -1) -- 1.7.1