search for: feliu

? 2023/5/9 09:43, Xuan Zhuo ??: > On Mon, 8 May 2023 11:00:10 -0400, Feng Liu <feliu at nvidia.com> wrote: >> >> On 2023-05-07 p.m.9:45, Xuan Zhuo wrote: >>> External email: Use caution opening links or attachments >>> >>> >>> On Sat, 6 May 2023 08:08:02 -0400, Feng Liu <feliu at nvidia.com> wrote: >>>> >>&g...

On Tue, Mar 7, 2023 at 11:57?AM Feng Liu <feliu at nvidia.com> wrote: > > Add const to make the read-only pointer parameters clear, similar to > many existing functions. > > Signed-off-by: Feng Liu <feliu at nvidia.com> > Reviewed-by: Jiri Pirko <jiri at nvidia.com> > Reviewed-by: Parav Pandit <parav at nvi...

On Mon, 8 May 2023 11:00:10 -0400, Feng Liu <feliu at nvidia.com> wrote: > > > On 2023-05-07 p.m.9:45, Xuan Zhuo wrote: > > External email: Use caution opening links or attachments > > > > > > On Sat, 6 May 2023 08:08:02 -0400, Feng Liu <feliu at nvidia.com> wrote: > >> > >> > >>...

...hich has been done in vring_alloc_queue_split of the virtio_ring layer. To validate this change, we tested various virtqueue sizes for packed rings, including 128, 256, 512, 100, 200, 500, and 1000, with CONFIG_PAGE_POISONING enabled, and all tests passed successfully. Signed-off-by: Feng Liu <feliu at nvidia.com> Reviewed-by: Jiri Pirko <jiri at nvidia.com> --- v0 -> v1 feedbacks from Jason Wang and Michael S. Tsirkin - remove power_of_2 check of virtqueue size v1 -> v2 feedbacks from Parav Pandit and Jiri Pirko - keep power_of_2 check of split virtqueue in vring_alloc_queue_...

On Tue, Mar 7, 2023 at 11:57?AM Feng Liu <feliu at nvidia.com> wrote: > > is_power_of_2() already performs the zero check. Hence avoid duplicate > check. While at it, move the query of size check also adjacent to where > its used for the disabled vq. > > Signed-off-by: Feng Liu <feliu at nvidia.com> > Reviewed-by: J...

is_power_of_2() already performs the zero check. Hence avoid duplicate check. While at it, move the query of size check also adjacent to where its used for the disabled vq. Signed-off-by: Feng Liu <feliu at nvidia.com> Reviewed-by: Jiri Pirko <jiri at nvidia.com> Reviewed-by: Parav Pandit <parav at nvidia.com> Reviewed-by: Gavin Li <gavinl at nvidia.com> Reviewed-by: Bodong Wang <bodong at nvidia.com> --- drivers/virtio/virtio_pci_modern.c | 4 ++-- 1 file changed, 2 ins...

...ization to avoid leaks in error unwinding of init code. Also extract a helper function of disable queue pairs, and use newly introduced helper function in error unwinding and virtnet_close; Issue: 3383038 Fixes: 754b8a21a96d ("virtio_net: setup xdp_rxq_info") Signed-off-by: Feng Liu <feliu at nvidia.com> Reviewed-by: William Tu <witu at nvidia.com> Reviewed-by: Parav Pandit <parav at nvidia.com> Reviewed-by: Simon Horman <simon.horman at corigine.com> Acked-by: Michael S. Tsirkin <mst at redhat.com> Change-Id: Ib4c6a97cb7b837cfa484c593dd43a435c47ea68f ---...

On Thu, Mar 16, 2023 at 2:55?AM Feng Liu <feliu at nvidia.com> wrote: > > According to the Virtio Specification, the Queue Size parameter of a > virtqueue corresponds to the maximum number of descriptors in that > queue, and it does not have to be a power of 2 for packed virtqueues. > However, the virtio_pci_modern driver enfor...

On 2023-05-05 p.m.10:33, Xuan Zhuo wrote: > External email: Use caution opening links or attachments > > > On Tue, 2 May 2023 20:35:25 -0400, Feng Liu <feliu at nvidia.com> wrote: >> When initializing XDP in virtnet_open(), some rq xdp initialization >> may hit an error causing net device open failed. However, previous >> rqs have already initialized XDP and enabled NAPI, which is not the >> expected behavior. Need to roll bac...

On Tue, 2 May 2023 20:35:25 -0400, Feng Liu <feliu at nvidia.com> wrote: > When initializing XDP in virtnet_open(), some rq xdp initialization > may hit an error causing net device open failed. However, previous > rqs have already initialized XDP and enabled NAPI, which is not the > expected behavior. Need to roll back the previous r...

...f init code. Also extract helper functions of disable and enable queue pairs. Use newly introduced disable helper function in error unwinding and virtnet_close. Use enable helper function in virtnet_open. Fixes: 754b8a21a96d ("virtio_net: setup xdp_rxq_info") Signed-off-by: Feng Liu <feliu at nvidia.com> Reviewed-by: Jiri Pirko <jiri at nvidia.com> Reviewed-by: William Tu <witu at nvidia.com> --- v5 -> v6 feedbacks from Xuan Zhuo - add disable_delayed_refill and cancel_delayed_work_sync v4 -> v5 feedbacks from Michael S. Tsirkin - rename helper as virtnet_disabl...

On 2023-08-17 p.m.2:26, Willem de Bruijn wrote: > External email: Use caution opening links or attachments > > > On Thu, Aug 17, 2023 at 11:20?AM Feng Liu <feliu at nvidia.com> wrote: >> >> The virtio_net driver currently deals with different versions and types >> of virtio net headers, such as virtio_net_hdr_mrg_rxbuf, >> virtio_net_hdr_v1_hash, etc. Due to these variations, the code relies >> on multiple type casts to conv...

On Thu, Aug 17, 2023 at 5:52?PM Feng Liu <feliu at nvidia.com> wrote: > > > > On 2023-08-17 p.m.2:26, Willem de Bruijn wrote: > > External email: Use caution opening links or attachments > > > > > > On Thu, Aug 17, 2023 at 11:20?AM Feng Liu <feliu at nvidia.com> wrote: > >> > >> The...

...nside kernel file instead of the UAPI header. v2->v3 feedback from Willem de Bruijn <willemdebruijn.kernel at gmail.com> 1. fix typo in commit message. 2. add original struct virtio_net_hdr into union 3. remove virtio_net_hdr_mrg_rxbuf variable in receive_buf; Signed-off-by: Feng Liu <feliu at nvidia.com> Reviewed-by: Jiri Pirko <jiri at nvidia.com> --- drivers/net/virtio_net.c | 27 ++++++++++++++++++--------- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 8e9f4cfe941f..8c74bc8cfe68 100644 --- a/drive...

Add const to make the read-only pointer parameters clear, similar to many existing functions. Use `container_of_const` to implement `to_vvq`, which ensures the const-ness of read-only parameters and avoids accidental modification of their members. Signed-off-by: Feng Liu <feliu at nvidia.com> Reviewed-by: Jiri Pirko <jiri at nvidia.com> --- v0 -> v1 feedbacks from Michael S. Tsirkin - use `container_of_const` to implement `to_vvq` --- drivers/virtio/virtio_ring.c | 36 ++++++++++++++++++------------------ include/linux/virtio.h | 14 +++++++------- 2 f...

...ueues to have arbitrary sizes as specified by the Virtio Specification. To validate this change, we tested various virtqueue sizes for packed rings, including 128, 256, 512, 100, 200, 500, and 1000, with CONFIG_PAGE_POISONING enabled, and all tests passed successfully. Signed-off-by: Feng Liu <feliu at nvidia.com> Reviewed-by: Jiri Pirko <jiri at nvidia.com> Reviewed-by: Parav Pandit <parav at nvidia.com> Reviewed-by: Gavin Li <gavinl at nvidia.com> Reviewed-by: Bodong Wang <bodong at nvidia.com> Reviewed-by: David Edmondson <david.edmondson at oracle.com> ---...

On 2023-03-10 a.m.8:36, Parav Pandit wrote: > > >> From: Feng Liu <feliu at nvidia.com> >> Sent: Friday, March 10, 2023 12:34 AM > >> >> - if (!is_power_of_2(num)) { >> - dev_warn(&vp_dev->pci_dev->dev, "bad queue size %u", >> num); >> - return ERR_PTR(-EINVAL); >> - } >> - > > The check...

...wrote: > External email: Use caution opening links or attachments > > > On Fri, Apr 28, 2023 at 06:43:46PM -0400, Feng Liu wrote: >> Use newly introduced helper function that exactly does the same of >> closing the queue pairs. >> >> Signed-off-by: Feng Liu <feliu at nvidia.com> >> Reviewed-by: William Tu <witu at nvidia.com> >> Reviewed-by: Parav Pandit <parav at nvidia.com> > > I guess this was put in a separate patch to 1/2, as it's more > net-next material, as opposed to 1/2 which seems to be net material. > FW...

Use newly introduced helper function that exactly does the same of closing the queue pairs. Signed-off-by: Feng Liu <feliu at nvidia.com> Reviewed-by: William Tu <witu at nvidia.com> Reviewed-by: Parav Pandit <parav at nvidia.com> --- drivers/net/virtio_net.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index fc6ee833a09f....

...opening links or attachments > > > > > > On Fri, Apr 28, 2023 at 06:43:46PM -0400, Feng Liu wrote: > > > Use newly introduced helper function that exactly does the same of > > > closing the queue pairs. > > > > > > Signed-off-by: Feng Liu <feliu at nvidia.com> > > > Reviewed-by: William Tu <witu at nvidia.com> > > > Reviewed-by: Parav Pandit <parav at nvidia.com> > > > > I guess this was put in a separate patch to 1/2, as it's more > > net-next material, as opposed to 1/2 which seems...