search for: fedor

...and is mmapped into memory continuously, while piping require regular (more than once per module) context switches between the two processes? Honestly, I would say something is wrong (aka. first paragraph). I didn't build that with efficiency in mind in any way... On Thu, Mar 15, 2018, 07:47 Fedor Sergeev via llvm-dev < llvm-dev at lists.llvm.org> wrote: > Hmm... > > I tried Alexandre's fix from D44244 and surprisingly it appears that > just using -print-module-scope w/o > any additional git actions is waaaay slower on my testcase than > -git-commit-module-all. &...

On 03/15/2018 01:32 PM, Fedor Sergeev via llvm-dev wrote: > For this to be really usable in this setup we need additionally to: >   - extend -print-module-scope to cover basic block passes >   - introduce a clear way to separate module IRs as those are being > printed by -print-after-all > > But yes, it shoul...

Hello Fedor. Thank you for the information. I made a simple patch that exposes PassInstrumentationCallback so llvmGetPassPluginInfo can use it: https://reviews.llvm.org/D71086 . Would this change make sense? Thanks, Juneyoung Lee On Thu, Dec 12, 2019 at 12:44 AM Fedor Sergeev <fedor.sergeev at azul.com&g...

...; Honestly, I would say something is wrong (aka. first paragraph). I > didn't build that with efficiency in mind in any way... Well, git by itself is so focused on performance, so its not surprising to me that even using git add/git commit does not cause performance penalties. regards,   Fedor. > > On Thu, Mar 15, 2018, 07:47 Fedor Sergeev via llvm-dev > <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>> wrote: > > Hmm... > > I tried Alexandre's fix from D44244 and surprisingly it appears that > just using -print-module-...

...pt -O3 some-ir.ll -disable-output -git-commit-after-all 2>/dev/null real    0m8.041s user    0m7.133s sys     0m0.936s ] time R/bin/opt -O3 some-ir.ll -disable-output -print-after-all 2>/dev/null real    0m13.575s user    0m6.179s sys     0m7.394s I cant really explain that... regards,   Fedor. On 03/15/2018 04:30 PM, Fedor Sergeev via llvm-dev wrote: > > > On 03/15/2018 01:32 PM, Fedor Sergeev via llvm-dev wrote: >> For this to be really usable in this setup we need additionally to: >>   - extend -print-module-scope to cover basic block passes >>   - introduc...

Is there a reason for why `-asan` and `-asan-module` can be mixed but Function passes and Module passes with the new PM can't be mixed? - Leo On Thu, Sep 27, 2018 at 3:21 AM Fedor Sergeev <fedor.sergeev at azul.com> wrote: > > On 09/27/2018 12:25 PM, Philip Pfaffe wrote: >> >> `opt < %s -passed='asan' -asan-module -S` > > asan-module is another ModulePass, not a commandline option. You can't mix that like this. > > I'm...

The print-module-after-all type of option exists in upstream: -print-module-scope - When printing IR for print-[before|after]{-all} always print a module IR commit 7d160f714357f6784ead669ce516e94991c12e5a Author: Fedor Sergeev <fedor.sergeev at azul.com<mailto:fedor.sergeev at azul.com>> Date: Fri Dec 1 17:42:46 2017 +0000 IR printing improvement for function passes - introducing -print-module-scope Summary: When debugging function passes it happens to be rather useful to dump th...

...d additionally to:   - extend -print-module-scope to cover basic block passes   - introduce a clear way to separate module IRs as those are being printed by -print-after-all But yes, it should work, and a wrapper that pipes to git fast-import seems to be the best way to handle it. regards,   Fedor. On 03/15/2018 12:31 AM, Daniel Neilson via llvm-dev wrote: > The print-module-after-all type of option exists in upstream: >   -print-module-scope                                     - When > printing IR for print-[before|after]{-all} always print a module IR > > commit 7d160f7143...

Frontends _are_ using PassBuilder, but they need to hook into the default pipeline creation to insert the sanitizer passes. On Tue, Sep 25, 2018 at 12:15 PM Fedor Sergeev <fedor.sergeev at azul.com> wrote: > Hmm... frontends should be using PassBuilder anyway. > And if they are using PassBuilder then they are using PassRegistry.def as > well - all the > PassBuilder::register*/parse*/is* methods do include PassRegistry.def in > their bod...

...ould work with codegen then we need to think about how codegen will work with the new PM. I agree that whether or not the new PM becomes default is somewhat orthogonal but eventually it will and at that point I hope we have a functioning opt-bisect for codegen. -David Fedor Sergeev <fedor.sergeev at azul.com> writes: > I would really like to separate OptBisect and New-PM-by-default > discussions! :) > > regards, >   Fedor. > > On 09/26/2018 09:13 PM, David Greene wrote: >> I'm concerned about codegen. If Codegen is not yet ready...

On 3/14/19 2:04 AM, Hiroshi Yamauchi wrote: > > > On Wed, Mar 13, 2019 at 2:37 PM Fedor Sergeev <fedor.sergeev at azul.com > <mailto:fedor.sergeev at azul.com>> wrote: > >> >> - Add a new proxy ModuleAnalysisManagerLoopProxy for a loop pass >> to be able to get to the ModuleAnalysisManager in one step and >> PSI through it. >...

...Just in case, there're few questions that I'm trying to find answers for: * Why replacing `removeFromParent()` with `eraseFromParent` breaks the code? * How to properly remove predecessors from the resulting Tail block? * How to remove the Tail block itself when we're done? Thank you, Fedor. -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20180224/5dfc1a71/attachment.html>

...eInstructionsInSplitBetween` change significantly in such case, and it starts to loop indefinitely. The `SplitEdge` function that it calls places all of the instructions into the split block, so that the original block becomes empty. Is it expected behavior, or am I doing something wrong? Thanks, Fedor. On Sat, Feb 24, 2018 at 2:16 AM, Fedor Indutny <fedor at indutny.com> wrote: > Hello! > > I've discovered that `CallSiteSplitting` optimization doesn't support > musttail calls. The easiest fix as it stands is disabling it for such call > sites: https://reviews.llvm....

Fedor, Yes that is what happens in my case that the loop is fully unrolled and hence ‘removed’. My objection though is that there is still IR that could be dumped (i.e. the function containing the loop that was removed or the entire module) and that is what I want to have dumped after each pass when I...

...to be > able to get to the ModuleAnalysisManager in one step and PSI through it. This is just an optimization of compile-time, saves one indirection through FunctionAnalysisManager. I'm not even sure if it is worth the effort. And definitely not crucial for the overall idea. regards,   Fedor. > > > > > On Mon, Mar 4, 2019 at 2:05 PM Fedor Sergeev <fedor.sergeev at azul.com > <mailto:fedor.sergeev at azul.com>> wrote: > > > > On 3/4/19 10:49 PM, Hiroshi Yamauchi wrote: >> >> >> On Mon, Mar 4, 2019 at 10:55 AM Hiroshi Y...

Hi Leonard, Fedor, while it's true that RegisterPass is not applicable for new-pm passes, PassRegistry.def is not the whole story. Passes in PassRegistry are available for the opt tool. The sanitizers are passes that usually get added to the pipeline by the frontend. There, you need to use PassBuilder's cal...

...and overall clean solution that allows to avoid making any of "user interface" decisions mentioned above. We need to understand why git-commit-after-all works faster than print-after-all. I dont believe in magic... yet :) And, btw, thanks for both the idea and the patch. regards,   Fedor. On 03/16/2018 12:03 AM, Alexandre Isoard wrote: > If this is faster than -print-after-all we may actually consider > pushing that in the code base then? (after diligent code review of > course) > > Note that it uses the same printing method as -print-after-all: > - create a pa...

...> -fexperimental-new-pass-manager -print-after-all ..." > > It's conceivable that something is different in our setup or in clang > (from opt)... I'll see if I can reproduce it outside our setup. Does it depend on machine architecture? I generally use x86... regards,   Fedor. > > Thanks. > > > On Tue, Aug 6, 2019 at 9:35 AM Fedor Sergeev <fedor.sergeev at azul.com > <mailto:fedor.sergeev at azul.com>> wrote: > > > > On 8/6/19 7:31 PM, Fedor Sergeev via llvm-dev wrote: >> >> >> On 8/6/19 3:02 AM, Hiros...

...^; ModuleID" 526 real    0m2.363s user    0m2.373s sys     0m0.271s ] So, the morale of this story is - we should not be printing module IR into dbgs/errs(). And then the idea of streaming IR module dumps into a buffered stream and then postprocessing seems to be a right one. regards,   Fedor. On 03/21/2018 01:08 PM, Fedor Sergeev via llvm-dev wrote: > On 03/16/2018 01:21 AM, Fedor Sergeev via llvm-dev wrote: > > git-commit-after-all solution has one serious issue - it has a > hardcoded git handling which > > makes it look problematic from many angles (picking a prop...

On 8/6/19 7:31 PM, Fedor Sergeev via llvm-dev wrote: > > > On 8/6/19 3:02 AM, Hiroshi Yamauchi via llvm-dev wrote: >> I had a chance to try -print-after-all with NPM. >> >> It seems like there's still no output for the passes >> before objc-arc-contract (which is basically what I saw b...