search for: features_ok

On Wed, Jan 07, 2015 at 05:13:32PM +0100, Cornelia Huck wrote: > On Tue, 30 Dec 2014 14:25:37 +0200 > "Michael S. Tsirkin" <mst at redhat.com> wrote: > > > On Thu, Dec 11, 2014 at 02:25:15PM +0100, Cornelia Huck wrote: > > > virtio-1 allow setting of the FEATURES_OK status bit to fail if > > > the negotiated feature bits are inconsistent: let's fail > > > virtio_set_status() in that case and update virtio-ccw to post an > > > error to the guest. > > > > > > Signed-off-by: Cornelia Huck <cornelia.huck at de.i...

On Wed, Jan 07, 2015 at 05:13:32PM +0100, Cornelia Huck wrote: > On Tue, 30 Dec 2014 14:25:37 +0200 > "Michael S. Tsirkin" <mst at redhat.com> wrote: > > > On Thu, Dec 11, 2014 at 02:25:15PM +0100, Cornelia Huck wrote: > > > virtio-1 allow setting of the FEATURES_OK status bit to fail if > > > the negotiated feature bits are inconsistent: let's fail > > > virtio_set_status() in that case and update virtio-ccw to post an > > > error to the guest. > > > > > > Signed-off-by: Cornelia Huck <cornelia.huck at de.i...

set FEATURES_OK as per virtio 1.0 spec Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/uapi/linux/virtio_config.h | 2 ++ drivers/virtio/virtio.c | 29 ++++++++++++++++++++++------- 2 files changed, 24 insertions(+), 7 deletions(-) diff --git a/include/uapi/linux/virtio_confi...

set FEATURES_OK as per virtio 1.0 spec Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/uapi/linux/virtio_config.h | 2 ++ drivers/virtio/virtio.c | 29 ++++++++++++++++++++++------- 2 files changed, 24 insertions(+), 7 deletions(-) diff --git a/include/uapi/linux/virtio_confi...

set FEATURES_OK as per virtio 1.0 spec Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/uapi/linux/virtio_config.h | 2 ++ drivers/virtio/virtio.c | 29 ++++++++++++++++++++++------- 2 files changed, 24 insertions(+), 7 deletions(-) diff --git a/include/uapi/linux/virtio_confi...

set FEATURES_OK as per virtio 1.0 spec Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/uapi/linux/virtio_config.h | 2 ++ drivers/virtio/virtio.c | 29 ++++++++++++++++++++++------- 2 files changed, 24 insertions(+), 7 deletions(-) diff --git a/include/uapi/linux/virtio_confi...

On Wed, 22 Oct 2014 21:44:44 +0300 "Michael S. Tsirkin" <mst at redhat.com> wrote: > set FEATURES_OK as per virtio 1.0 spec > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > --- > include/uapi/linux/virtio_config.h | 2 ++ > drivers/virtio/virtio.c | 29 ++++++++++++++++++++++------- > 2 files changed, 24 insertions(+), 7 deletions(-) > > d...

On Tue, Nov 25, 2014 at 06:48:11PM +0100, Cornelia Huck wrote: > On Tue, 25 Nov 2014 18:42:01 +0200 > "Michael S. Tsirkin" <mst at redhat.com> wrote: > > > set FEATURES_OK as per virtio 1.0 spec > > > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > > --- > > include/uapi/linux/virtio_config.h | 2 ++ > > drivers/virtio/virtio.c | 29 ++++++++++++++++++++++------- > > 2 files changed, 24 insertions(+),...

set FEATURES_OK as per virtio 1.0 spec Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/uapi/linux/virtio_config.h | 2 ++ drivers/virtio/virtio.c | 29 ++++++++++++++++++++++------- 2 files changed, 24 insertions(+), 7 deletions(-) diff --git a/include/uapi/linux/virtio_confi...

On Tue, Nov 25, 2014 at 06:48:11PM +0100, Cornelia Huck wrote: > On Tue, 25 Nov 2014 18:42:01 +0200 > "Michael S. Tsirkin" <mst at redhat.com> wrote: > > > set FEATURES_OK as per virtio 1.0 spec > > > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > > --- > > include/uapi/linux/virtio_config.h | 2 ++ > > drivers/virtio/virtio.c | 29 ++++++++++++++++++++++------- > > 2 files changed, 24 insertions(+),...

set FEATURES_OK as per virtio 1.0 spec Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/uapi/linux/virtio_config.h | 2 ++ drivers/virtio/virtio.c | 29 ++++++++++++++++++++++------- 2 files changed, 24 insertions(+), 7 deletions(-) diff --git a/include/uapi/linux/virtio_confi...

...unsigned int fbit) >> +{ >> + BUG_ON(fbit >= VIRTIO_TRANSPORT_F_START); >> + BUG_ON(vdev->config->get_status(vdev) & >> + ~(VIRTIO_CONFIG_S_ACKNOWLEDGE | VIRTIO_CONFIG_S_DRIVER)); > When we add virtio-1 support, we can add a check for FEATURES_OK here, > so we're really on the safe side. > If I read the spec correctly, FEATURES_OK was set only after writing the features bits to device. But we want to sanitize the them before. >> + >> + virtio_check_driver_offered_feature(vdev, fbit); >> + >> + clear_bit(fb...

...unsigned int fbit) >> +{ >> + BUG_ON(fbit >= VIRTIO_TRANSPORT_F_START); >> + BUG_ON(vdev->config->get_status(vdev) & >> + ~(VIRTIO_CONFIG_S_ACKNOWLEDGE | VIRTIO_CONFIG_S_DRIVER)); > When we add virtio-1 support, we can add a check for FEATURES_OK here, > so we're really on the safe side. > If I read the spec correctly, FEATURES_OK was set only after writing the features bits to device. But we want to sanitize the them before. >> + >> + virtio_check_driver_offered_feature(vdev, fbit); >> + >> + clear_bit(fb...

...14 15:51:39 +0300 "Michael S. Tsirkin" <mst at redhat.com> wrote: > On Thu, Oct 23, 2014 at 02:28:08PM +0200, Cornelia Huck wrote: > > On Wed, 22 Oct 2014 21:44:44 +0300 > > "Michael S. Tsirkin" <mst at redhat.com> wrote: > > > > > set FEATURES_OK as per virtio 1.0 spec > > > > > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > > > --- > > > include/uapi/linux/virtio_config.h | 2 ++ > > > drivers/virtio/virtio.c | 29 ++++++++++++++++++++++------- > > > 2 fil...

On Thu, 11 Dec 2014 14:25:14 +0100 Cornelia Huck <cornelia.huck at de.ibm.com> wrote: > For virtio-1 devices, the driver must not attempt to set feature bits > after it set FEATURES_OK in the device status. Simply reject it in > that case. > > Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com> > --- > hw/virtio/virtio.c | 16 ++++++++++++++-- > include/hw/virtio/virtio.h | 2 ++ > 2 files changed, 16 insertions(+), 2 deletions(-)...

On Thu, 11 Dec 2014 14:25:14 +0100 Cornelia Huck <cornelia.huck at de.ibm.com> wrote: > For virtio-1 devices, the driver must not attempt to set feature bits > after it set FEATURES_OK in the device status. Simply reject it in > that case. > > Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com> > --- > hw/virtio/virtio.c | 16 ++++++++++++++-- > include/hw/virtio/virtio.h | 2 ++ > 2 files changed, 16 insertions(+), 2 deletions(-)...

On Thu, Oct 23, 2014 at 02:28:08PM +0200, Cornelia Huck wrote: > On Wed, 22 Oct 2014 21:44:44 +0300 > "Michael S. Tsirkin" <mst at redhat.com> wrote: > > > set FEATURES_OK as per virtio 1.0 spec > > > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > > --- > > include/uapi/linux/virtio_config.h | 2 ++ > > drivers/virtio/virtio.c | 29 ++++++++++++++++++++++------- > > 2 files changed, 24 insertions(+),...

On Thu, Oct 23, 2014 at 02:28:08PM +0200, Cornelia Huck wrote: > On Wed, 22 Oct 2014 21:44:44 +0300 > "Michael S. Tsirkin" <mst at redhat.com> wrote: > > > set FEATURES_OK as per virtio 1.0 spec > > > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > > --- > > include/uapi/linux/virtio_config.h | 2 ++ > > drivers/virtio/virtio.c | 29 ++++++++++++++++++++++------- > > 2 files changed, 24 insertions(+),...

On Thu, Dec 11, 2014 at 02:25:15PM +0100, Cornelia Huck wrote: > virtio-1 allow setting of the FEATURES_OK status bit to fail if > the negotiated feature bits are inconsistent: let's fail > virtio_set_status() in that case and update virtio-ccw to post an > error to the guest. > > Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com> Right but a separate validate_features...

On Thu, Dec 11, 2014 at 02:25:15PM +0100, Cornelia Huck wrote: > virtio-1 allow setting of the FEATURES_OK status bit to fail if > the negotiated feature bits are inconsistent: let's fail > virtio_set_status() in that case and update virtio-ccw to post an > error to the guest. > > Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com> Right but a separate validate_features...