Displaying 5 results from an estimated 5 matches for "features_depending_on_foo".
2014 Nov 19
3
[PATCH V2 net] virtio-net: validate features during probe
This patch validates feature dependencies during probe and fail the probing
if a dependency is missed. This fixes the issues of hitting BUG()
when qemu fails to advertise features correctly. One example is booting
guest with ctrl_vq=off through qemu.
Cc: Rusty Russell <rusty at rustcorp.com.au>
Cc: Michael S. Tsirkin <mst at redhat.com>
Cc: Cornelia Huck <cornelia.huck at
2014 Nov 19
3
[PATCH V2 net] virtio-net: validate features during probe
This patch validates feature dependencies during probe and fail the probing
if a dependency is missed. This fixes the issues of hitting BUG()
when qemu fails to advertise features correctly. One example is booting
guest with ctrl_vq=off through qemu.
Cc: Rusty Russell <rusty at rustcorp.com.au>
Cc: Michael S. Tsirkin <mst at redhat.com>
Cc: Cornelia Huck <cornelia.huck at
2014 Nov 19
0
[PATCH V2 net] virtio-net: validate features during probe
..._F_HOST_TSO6,
> + VIRTIO_NET_F_HOST_ECN,
> + };
I'm wondering whether it would be easier to read if you listed all
prereqs per feature instead of all features that depend on a feature?
It would still be hard to express the v4/v6 or conditions below in
tables, though.
Or call the arrays features_depending_on_foo?
> + int err;
> +
> + err = virtnet_validate_features(dev, features_for_ctrl_vq,
> + ARRAY_SIZE(features_for_ctrl_vq),
> + VIRTIO_NET_F_CTRL_VQ);
> + if (err)
> + return err;
If you already print a message that a user may use to fix their
hypervisor (or bug someone a...
2014 Nov 19
1
[PATCH V2 net] virtio-net: validate features during probe
...d int feature_for_host_tso6[] = {
VIRTIO_NET_F_HOST_ECN,
};
unsigned int feature_for_host_tso4[] = {
VIRTIO_NET_F_HOST_ECN,
}
To avoid the following open-coding for ECN. And probably we need another
device specific dependency table and let virtio core do this instead.
>
> Or call the arrays features_depending_on_foo?
Yes.
>
>> + int err;
>> +
>> + err = virtnet_validate_features(dev, features_for_ctrl_vq,
>> + ARRAY_SIZE(features_for_ctrl_vq),
>> + VIRTIO_NET_F_CTRL_VQ);
>> + if (err)
>> + return err;
> If you already print a message that a user may use...
2014 Nov 19
1
[PATCH V2 net] virtio-net: validate features during probe
...d int feature_for_host_tso6[] = {
VIRTIO_NET_F_HOST_ECN,
};
unsigned int feature_for_host_tso4[] = {
VIRTIO_NET_F_HOST_ECN,
}
To avoid the following open-coding for ECN. And probably we need another
device specific dependency table and let virtio core do this instead.
>
> Or call the arrays features_depending_on_foo?
Yes.
>
>> + int err;
>> +
>> + err = virtnet_validate_features(dev, features_for_ctrl_vq,
>> + ARRAY_SIZE(features_for_ctrl_vq),
>> + VIRTIO_NET_F_CTRL_VQ);
>> + if (err)
>> + return err;
> If you already print a message that a user may use...