search for: fdrlogging_init

...ted this on our bots: First failure, unrelated commit: http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-full/builds/3190 'XRay-Unit :: unit/XRayFDRLoggingTest/FDRLoggingTest.Simple' FAILED llvm/projects/compiler-rt/lib/xray/tests/unit/fdr_logging_test.cc:55: Failure Expected: FDRLogging_init(kBufferSize, kBufferMax, &Options, sizeof(FDRLoggingOptions)) Which is: 0 To be equal to: XRayLogInitStatus::XRAY_LOG_INITIALIZED Which is: 2 [ FAILED ] FDRLoggingTest.Simple (0 ms) ... 1 FAILED TEST ==11476==XRay instrumentation map missing. Not initializing XRay. Then a simila...

...ooked into the code and wanted to share some thoughts. > > This might be a compare_exchange_weak spurious failure. ARM is a weakly > ordered CPU, but I am not sure whether spurious failures are really > possible in a single threaded app. On the other hand, there is no other way > for FDRLogging_init to fail in such a way (return XRAY_LOG_UNINITIALIZED > instead of XRAY_LOG_INITIALIZED) without any extra output. This is also > true for the 2nd test failure in FDRLogging_finalize, which uses a weak > exchange too. > > Probably, the weak exchange needs to be either replaced with a...

...ked into the code and wanted to share some thoughts. >>> >>> This might be a compare_exchange_weak spurious failure. ARM is a weakly ordered CPU, but I am not sure whether spurious failures are really possible in a single threaded app. On the other hand, there is no other way for FDRLogging_init to fail in such a way (return XRAY_LOG_UNINITIALIZED instead of XRAY_LOG_INITIALIZED) without any extra output. This is also true for the 2nd test failure in FDRLogging_finalize, which uses a weak exchange too. >>> >>> Probably, the weak exchange needs to be either replaced with...