search for: fdrlogging_finalize

...alizing XRay. Then a similar, but not identical error: http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-full/builds/3191 'XRay-Unit :: unit/XRayFDRLoggingTest/FDRLoggingTest.Simple' FAILED llvm/projects/compiler-rt/lib/xray/tests/unit/fdr_logging_test.cc:58: Failure Expected: FDRLogging_finalize() Which is: 2 To be equal to: XRayLogInitStatus::XRAY_LOG_FINALIZED Which is: 4 [ FAILED ] FDRLoggingTest.Simple (0 ms) ... 1 FAILED TEST ==11476==XRay instrumentation map missing. Not initializing XRay. Note 0->2 on the first, 2->4 on the second. And then, for no reason, it&...

...rious failures are really > possible in a single threaded app. On the other hand, there is no other way > for FDRLogging_init to fail in such a way (return XRAY_LOG_UNINITIALIZED > instead of XRAY_LOG_INITIALIZED) without any extra output. This is also > true for the 2nd test failure in FDRLogging_finalize, which uses a weak > exchange too. > > Probably, the weak exchange needs to be either replaced with a strong one > or looped with more detailed CurrentStatus checks. > > Oleg > > On Wed, Jan 25, 2017 at 2:02 PM, Renato Golin via llvm-dev < > llvm-dev at lists.llvm.org&...

...not sure whether spurious failures are really possible in a single threaded app. On the other hand, there is no other way for FDRLogging_init to fail in such a way (return XRAY_LOG_UNINITIALIZED instead of XRAY_LOG_INITIALIZED) without any extra output. This is also true for the 2nd test failure in FDRLogging_finalize, which uses a weak exchange too. >>> >>> Probably, the weak exchange needs to be either replaced with a strong one or looped with more detailed CurrentStatus checks. >>> >>> Oleg >>> >>> On Wed, Jan 25, 2017 at 2:02 PM, Renato Golin via llvm-...