search for: fd_out

...lter(main+0x6a9) [0x403b49] -> /usr/lib/libc.so.6(__libc_start_ma in+0xf5) [0x7f020e327bc5] -> /usr/bin/sieve-filter() [0x404111] The reason is file descriptor leak in "script client local". script_client_local_close_output() shutdowns write side of descriptor and sets sclient->fd_out to -1, but never closes the descriptor. I've tried to fix this by the patch below. Tests works fine, but sieve-filter crashed in other way: sieve-filter(kas): Panic: epoll_ctl(del, 13) failed: Bad file descriptor sieve-filter(kas): Error: Raw backtrace: /usr/lib/dovecot/libdovecot.so.0(+0x66a...

Folks, I've noticed poor performance using sftp. If anyone has any advice on how to improve performance, I'd like to hear it. Test simply involved transferring a single 143MB MP3 file using defaults for all the program configs. The opensshd 3.0.2p1 server is used in all tests. Software: openssh suite 3.0.2p1 psftp (putty sftp client) latest dev snapshot pscp (putty scp client) latest

...t;id); + buffer_put_string(m, handle, handle_len); + buffer_put_int64(m, rq->offset); + buffer_put_int(m, rq->len); + send_msg(fd, m); + debug3("Sent message SSH2_FXP_READ I:%d O:%llu S:%u", + rq->id, rq->offset, rq->len); +} + int do_init(int fd_in, int fd_out) { @@ -674,12 +721,15 @@ int pflag) { int local_fd; - u_int expected_id, handle_len, mode, type, id; + u_int handle_len, mode, type, id; u_int64_t offset; char *handle; Buffer msg; Attrib junk, *a; int status; + struct request req[REQUEST_QUEUE_SIZE]; + int num_req = 0, max_req =...

While looking for leaks I came across two old packet APIs which are easy to remove. I'm sending patches for each separately. First, there is the packet_set_connection(int fd_in, int fd_out) function in opacket.c The function relies on a behavior in ssh_packet_set_connection() where, when it is passed a NULL pointer, it will implicitely allocate a struct ssh and return it after then set the fds in it. sshd.c appears to be the only place where the API is still used, so we can plac...

..., rip=141.42.206.36, lip=141.42.206.11, mpid=27254, TLS, session=<TGwoO1o3id+NKs4k> Jul 11 13:12:44 mproxy dovecot: imap(hildeb)<TGwoO1o3id+NKs4k>: Panic: file imap-client.c: line 854 (client_check_command_hangs): assertion failed: ((io_loop_find_fd_conditions(current_ioloop, client->fd_out) & IO_WRITE) != 0) Jul 11 13:12:44 mproxy dovecot: imap(hildeb)<TGwoO1o3id+NKs4k>: Error: Raw backtrace: /usr/lib/dovecot/libdovecot.so.0(+0x8e09e) [0x7efd1d3a309e] -> /usr/lib/dovecot/libdovecot.so.0(+0x8e18c) [0x7efd1d3a318c] -> /usr/lib/dovecot/libdovecot.so.0(i_fatal+0) [0x7efd1...

...tp-client.c Wed Feb 6 13:02:34 2002 @@ -49,6 +49,11 @@ /* Message ID */ static u_int msg_id = 1; +/* Progress Meter items */ +off_t statbytes = 0; +off_t totalbytes = 0; +char *curfile = NULL; + static void send_msg(int fd, Buffer *m) { @@ -671,7 +676,7 @@ int do_download(int fd_in, int fd_out, char *remote_path, char *local_path, - int pflag) + int pflag, void (*progressbar)(int)) { int local_fd; u_int expected_id, handle_len, mode, type, id; @@ -724,6 +729,11 @@ return(-1); } + totalbytes = a->size; + curfile = remote_path; + if (progressbar) + (progressbar)(0);...

...2.11. diff -crB dovecot-1.2.11.orig/src/imap/client.c dovecot-1.2.11/src/imap/client.c *** dovecot-1.2.11.orig/src/imap/client.c 2010-01-24 16:14:17.000000000 -0700 --- dovecot-1.2.11/src/imap/client.c 2010-05-20 09:30:47.170407921 -0600 *************** *** 42,47 **** --- 42,48 ---- client->fd_out = fd_out; client->input = i_stream_create_fd(fd_in, imap_max_line_length, FALSE); client->output = o_stream_create_fd(fd_out, (size_t)-1, FALSE); + client->expunged = 0; o_stream_set_flush_callback(client->output, client_output, client); *************** *** 105,110 **** ---...

I am looking through the logging options and wondering if there are a couple of things that we can do 1. Logouts don't seem to show the IP address of the logout, we typically see multiple sessions at a time and wondering if there is a way to tie the logouts to an IP 2. POP logouts show the number of messages retrieved/deleted but I don't see a way to do this with IMAP, is there a logout

--- ../openssh/sftp-client.c Fri Feb 9 08:44:24 2001 +++ sftp-client.c Fri Feb 9 19:14:01 2001 @@ -331,7 +331,7 @@ error("Couldn't read directory: %s", fx2txt(status)); do_close(fd_in, fd_out, handle, handle_len); - return(NULL); + return(0); } } else if (type != SSH2_FXP_NAME) fatal("Expected SSH2_FXP_NAME(%d) packet, got %d",

...uot;, I_RM, REMOTE }, + { "rmdir", I_RMDIR, REMOTE }, + { "symlink", I_SYMLINK, REMOTE }, + { "version", I_VERSION, NOARGS }, + { "!", I_SHELL, NOARGS }, + { "?", I_HELP, NOARGS }, + { NULL, -1, -1} }; int interactive_loop(int fd_in, int fd_out, char *file1, char *file2); @@ -1231,13 +1241,194 @@ return ("sftp> "); } +/* + * Before Asking to be included: + * XXX Support Quoting in file completion + * XXX Fix MAXARG to be more dynamic + * XXX Better column display of multi-matches + * XXX Kill the need for MAXLIST limit...

...uot;, I_RM, REMOTE }, + { "rmdir", I_RMDIR, REMOTE }, + { "symlink", I_SYMLINK, REMOTE }, + { "version", I_VERSION, NOARGS }, + { "!", I_SHELL, NOARGS }, + { "?", I_HELP, NOARGS }, + { NULL, -1, -1} }; int interactive_loop(int fd_in, int fd_out, char *file1, char *file2); @@ -1344,13 +1357,237 @@ return ("sftp> "); } +void +complete_display(char **list, u_int len) +{ + u_int y, m = 0, width = 80, columns = 1, colspace = 0; + struct winsize ws; + + /* Count entries for sort and find longest filename */ + for (y = 0; list...

...++ sftp-client.c 2002/02/02 21:47:41 @@ -49,6 +49,11 @@ /* Message ID */ static u_int msg_id = 1; +/* Progress Meter items */ +off_t statbytes = 0; +off_t totalbytes = 0; +char *curfile = NULL; + static void send_msg(int fd, Buffer *m) { @@ -670,7 +675,7 @@ int do_download(int fd_in, int fd_out, char *remote_path, char *local_path, - int pflag) + int pflag, void (*progressbar)(int)) { int local_fd; u_int expected_id, handle_len, mode, type, id; @@ -723,6 +728,11 @@ return(-1); } + totalbytes = a->size; + curfile = remote_path; + if (progressbar) + (progressbar)(0);...

...args Cannot access memory at address 0xffffffec (gdb) print &args $3 = (va_list *) 0xffffffec (gdb) up #7 0x000217c8 in client_disconnect (client=0x82098, reason=0x0) at client.c:119 119 i_info("Disconnected: %s", reason); (gdb) print *client $4 = {fd_in = 1147761507, fd_out = 1869508197, io = 0x63746564, input = 0x3a202573, output = 0x0, namespaces = 0x0, mailbox = 0x2a204259, keywords = {pool = 0x45200000, keywords = {buffer = 0x42414420, element_size = 1165128303}}, select_counter = 1914726766, messages_count = 541674817, recent_count = 1344304225, las...

...5efa in mail_storage_service_lookup_next (ctx=0x633460, input=0x7fffffffe810, user_r=0x7fffffffe7c0, mail_user_r=0x7fffffffe7b8, error_r=0x7fffffffe808) at mail-storage-service.c:1149 #11 0x000000000041f61c in client_create_from_input (input=0x7fffffffe810, login_client=0x7fffffffe880, fd_in=0, fd_out=1, input_buf=0x0, error_r=0x7fffffffe808) at main.c:202 #12 0x000000000041f859 in main_stdio_run (username=0x0) at main.c:247 #13 0x000000000041fd0a in main (argc=1, argv=0x631370) at main.c:381 /usr/local/dovecot/bin/doveconf -n # 2.1.9: /usr/local/dovecot/etc/dovecot/dovecot.conf # OS: Linux...

...-client.c 2009-02-10 15:15:08.000000000 +0100 @@ -63,6 +63,7 @@ struct sftp_conn { #define SFTP_EXT_POSIX_RENAME 0x00000001 #define SFTP_EXT_STATVFS 0x00000002 #define SFTP_EXT_FSTATVFS 0x00000004 +#define SFTP_EXT_LINK 0x00000008 u_int exts; }; @@ -328,10 +329,14 @@ do_init(int fd_in, int fd_out, u_int tra strcmp(value, "2") == 0) { exts |= SFTP_EXT_STATVFS; known = 1; - } if (strcmp(name, "fstatvfs at openssh.com") == 0 && + } else if (strcmp(name, "fstatvfs at openssh.com") == 0 && strcmp(value, "2") == 0) {...

...ailures.c:218 218 info_handler(format, args); (gdb) print *format $3 = 68 'D' (gdb) up #7 0x000218c8 in client_disconnect (client=0x84288, reason=0x0) at client.c:119 119 i_info("Disconnected: %s", reason); (gdb) print *client $4 = {fd_in = 1147761507, fd_out = 1869508197, io = 0x63746564, input = 0x3a202573, output = 0x0, namespaces = 0x0, mailbox = 0x2a204259, keywords = {pool = 0x45200000, keywords = {buffer = 0x42414420, element_size = 1165128303}}, select_counter = 1914726766, messages_count = 541674817, recent_count = 1344304225, las...

Dear OpenSSH Portable sshd developers, I'm having a problem where sshd login sessions are occasionally (as often as once a day) getting stuck indefinitely. I enabled debug messages and got a backtrace of a stuck sshd, and I think I've found the bug. I wanted to run it by the list once before filing. sshd version: OpenSSH_4.2p1 FreeBSD-20050903, OpenSSL 0.9.7e-p1 25 Oct 2004

...return(filename); } +void +updateprogressmeter(int ignore) +{ + int save_errno = errno; + + progressmeter(0, offset, file_size, filename); + signal(SIGALRM, updateprogressmeter); + alarm(PROGRESSTIME); + errno = save_errno; +} + int do_download(int fd_in, int fd_out, char *remote_path, char *local_path, int pflag) { int local_fd; u_int expected_id, handle_len, mode, type, id; - u_int64_t offset; char *handle; Buffer msg; Attrib junk, *a; @@ -723,6 +739,12 @@ return(-1); } + file_size = a->size; + filename = remote_path; + progressmete...

...8 user = 0x126d7f0 ns = 0x12673f0 ns_set = 0x126f2e0 mail_set = <optimized out> error = 0x0 #6 0x0000000000405762 in client_raw_user_create (client=<optimized out>) at client.c:150 sets = <optimized out> #7 client_create (fd_in=12, fd_out=12, conn=<optimized out>) at client.c:242 client = 0x1267f10 pool = 0x1267ef0 #8 0x00007f305d3a8740 in master_service_listen (l=0x1266120) at master-service.c:826 service = 0x12625a0 conn = {fd = 12, listen_fd = 8, name = 0x1262905 "dovecot-lmtp", re...

...in mail_storage_service_lookup_next (ctx=0xdba26e4b0, input=<optimized out>, user_r=0x3f7bad9c3c8, mail_user_r=0x3f7bad9c3d0, error_r=0x3f7bad9c430) at mail-storage-service.c:1193 #23 0x0000000db6f824e9 in client_create_from_input (input=0x3f7bad9c440, login_client=0xdba270660, fd_in=12, fd_out=12, input_buf=0x3f7bad9c4b0, error_r=<optimized out>) at main.c:204 #24 0x0000000db6f827f7 in login_client_connected (client=0xdba270660, username=<optimized out>, extra_fields=<optimized out>) at main.c:277 #25 0x00000386566a97e6 in master_login_auth_finish (client=0xdba27066...