search for: fbinfo_state_suspend

...console_unlock(); > > Cheers, > Emil Hi! That was my first try! I guessed the same but I got exactly one trap message on resume. So it's about first put the bucket and then open the water tap. ;) chris ps: just found these macros for the state in fb.h: FBINFO_STATE_RUNNING = 0 FBINFO_STATE_SUSPENDED = 1

...ouveau_drm.c +++ b/drivers/gpu/drm/nouveau/nouveau_drm.c @@ -552,7 +552,7 @@ nouveau_do_suspend(struct drm_device *dev, bool runtime) if (dev->mode_config.num_crtc) { NV_INFO(drm, "suspending console...\n"); - nouveau_fbcon_set_suspend(dev, 1); + nouveau_fbcon_set_suspend(dev, FBINFO_STATE_SUSPENDED, true); NV_INFO(drm, "suspending display...\n"); ret = nouveau_display_suspend(dev, runtime); if (ret) @@ -635,7 +635,7 @@ nouveau_do_resume(struct drm_device *dev, bool runtime) NV_INFO(drm, "resuming display...\n"); nouveau_display_resume(dev, runtime); NV_...

...h the information in there [1] Cheers, Emil [1] http://nouveau.freedesktop.org/wiki/Bugs/ > So it's about first put the bucket and then open the water tap. > > ;) > > chris > > ps: just found these macros for the state in fb.h: > > FBINFO_STATE_RUNNING = 0 > FBINFO_STATE_SUSPENDED = 1 > >

.../drm/nouveau/nouveau_drm.c > @@ -552,7 +552,7 @@ nouveau_do_suspend(struct drm_device *dev, bool runtime) > > if (dev->mode_config.num_crtc) { > NV_INFO(drm, "suspending console...\n"); > - nouveau_fbcon_set_suspend(dev, 1); > + nouveau_fbcon_set_suspend(dev, FBINFO_STATE_SUSPENDED, true); > NV_INFO(drm, "suspending display...\n"); > ret = nouveau_display_suspend(dev, runtime); > if (ret) > @@ -635,7 +635,7 @@ nouveau_do_resume(struct drm_device *dev, bool runtime) > NV_INFO(drm, "resuming display...\n"); > nouveau_displa...

.../drm/nouveau/nouveau_drm.c > @@ -552,7 +552,7 @@ nouveau_do_suspend(struct drm_device *dev, bool runtime) > > if (dev->mode_config.num_crtc) { > NV_INFO(drm, "suspending console...\n"); > - nouveau_fbcon_set_suspend(dev, 1); > + nouveau_fbcon_set_suspend(dev, FBINFO_STATE_SUSPENDED, true); > NV_INFO(drm, "suspending display...\n"); > ret = nouveau_display_suspend(dev, runtime); > if (ret) > @@ -635,7 +635,7 @@ nouveau_do_resume(struct drm_device *dev, bool runtime) > NV_INFO(drm, "resuming display...\n"); > nouveau_displa...

...console_lock(); - if (state == 0) - nouveau_fbcon_save_disable_accel(dev); - fb_set_suspend(drm->fbcon->helper.fbdev, state); - if (state == 1) + if (state == FBINFO_STATE_RUNNING) nouveau_fbcon_restore_accel(dev); + fb_set_suspend(drm->fbcon->helper.fbdev, state); + if (state == FBINFO_STATE_SUSPENDED) + nouveau_fbcon_save_disable_accel(dev); console_unlock(); } -- 1.7.10.4

On resume of a hibernated notebook, I get garbled virtual consoles. fb_set_suspend(*dev, state == 0 means dev is running ...) This patch fixes that issue for me: hibernate: kernel: nouveau [ DRM] suspending fbcon... kernel: nouveau [ DRM] suspending display... kernel: nouveau [ DRM] unpinning framebuffer(s)... kernel: nouveau [ DRM] evicting buffers... kernel: nouveau [

...> [1] http://nouveau.freedesktop.org/wiki/Bugs/ > >> So it's about first put the bucket and then open the water tap. >> >> ;) >> >> chris >> >> ps: just found these macros for the state in fb.h: >> >> FBINFO_STATE_RUNNING = 0 >> FBINFO_STATE_SUSPENDED = 1 >> >> >

.../drm/nouveau/nouveau_drm.c > @@ -552,7 +552,7 @@ nouveau_do_suspend(struct drm_device *dev, bool runtime) > > if (dev->mode_config.num_crtc) { > NV_INFO(drm, "suspending console...\n"); > - nouveau_fbcon_set_suspend(dev, 1); > + nouveau_fbcon_set_suspend(dev, FBINFO_STATE_SUSPENDED, true); > NV_INFO(drm, "suspending display...\n"); > ret = nouveau_display_suspend(dev, runtime); > if (ret) > @@ -635,7 +635,7 @@ nouveau_do_resume(struct drm_device *dev, bool runtime) > NV_INFO(drm, "resuming display...\n"); > nouveau_displa...

...; > @@ -552,7 +552,7 @@ nouveau_do_suspend(struct drm_device *dev, bool runtime) > > > > if (dev->mode_config.num_crtc) { > > NV_INFO(drm, "suspending console...\n"); > > - nouveau_fbcon_set_suspend(dev, 1); > > + nouveau_fbcon_set_suspend(dev, FBINFO_STATE_SUSPENDED, true); > > NV_INFO(drm, "suspending display...\n"); > > ret = nouveau_display_suspend(dev, runtime); > > if (ret) > > @@ -635,7 +635,7 @@ nouveau_do_resume(struct drm_device *dev, bool runtime) > > NV_INFO(drm, "resuming display...\n"...

...; > @@ -552,7 +552,7 @@ nouveau_do_suspend(struct drm_device *dev, bool runtime) > > > > if (dev->mode_config.num_crtc) { > > NV_INFO(drm, "suspending console...\n"); > > - nouveau_fbcon_set_suspend(dev, 1); > > + nouveau_fbcon_set_suspend(dev, FBINFO_STATE_SUSPENDED, true); > > NV_INFO(drm, "suspending display...\n"); > > ret = nouveau_display_suspend(dev, runtime); > > if (ret) > > @@ -635,7 +635,7 @@ nouveau_do_resume(struct drm_device *dev, bool runtime) > > NV_INFO(drm, "resuming display...\n"...