search for: fatalf

This replaces 13/13 of my v2 series; and now that it has pretty good testsuite coverage and demonstrable performance improvement to nbdinfo, I'm going ahead and pushing this now. We may still want to add further nbd_opt_* commands for other fine-grained tuning of negotiation, but for now, I think things have stabilized on this end, and I can return to polishing .list_exports on the nbdkit

Now runs a complete set of tests, notably including the AIO test. File descriptors are passed in and out as plain ints (instead of *os.File) for a couple of reasons: (1) We have to pass the plain int to syscall.Select. (2) Turning an fd into an os.File causes golang to set the blocking flag which is deeply unhelpful. Rich.

...ang/src/libguestfs.org/libnbd/libnbd_110_defaults_test.go index 7b4ea0a..005289b 100644 --- a/golang/src/libguestfs.org/libnbd/libnbd_110_defaults_test.go +++ b/golang/src/libguestfs.org/libnbd/libnbd_110_defaults_test.go @@ -47,7 +47,7 @@ func Test110Defaults(t *testing.T) { if err != nil { t.Fatalf("could not get tls state: %s", err) } - if tls != uint(TLS_DISABLE) { + if tls != TLS_DISABLE { t.Fatalf("unexpected tls state") } @@ -63,8 +63,8 @@ func Test110Defaults(t *testing.T) { if err != nil { t.Fatalf("could not get handshake flags: %s", err) }...

Well, the golang changes (patch 1 and 2/3 of v1) were already committed, all that was left was the OCaml changes. I'm a lot happier with how things turned out with an UNKNOWN constructor in the OCaml variants. Eric Blake (3): tests: Enhance coverage of enum/flag range checking ocaml: Support unknown values for Enum/Flags ocaml: Typesafe returns for REnum/RFlags generator/OCaml.ml

In v2: ack'ed preliminary patches have been pushed, and I've added a lot of testsuite coverage as well as putting the new API to use in nbdinfo. Eric Blake (2): api: Add nbd_opt_list_meta_context info: List available meta-contexts lib/internal.h | 1 + generator/API.ml | 84 ++++++++-

This is a subset of my v2 posting, but limited to just the NBD_OPT_LIST handling. The biggest change since v2 is the addition of added unit testing in all four language bindings (C, python, ocaml, golang). The tests require nbdkit built from git on PATH, and may not be entirely idiomatic, but I at least validated that they catch issues (for example, adding an exit statement near the end of the

...st220OptList(t *testing.T) { /* Require new-enough nbdkit */ srcdir := os.Getenv("srcdir") @@ -54,60 +64,46 @@ func Test220OptList(t *testing.T) { } /* First pass: server fails NBD_OPT_LIST */ - /* XXX We can't tell the difference */ - err = h.OptList() - if err != nil { - t.Fatalf("could not request opt_list: %s", err) - } - count, err := h.GetNrListExports() - if err != nil || count != 0 { - t.Fatalf("unexpected count after opt_list: %s", err) + exports = make([]string, 0, 4) + _, err = h.OptList(listf) + if err == nil { + t.Fatalf("expected error...

...ang/src/libguestfs.org/libnbd/libnbd_110_defaults_test.go index 9af0ed8..9e782ac 100644 --- a/golang/src/libguestfs.org/libnbd/libnbd_110_defaults_test.go +++ b/golang/src/libguestfs.org/libnbd/libnbd_110_defaults_test.go @@ -63,7 +63,7 @@ func Test110Defaults(t *testing.T) { if err != nil { t.Fatalf("could not get handshake flags: %s", err) } - if flags != HANDSHAKE_FLAG_FIXED_NEWSTYLE | HANDSHAKE_FLAG_NO_ZEROES { + if flags != HANDSHAKE_FLAG_MASK { t.Fatalf("unexpected handshake flags") } diff --git a/golang/src/libguestfs.org/libnbd/libnbd_120_set_non_defaults_tes...

Natural fallout after my recent testsuite additions that fixed a couple of ocaml bugs in the setters. However, on at least the OCaml code, I'm not sure what we should do if a newer libnbd ever returns a bit that an older NBD.mli was not expecting at the time the OCaml compiler ran (see below). I'm also not sure if there is a more efficient way to avoid outputting Val_FOO() converters for

...rg() { case 2: opname = flag.Arg(0) disk = flag.Arg(1) default: flag.Usage() os.Exit(1) } op := OpUndef for o, on := range OpNames { if opname == on { op = o break } } if op == OpUndef { log.Fatalf("unkown op %s\n", opname) } g, err := guestfs.Create() if err != nil { log.Fatalf("could not create guestfs handle: %s\n", err) } defer g.Close() /* Attach the disk image to libguestfs. */ isReadonly := map[Op]bool{ OpList: true,...

...g(1) > default: > flag.Usage() > os.Exit(1) > } > > op := OpUndef > for o, on := range OpNames { > if opname == on { > op = o > break > } > } > if op == OpUndef { > log.Fatalf("unkown op %s\n", opname) > > } > > g, err := guestfs.Create() > if err != nil { > log.Fatalf("could not create guestfs handle: %s\n", err) > } > defer g.Close() > > /* Attach the disk image to libguestfs. */ >...

Hi there, I'm working on a project to write a ProxyCommand that reaches out to an SSH CA to receive an SSH certificate prior to the connection. The ProxyCommand also creates a tunnel to the upstream SSH server. When using ProxyCommand alone, the issue is that the identity files are loaded as soon as SSH has fork/exec'd the process. It does not wait for a valid server negotiation. I

In v2: - now based on my proposal to add LIBNBD_SHUTDOWN_IMMEDIATE - four flags instead of two: STRICT_FLAGS is new (patch 4), and STRICT_BOUNDS is separate from STRICT_ZERO_SIZE (patch 5) - various refactorings for more shared code and less duplication Eric Blake (5): api: Add xxx_MASK constant for each Flags type generator: Refactor filtering of accepted OFlags api: Add