search for: fallbackundefatom

...what you want. I'm not sure what the gnu linker does about this with weak aliases. We may need a new resolver option as to how to handle this. ================ Comment at: lib/Core/Resolver.cpp:214 @@ +213,3 @@ + // for COFF "weak external" symbol. + const UndefinedAtom *fallbackUndefAtom = undefAtom->fallback(); + if (fallbackUndefAtom) { ---------------- You need to re-test: if (!_symbolTable.isDefined(undefName) because searchLibraries() may have already found a definition. http://llvm-reviews.chandlerc.com/D1550 _______________________________________________ llvm-c...

...at the gnu linker does about this with weak aliases. We may need a new resolver option as to how to handle this. > > > ================ > Comment at: lib/Core/Resolver.cpp:214 > @@ +213,3 @@ > + // for COFF "weak external" symbol. > + const UndefinedAtom *fallbackUndefAtom = undefAtom->fallback(); > + if (fallbackUndefAtom) { > ---------------- > You need to re-test: > if (!_symbolTable.isDefined(undefName) > because searchLibraries() may have already found a definition. > > > http://llvm-reviews.chandlerc.com/D1550 > __________...

...ut this with weak aliases. We may need a new resolver option as to how to handle this. >> >> >> ================ >> Comment at: lib/Core/Resolver.cpp:214 >> @@ +213,3 @@ >> + // for COFF "weak external" symbol. >> + const UndefinedAtom *fallbackUndefAtom = undefAtom->fallback(); >> + if (fallbackUndefAtom) { >> ---------------- >> You need to re-test: >> if (!_symbolTable.isDefined(undefName) >> because searchLibraries() may have already found a definition. >> >> >> http://llvm-reviews.chan...

...may need a new resolver option as to how to handle this. >>> >>> >>> ================ >>> Comment at: lib/Core/Resolver.cpp:214 >>> @@ +213,3 @@ >>> + // for COFF "weak external" symbol. >>> + const UndefinedAtom *fallbackUndefAtom = undefAtom->fallback(); >>> + if (fallbackUndefAtom) { >>> ---------------- >>> You need to re-test: >>> if (!_symbolTable.isDefined(undefName) >>> because searchLibraries() may have already found a definition. >>> >>> >...