Displaying 5 results from an estimated 5 matches for "fakeimageioclient".
2020 Jul 09
2
Re: [PATCH] RFC: rhv-upload-plugin: Use imageio client
...quot;,
"size": 536870912,
"url": "nbd:unix:/tmp/nbd.sock",
"timeout": 3000,
"sparse": true,
"ops": ["write"]
}
If we want to test with a fake, we can create fake client - no need for runing
http sever:
class FakeImageioClient:
def write(self, offset, buf):
pass
...
This is easy, but we don't test much.
I can start with replacing the fake server with fake client, and document
somewhere how to test using a real server.
> To unit test against a real imageio server is difficult I think: These
>...
2020 Jul 09
2
Re: [PATCH] RFC: rhv-upload-plugin: Use imageio client
...ives with the new
> feature.
>
> For “make check” we need something that will run in a few seconds and
> doesn't have any major dependencies.
>
> > If we want to test with a fake, we can create fake client - no need for runing
> > http sever:
> >
> > class FakeImageioClient:
> >
> > def write(self, offset, buf):
> > pass
> >
> > ...
> >
> > This is easy, but we don't test much.
>
> Right, this is what I was thinking of for “make check”. While it's
> not a comprehensive test, it is still testin...
2020 Jul 09
0
Re: [PATCH] RFC: rhv-upload-plugin: Use imageio client
...to-end test of the system when RHV 4.4 arrives with the new
feature.
For “make check” we need something that will run in a few seconds and
doesn't have any major dependencies.
> If we want to test with a fake, we can create fake client - no need for runing
> http sever:
>
> class FakeImageioClient:
>
> def write(self, offset, buf):
> pass
>
> ...
>
> This is easy, but we don't test much.
Right, this is what I was thinking of for “make check”. While it's
not a comprehensive test, it is still testing something valuable:
whether the Python code...
2020 Jul 09
0
Re: [PATCH] RFC: rhv-upload-plugin: Use imageio client
...;
> > For “make check” we need something that will run in a few seconds and
> > doesn't have any major dependencies.
> >
> > > If we want to test with a fake, we can create fake client - no need for runing
> > > http sever:
> > >
> > > class FakeImageioClient:
> > >
> > > def write(self, offset, buf):
> > > pass
> > >
> > > ...
> > >
> > > This is easy, but we don't test much.
> >
> > Right, this is what I was thinking of for “make check”. While it's
>...
2020 Jul 08
2
[PATCH] RFC: rhv-upload-plugin: Use imageio client
We can use now ImageioClient to communicate with ovirt-imageio server
on oVirt host.
Using the client greatly simplifies the plugin, and enables new features
like transparent proxy support. The client will use transfer_url if
possible, or fall back to proxy_url.
Since the client implements the buffer protocol, move to version 2 of
the API for more efficient pread().
Another advantage the client