search for: fail_pci

...ed long flags) { struct nouveau_drm *drm; int ret; @@ -647,9 +647,9 @@ static int nouveau_drm_probe(struct pci_dev *pdev, drm_dev->pdev = pdev; pci_set_drvdata(pdev, drm_dev); - ret = nouveau_drm_device_init(drm_dev); +/* ret = nouveau_drm_device_init(drm_dev); if (ret) - goto fail_pci; + goto fail_pci; */ ret = drm_dev_register(drm_dev, pent->driver_data); if (ret) @@ -1051,6 +1051,7 @@ driver_stub = { DRIVER_GEM | DRIVER_MODESET | DRIVER_PRIME | DRIVER_RENDER | DRIVER_KMS_LEGACY_CONTEXT, + .load = nouveau_drm_load, .open = nouveau_drm_open, .postclose...

...837,7 @@ static int nouveau_drm_probe(struct pci_dev *pdev, { struct nvkm_device *device; struct nouveau_drm *drm; + const struct drm_format_info *format; int ret; if (vga_switcheroo_client_probe_defer(pdev)) @@ -873,9 +875,11 @@ static int nouveau_drm_probe(struct pci_dev *pdev, goto fail_pci; if (drm->client.device.info.ram_size <= 32 * 1024 * 1024) - drm_fbdev_ttm_setup(drm->dev, 8); + format = drm_format_info(DRM_FORMAT_C8); else - drm_fbdev_ttm_setup(drm->dev, 32); + format = NULL; + + drm_client_setup(drm->dev, format); quirk_broken_nv_runpm(pdev); re...

...pci_dev *pdev, > { > struct nvkm_device *device; > struct nouveau_drm *drm; > + const struct drm_format_info *format; > int ret; > > if (vga_switcheroo_client_probe_defer(pdev)) > @@ -873,9 +875,11 @@ static int nouveau_drm_probe(struct pci_dev *pdev, > goto fail_pci; > > if (drm->client.device.info.ram_size <= 32 * 1024 * 1024) > - drm_fbdev_ttm_setup(drm->dev, 8); > + format = drm_format_info(DRM_FORMAT_C8); > else > - drm_fbdev_ttm_setup(drm->dev, 32); > + format = NULL; > + > + drm_client_setup(drm->dev, f...

...mp;driver_pci, &pdev->dev); + if (IS_ERR(drm_dev)) { + ret = PTR_ERR(drm_dev); + goto fail_nvkm; + } + + ret = pci_enable_device(pdev); + if (ret) + goto fail_drm; + + drm_dev->pdev = pdev; + pci_set_drvdata(pdev, drm_dev); + + ret = nouveau_drm_device_init(drm_dev); + if (ret) + goto fail_pci; + + ret = drm_dev_register(drm_dev, pent->driver_data); + if (ret) + goto fail_drm_dev_init; + + return 0; + +fail_drm_dev_init: + nouveau_drm_device_fini(drm_dev); +fail_pci: + pci_disable_device(pdev); +fail_drm: + drm_dev_put(drm_dev); +fail_nvkm: + nvkm_device_del(&device); + return re...

...if (ret) > - goto fail_drm; > + goto fail_nvkm; > > drm_dev->pdev = pdev; > pci_set_drvdata(pdev, drm_dev); > @@ -778,8 +775,6 @@ static int nouveau_drm_probe(struct pci_dev *pdev, > nouveau_drm_device_fini(drm_dev); > fail_pci: > pci_disable_device(pdev); > -fail_drm: > - drm_dev_put(drm_dev); it sounded like that when using devm_drm_dev_alloc we still have an initial refcount of 1, so at least in this regard nothing changed so I am wondering why this change is necessary and if the reason is unrel...

...t = PTR_ERR(drm_dev); > + goto fail_nvkm; > + } > + > + ret = pci_enable_device(pdev); > + if (ret) > + goto fail_drm; > + > + drm_dev->pdev = pdev; > + pci_set_drvdata(pdev, drm_dev); > + > + ret = nouveau_drm_device_init(drm_dev); > + if (ret) > + goto fail_pci; > + > + ret = drm_dev_register(drm_dev, pent->driver_data); > + if (ret) > + goto fail_drm_dev_init; > + > + return 0; > + > +fail_drm_dev_init: > + nouveau_drm_device_fini(drm_dev); > +fail_pci: > + pci_disable_device(pdev); > +fail_drm: > + drm_dev_put(...

...t;> + } >> + >> + ret = pci_enable_device(pdev); >> + if (ret) >> + goto fail_drm; >> + >> + drm_dev->pdev = pdev; >> + pci_set_drvdata(pdev, drm_dev); >> + >> + ret = nouveau_drm_device_init(drm_dev); >> + if (ret) >> + goto fail_pci; >> + >> + ret = drm_dev_register(drm_dev, pent->driver_data); >> + if (ret) >> + goto fail_drm_dev_init; >> + >> + return 0; >> + >> +fail_drm_dev_init: >> + nouveau_drm_device_fini(drm_dev); >> +fail_pci: >> + pci_disable_devic...

...; } + drm_dev = nouveau_to_drm_dev(nv_dev); ret = pci_enable_device(pdev); if (ret) - goto fail_drm; + goto fail_nvkm; drm_dev->pdev = pdev; pci_set_drvdata(pdev, drm_dev); @@ -778,8 +775,6 @@ static int nouveau_drm_probe(struct pci_dev *pdev, nouveau_drm_device_fini(drm_dev); fail_pci: pci_disable_device(pdev); -fail_drm: - drm_dev_put(drm_dev); fail_nvkm: nvkm_device_del(&device); return ret; @@ -799,7 +794,6 @@ nouveau_drm_device_remove(struct drm_device *dev) device = nvkm_device_find(client->device); nouveau_drm_device_fini(dev); - drm_dev_put(dev); nvk...

This series is intended to add support for shutting down the GPU on kernel shutdown/reboot using the ->shutdown() hook, similar to what amdgpu does. This is mainly intended to workaround a bios issue on the P50 that was preventing nouveau from initializing the dedicated GM107 GPU on that system properly. You can find more details on this issue in the patch labeled "Shut down GPU on kernel

Hi folks, Currently, when the device is removed (or the driver is unbound) the nouveau_drm structure de-allocated. However, it's still accessible from and used by some DRM layer callbacks. For example, file handles can be closed after the device has been removed (physically or otherwise). This series converts the Nouveau device structure to be allocated and de-allocated with the