search for: faddress

...11 at 12:35 PM, Chandler Carruth <chandlerc at google.com>wrote: > On Wed, Dec 28, 2011 at 2:06 AM, Anton Korobeynikov < > anton at korobeynikov.info> wrote: > >> > I believe the best option for us is to add the >> > --fno-omit-frame-pointer depending on the -faddress-sanitizer flag. >> > But in order to do this reliably, we need to remove all the instances >> > of -fomit-frame-pointer from the command line. >> Why? Just add -fno-omit-frame-pointer last. >> > > Yea, this should be easy to do inside the Clang driver. Feel free...

...2012 at 10:03 AM, Kostya Serebryany <kcc at google.com> wrote: > > > On Wed, Jul 11, 2012 at 3:06 PM, Alexey Samsonov <samsonov at google.com>wrote: > >> And one more question regarding ASan cmake build. >> Currently unittests are fine, but regular "clang -faddress-sanitizer" is >> not: >> > > As a side note: I don't like that the current cmake machinery builds asan > tests by explicitly passing libclang_rt.asan-x86_64.a. > IMO it needs to use "clang -faddress-sanitizer". > Why? These are internal tests, and I t...

> I believe the best option for us is to add the > --fno-omit-frame-pointer depending on the -faddress-sanitizer flag. > But in order to do this reliably, we need to remove all the instances > of -fomit-frame-pointer from the command line. Why? Just add -fno-omit-frame-pointer last. -- With best regards, Anton Korobeynikov Faculty of Mathematics and Mechanics, Saint Petersburg State Universi...

On Wed, Dec 28, 2011 at 2:06 AM, Anton Korobeynikov <anton at korobeynikov.info > wrote: > > I believe the best option for us is to add the > > --fno-omit-frame-pointer depending on the -faddress-sanitizer flag. > > But in order to do this reliably, we need to remove all the instances > > of -fomit-frame-pointer from the command line. > Why? Just add -fno-omit-frame-pointer last. > Yea, this should be easy to do inside the Clang driver. Feel free to CC me on any patch, an...

And one more question regarding ASan cmake build. Currently unittests are fine, but regular "clang -faddress-sanitizer" is not: current cmake build stores libclang_rt.asan-x86_64.a together with all the LLVM libs (in $build_path/lib/libclang_rt.asan-x86_64.a), but the Clang driver looks for asan runtime in clang resource dir: $build_path/lib/clang/3.2/lib/linux/libclang_rt.asan-x86_64.a). I can try...

On Wed, Jul 11, 2012 at 3:06 PM, Alexey Samsonov <samsonov at google.com>wrote: > And one more question regarding ASan cmake build. > Currently unittests are fine, but regular "clang -faddress-sanitizer" is > not: > As a side note: I don't like that the current cmake machinery builds asan tests by explicitly passing libclang_rt.asan-x86_64.a. IMO it needs to use "clang -faddress-sanitizer". --kcc > > current cmake build stores libclang_rt.asan-x86_64.a...

...to achieve in the helper. [code] def link_to_create_address(form_builder) link_to_function ''New address'', {:id => ''new_address_link''} do |page| form_builder.fields_for :addresses, Address.new, :child_index => ''NEW_RECORD'' do |faddress| html = render(:partial => ''address_container'', :locals => { :faddress => faddress, :uid => ''NEW_RECORD'', :show_edit_form => true }) pag...

..., there is no problem. We should be able to handle these easily. For the second bucket, this can be a bit tricky. It requires compiling the tests with a custom compiler and flags. Let's talk about the options for supporting this case. A) We could require the host compiler to have support for -faddress-sanitizer, but ensure that the just-built runtime library is used rather than the host compiler's runtime library. B) We can depend upon the Clang built in the same LLVM/Clang/CompilerRT checkout, and provide a custom compilation strategy to use it to instrument the unittest code. Option A ha...

...raversing the stack frames. __builtin_return_address(0) is generated for each function individually. It just reads the return address from the known position on the stack and does not help to unwind further. I believe the best option for us is to add the --fno-omit-frame-pointer depending on the -faddress-sanitizer flag. But in order to do this reliably, we need to remove all the instances of -fomit-frame-pointer from the command line. IIUC Clang doesn't support this now. -- Alexander Potapenko Software Engineer Google Moscow

...t; >>> For the second bucket, this can be a bit tricky. It requires compiling > the tests with a custom compiler and flags. Let's talk about the options > for supporting this case. > >>> > >>> A) We could require the host compiler to have support for > -faddress-sanitizer, but ensure that the just-built runtime library is used > rather than the host compiler's runtime library. > >>> B) We can depend upon the Clang built in the same > LLVM/Clang/CompilerRT checkout, and provide a custom compilation strategy > to use it to instrument...

...>> >>> For the second bucket, this can be a bit tricky. It requires compiling the tests with a custom compiler and flags. Let's talk about the options for supporting this case. >> >>> >> >>> A) We could require the host compiler to have support for -faddress-sanitizer, but ensure that the just-built runtime library is used rather than the host compiler's runtime library. >> >>> B) We can depend upon the Clang built in the same LLVM/Clang/CompilerRT checkout, and provide a custom compilation strategy to use it to instrument the unitte...

...river/Options.td The instrumentation pass has a bunch of flags which one can use via "-mllvm -asan-flag", but most of these flags should not be user-visible. > > Ideally all of this functionality would default to off, and be enabled via > '-fasan' or even better '-faddress-sanitizer' in Clang. > That's what I have now (-fasan). I slightly prefer -fasan over -faddress-sanitizer because the former is shorter. > That would match the behavior of '-fcatch-undefined-behavior', '-fmudflap', > etc. If you want to expose the more fine grai...

...shows one thing that gives me pause: you're using the -mllvm flag in Clang to directly pass options down to the LLVM layer. Also, it indicates the asan functionality defaults to on. Ideally all of this functionality would default to off, and be enabled via '-fasan' or even better '-faddress-sanitizer' in Clang. That would match the behavior of '-fcatch-undefined-behavior', '-fmudflap', etc. If you want to expose the more fine grained flags to users that are mentioned on the wiki page, they could also have '-f...' Clang flags, but it seems unlikely that thos...

On Tue, Dec 27, 2011 at 12:22 PM, Joerg Sonnenberger < joerg at britannica.bec.de> wrote: > On Tue, Dec 27, 2011 at 12:10:54PM -0800, Kostya Serebryany wrote: > > What would be the best fix for asan? > > Can you be explicit what you need to asan? Just the equivalent of > __builtin_return_address(0) or do you really need a full stack trace? > asan-rt uses

...t may make some Apple experts cry (or maybe not). The code uses google's coding style, which is similar, but not equivalent to the LLVM's one. We check it using cpplint before commits. LLVM license is used. The tests are ~2.5 KLOC; most of the tests require the clang compiler with -faddress-sanitizer switch. If possible, I'd prefer not to review the patch in a usual way (too big), but instead have the comments to the files in http://code.google.com/p/address-sanitizer/source/browse/#svn%2Ftrunk%2Fasan Or, alternatively, commit everything as is and then iterate over individua...

...ly. >> >> For the second bucket, this can be a bit tricky. It requires compiling >> the tests with a custom compiler and flags. Let's talk about the options >> for supporting this case. >> >> A) We could require the host compiler to have support for >> -faddress-sanitizer, but ensure that the just-built runtime library is used >> rather than the host compiler's runtime library. >> B) We can depend upon the Clang built in the same LLVM/Clang/CompilerRT >> checkout, and provide a custom compilation strategy to use it to instrument >&...

...these easily. >>> >>> For the second bucket, this can be a bit tricky. It requires compiling the tests with a custom compiler and flags. Let's talk about the options for supporting this case. >>> >>> A) We could require the host compiler to have support for -faddress-sanitizer, but ensure that the just-built runtime library is used rather than the host compiler's runtime library. >>> B) We can depend upon the Clang built in the same LLVM/Clang/CompilerRT checkout, and provide a custom compilation strategy to use it to instrument the unittest code....

...and if people want to do more thorough review that > can happen post commit. > Do I just start committing or someone still wants to make a pre-review? > > > LLVM license is used. > > The tests are ~2.5 KLOC; most of the tests require the clang compiler > > with -faddress-sanitizer switch. > > If possible, I'd prefer not to review the patch in a usual way (too > big), > > but instead have the comments to the files > > in > http://code.google.com/p/address-sanitizer/source/browse/#svn%2Ftrunk%2Fasan > > Or, alternatively, commi...

...le to handle > these easily. > > For the second bucket, this can be a bit tricky. It requires compiling the > tests with a custom compiler and flags. Let's talk about the options for > supporting this case. > > A) We could require the host compiler to have support for > -faddress-sanitizer, but ensure that the just-built runtime library is used > rather than the host compiler's runtime library. > B) We can depend upon the Clang built in the same LLVM/Clang/CompilerRT > checkout, and provide a custom compilation strategy to use it to instrument > the unittest...

...is a blocker. Unless anyone objects, I think we should just bring the code in as is so that ASAN works, and if people want to do more thorough review that can happen post commit. >    LLVM license is used. >    The tests are ~2.5 KLOC; most of the tests require the clang compiler > with -faddress-sanitizer switch. >    If possible, I'd prefer not to review the patch in a usual way (too big), > but instead have the comments to the files > in http://code.google.com/p/address-sanitizer/source/browse/#svn%2Ftrunk%2Fasan >    Or, alternatively, commit everything as is and then it...