search for: f_length

https://bugzilla.samba.org/show_bug.cgi?id=10494 Summary: remove-source-files fails with symlinks Product: rsync Version: 3.1.0 Platform: x64 OS/Version: Linux Status: NEW Severity: major Priority: P5 Component: core AssignedTo: wayned at samba.org ReportedBy: afried at deteque.com

...eation time is the one of the file just before it. I think I got it : after this, in recv_file_entry(), in flist.c, line 787 in version 3.1.3 if (first_hlink_ndx >= flist->ndx_start) { struct file_struct *first = flist->files[first_hlink_ndx - flist->ndx_start]; file_length = F_LENGTH(first); we should add "crtime = f_crtime(first);" just after. -- You are receiving this mail because: You are the QA Contact for the bug.

3.1, including the latest version, produces bogus ---stats output: % rsync -r --stats . > /tmp/3.1-n % tail -n 17 /tmp/3.1-n Number of files: 3,159 (reg: 2,984, dir: 173, link: 2) Number of created files: 0 Number of deleted files: 0 Number of regular files transferred: 0 Total file size: -6,417,895,484,864,819,269 bytes ************************************************* Total transferred file

...1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/receiver.c b/receiver.c index 39c5e49..33b21fb 100644 --- a/receiver.c +++ b/receiver.c @@ -721,6 +721,12 @@ int recv_files(int f_in, char *local_name) recv_ok = receive_data(f_in, fnamecmp, fd1, st.st_size, fname, fd2, F_LENGTH(file)); + if (do_fadvise(fd2, 0, 0, POSIX_FADV_DONTNEED) != 0) { + rsyserr(FERROR_XFER, errno, + "fadvise failed in writing %s", + full_fname(fname)); + } + log_item(log...

...xternal actions on [recv] log entries is explicitly meaningless. --- rsync-3.0.3.orig/receiver.c 2008-08-20 16:28:41.000000000 +0400 +++ rsync-3.0.3/receiver.c 2008-08-20 16:33:06.000000000 +0400 @@ -678,8 +678,6 @@ recv_ok = receive_data(f_in, fnamecmp, fd1, st.st_size, fname, fd2, F_LENGTH(file)); - log_item(log_code, file, &initial_stats, iflags, NULL); - if (fd1 != -1) close(fd1); if (close(fd2) < 0) { @@ -719,6 +717,7 @@ if (remove_source_files || inc_recurse || (preserve_hard_links && F_IS_HLINKED(file))) send_msg_int(MSG_SUCCESS, ndx); +...

...ut, char *local_name) send_msg_int(MSG_NO_SEND, ndx); continue; } - +#ifdef HAVE_FALLOCATE + if (!sparse_files) + /* + * If this fails then either the filesystem does not + * support this feature or we run out of disk space. + */ + do_fallocate(fd2, FALLOC_FL_KEEP_SIZE, 0, F_LENGTH(file)); +#endif /* log the transfer */ if (log_before_transfer) log_item(FCLIENT, file, iflags, NULL); diff --git a/rsync.h b/rsync.h index 731f4fe..b293edc 100644 --- a/rsync.h +++ b/rsync.h @@ -1241,3 +1241,7 @@ int inet_pton(int af, const char *src, void *dst); #ifdef MAINTAINER_MODE...

While going through an old todo list I found that these patches had fallen by the way-side. About a year ago I initiated a discussion[1] with the Linux kernel folks regarding the lack of any useable fadvise support on the kernel side. As a result, I was observing extremely poor performance on my server after backup as executable pages were being swapped out in favor of data waiting to be flushed

...keep_time = !preserve_mtimes ? 0 : S_ISDIR(file->mode) ? !omit_dir_times : S_ISLNK(file->mode) ? !omit_link_times + : IS_DEVICE(file->mode) ? !omit_device_times + : IS_SPECIAL(file->mode) ? !omit_special_times : 1; if (S_ISREG(file->mode) && F_LENGTH(file) != sxp->st.st_size) diff -aNpRruz -X /etc/diff.excludes rsync-3.2.7/options.c devel-3.2.7/options.c --- rsync-3.2.7/options.c 2022-09-10 14:14:42.000000000 -0600 +++ devel-3.2.7/options.c 2022-09-10 14:14:42.000000000 -0600 @@ -66,6 +66,8 @@ int preserve_atimes = 0; int preserve_crtimes =...

...); + else { + OFF_T off = lseek(fd, 0, SEEK_END); + if (off == (OFF_T) -1) + rsyserr(FERROR, errno, "failed to seek to end of %s to determine size", fname); + else { + sx.st.st_size = off; + } + close(fd); + } + } + if (append_mode > 0 && sx.st.st_size >= F_LENGTH(file)) { #ifdef SUPPORT_HARD_LINKS if (F_IS_HLINKED(file)) diff -pur rsync-3.0.7/options.c rsync-3.0.7.new/options.c --- rsync-3.0.7/options.c 2009-12-21 22:40:41.000000000 +0000 +++ rsync-3.0.7.new/options.c 2010-06-14 10:24:49.329958121 +0100 @@ -48,6 +48,7 @@ int append_mode = 0; int keep_d...