search for: f_dupfd_cloexec

...lush(NULL)' is + * supposed to reset the underlying offset of seekable stdin, but + * glibc is buggy and requires an explicit fflush(stdin) as + * well. https://sourceware.org/bugzilla/show_bug.cgi?id=12799 + */ + fflush (stdin); + fflush (NULL); + if (listen_stdin || run) { +#ifndef F_DUPFD_CLOEXEC +#define F_DUPFD_CLOEXEC F_DUPFD +#endif + orig_in = fcntl (STDIN_FILENO, F_DUPFD_CLOEXEC, STDERR_FILENO + 1); + orig_out = fcntl (STDOUT_FILENO, F_DUPFD_CLOEXEC, STDERR_FILENO + 1); +#if F_DUPFD == F_DUPFD_CLOEXEC + orig_in = set_cloexec (orig_in); + orig_out = set_cloexec (orig_out);...

...e originals + * when needed. We are still single-threaded at this point, and + * already checked that stdin/out were open, so we don't have to + * worry about other threads accidentally grabbing our intended fds, + * or races on FD_CLOEXEC. + */ + if (listen_stdin || run) { +#ifndef F_DUPFD_CLOEXEC +#define F_DUPFD_CLOEXEC F_DUPFD +#endif + orig_in = fcntl (STDIN_FILENO, F_DUPFD_CLOEXEC, STDERR_FILENO + 1); + orig_out = fcntl (STDOUT_FILENO, F_DUPFD_CLOEXEC, STDERR_FILENO + 1); +#if F_DUPFD == F_DUPFD_CLOEXEC + orig_in = set_cloexec (orig_in); + orig_out = set_cloexec (orig_out);...

This is what I've been playing with in response to my earlier question about what to do with 'nbdkit -s sh -' (https://www.redhat.com/archives/libguestfs/2020-April/msg00032.html) I'm still open to ideas on a better name, and/or whether adding <stdbool.h> to our public include files is a good idea (if not, returning int instead of bool is tolerable). Eric Blake (2):

Dear all, we're having two different problems with migrations in libvirt, running as root user on host machines with CentOS release 5.5 (Final), kernel: Linux 2.6.32.24 #3 SMP Fri Oct 29 16:22:02 BST 2010 x86_64 x86_64 x86_64 GNU/Linux First case: virsh version Compiled against library: libvir 0.9.4 Using library: libvir 0.9.4 Using API: QEMU 0.9.4 Running hypervisor: QEMU 1.0.50

In v2: - use int instead of bool in the public header - split the tests from the code - don't overload test-layers; instead, add new tests - add a missing fflush exposed by the new tests - other minor cleanups Eric Blake (3): server: Add nbdkit_stdio_safe server: Sanitize stdin/out before running plugin code server: More tests of stdin/out handling docs/nbdkit-plugin.pod |

...or. */ > + fd = dup (iso_fd); We use system(), but only during .get_ready(). I don't see any places where we fork a child after the first .open, so not setting FD_CLOEXEC here won't leak into the next client's connection (if we ever add later fork()s, we'd have to use fcntl(F_DUPFD_CLOEXEC) instead); but maybe a comment to that effect wouldn't hurt (since we already audited which fds need CLOEXEC atomically set, seeing the comment will speed up any re-audit). You are changing from one fd shared among all clients to one fd per client, but I don't see that as being a severe...

...ing whether dirfd is declared... (cached) yes checking whether dirfd is a macro... no checking whether // is distinct from /... (cached) no checking whether dup2 works... yes checking for error_at_line... yes checking whether fcntl handles F_DUPFD correctly... yes checking whether fcntl understands F_DUPFD_CLOEXEC... needs runtime check checking whether fcntl is declared without a macro... yes checking whether openat is declared without a macro... yes checking whether fdopendir is declared... (cached) yes checking whether fdopendir works... yes checking for fchmodat... yes checking for fstatat... yes checkin...

...ing whether dirfd is declared... (cached) yes checking whether dirfd is a macro... no checking whether // is distinct from /... (cached) no checking whether dup2 works... yes checking for error_at_line... yes checking whether fcntl handles F_DUPFD correctly... yes checking whether fcntl understands F_DUPFD_CLOEXEC... needs runtime check checking whether fcntl is declared without a macro... yes checking whether openat is declared without a macro... yes checking whether fdopendir is declared... (cached) yes checking whether fdopendir works... yes checking for fchmodat... yes checking for fstatat... yes checkin...

...ing whether dirfd is declared... (cached) yes checking whether dirfd is a macro... no checking whether // is distinct from /... (cached) no checking whether dup2 works... yes checking for error_at_line... yes checking whether fcntl handles F_DUPFD correctly... yes checking whether fcntl understands F_DUPFD_CLOEXEC... needs runtime check checking whether fcntl is declared without a macro... yes checking whether openat is declared without a macro... yes checking whether fdopendir is declared... (cached) yes checking whether fdopendir works... yes checking for fchmodat... yes checking for fstatat... yes checkin...

...ing whether dirfd is declared... (cached) yes checking whether dirfd is a macro... no checking whether // is distinct from /... (cached) no checking whether dup2 works... yes checking for error_at_line... yes checking whether fcntl handles F_DUPFD correctly... yes checking whether fcntl understands F_DUPFD_CLOEXEC... needs runtime check checking whether fcntl is declared without a macro... yes checking whether openat is declared without a macro... yes checking whether fdopendir is declared... (cached) yes checking whether fdopendir works... yes checking for fchmodat... yes checking for fstatat... yes checkin...

...ing whether dirfd is declared... (cached) yes checking whether dirfd is a macro... no checking whether // is distinct from /... (cached) no checking whether dup2 works... yes checking for error_at_line... yes checking whether fcntl handles F_DUPFD correctly... yes checking whether fcntl understands F_DUPFD_CLOEXEC... needs runtime check checking whether fcntl is declared without a macro... yes checking whether openat is declared without a macro... yes checking whether fdopendir is declared... (cached) yes checking whether fdopendir works... yes checking for fchmodat... yes checking for fstatat... yes checkin...

...ing whether dirfd is declared... (cached) yes checking whether dirfd is a macro... no checking whether // is distinct from /... (cached) no checking whether dup2 works... yes checking for error_at_line... yes checking whether fcntl handles F_DUPFD correctly... yes checking whether fcntl understands F_DUPFD_CLOEXEC... needs runtime check checking whether fcntl is declared without a macro... yes checking whether openat is declared without a macro... yes checking whether fdopendir is declared... (cached) yes checking whether fdopendir works... yes checking for fchmodat... yes checking for fstatat... yes checkin...

...wap.h usability... no checking byteswap.h presence... no checking for byteswap.h... no checking whether // is distinct from /... (cached) no checking whether dup2 works... yes checking for error_at_line... no checking whether fcntl handles F_DUPFD correctly... yes checking whether fcntl understands F_DUPFD_CLOEXEC... yes checking whether conversion from 'int' to 'long double' works... yes checking whether getdtablesize works... yes checking whether program_invocation_name is declared... no checking whether program_invocation_short_name is declared... no checking whether __argv is declared......

...ing whether dirfd is declared... (cached) yes checking whether dirfd is a macro... no checking whether // is distinct from /... (cached) no checking whether dup2 works... yes checking for error_at_line... yes checking whether fcntl handles F_DUPFD correctly... yes checking whether fcntl understands F_DUPFD_CLOEXEC... needs runtime check checking whether fcntl is declared without a macro... yes checking whether openat is declared without a macro... yes checking whether fdopendir is declared... (cached) yes checking whether fdopendir works... yes checking for fchmodat... yes checking for fstatat... yes checkin...

...ing whether dirfd is declared... (cached) yes checking whether dirfd is a macro... no checking whether // is distinct from /... (cached) no checking whether dup2 works... yes checking for error_at_line... yes checking whether fcntl handles F_DUPFD correctly... yes checking whether fcntl understands F_DUPFD_CLOEXEC... needs runtime check checking whether fcntl is declared without a macro... yes checking whether openat is declared without a macro... yes checking whether fdopendir is declared... (cached) yes checking whether fdopendir works... yes checking for fchmodat... yes checking for fstatat... yes checkin...

...ing whether dirfd is declared... (cached) yes checking whether dirfd is a macro... no checking whether // is distinct from /... (cached) no checking whether dup2 works... yes checking for error_at_line... yes checking whether fcntl handles F_DUPFD correctly... yes checking whether fcntl understands F_DUPFD_CLOEXEC... needs runtime check checking whether fcntl is declared without a macro... yes checking whether openat is declared without a macro... yes checking whether fdopendir is declared... (cached) yes checking whether fdopendir works... yes checking for fchmodat... yes checking for fstatat... yes checkin...

...ing whether dirfd is declared... (cached) yes checking whether dirfd is a macro... no checking whether // is distinct from /... (cached) no checking whether dup2 works... yes checking for error_at_line... yes checking whether fcntl handles F_DUPFD correctly... yes checking whether fcntl understands F_DUPFD_CLOEXEC... needs runtime check checking whether fcntl is declared without a macro... yes checking whether openat is declared without a macro... yes checking whether fdopendir is declared... (cached) yes checking whether fdopendir works... yes checking for fchmodat... yes checking for fstatat... yes checkin...

...ing whether dirfd is declared... (cached) yes checking whether dirfd is a macro... no checking whether // is distinct from /... (cached) no checking whether dup2 works... yes checking for error_at_line... yes checking whether fcntl handles F_DUPFD correctly... yes checking whether fcntl understands F_DUPFD_CLOEXEC... needs runtime check checking whether fcntl is declared without a macro... yes checking whether openat is declared without a macro... yes checking whether fdopendir is declared... (cached) yes checking whether fdopendir works... yes checking for fchmodat... yes checking for fstatat... yes checkin...

...ing whether dirfd is declared... (cached) yes checking whether dirfd is a macro... no checking whether // is distinct from /... (cached) no checking whether dup2 works... yes checking for error_at_line... yes checking whether fcntl handles F_DUPFD correctly... yes checking whether fcntl understands F_DUPFD_CLOEXEC... needs runtime check checking whether fcntl is declared without a macro... yes checking whether openat is declared without a macro... yes checking whether fdopendir is declared... (cached) yes checking whether fdopendir works... yes checking for fchmodat... yes checking for fstatat... yes checkin...

...ing whether dirfd is declared... (cached) yes checking whether dirfd is a macro... no checking whether // is distinct from /... (cached) no checking whether dup2 works... yes checking for error_at_line... yes checking whether fcntl handles F_DUPFD correctly... yes checking whether fcntl understands F_DUPFD_CLOEXEC... needs runtime check checking whether fcntl is declared without a macro... yes checking whether openat is declared without a macro... yes checking whether fdopendir is declared... (cached) yes checking whether fdopendir works... yes checking for fchmodat... yes checking for fstatat... yes checkin...