search for: f948dce

...llib/common_utils.ml | 12 +++++++++--- > mllib/common_utils.mli | 12 ++++++++++-- > mllib/common_utils_tests.ml | 26 ++++++++++++++++++++++++++ > 3 files changed, 45 insertions(+), 5 deletions(-) > > diff --git a/mllib/common_utils.ml b/mllib/common_utils.ml > index f948dce..b6f3046 100644 > --- a/mllib/common_utils.ml > +++ b/mllib/common_utils.ml > @@ -130,15 +130,21 @@ module String = struct > done; > if not !r then s else Bytes.to_string b2 > > - let rec nsplit sep str = > + let rec nsplit ?(noempty = true) ?(count = -...

...tgolembi@redhat.com> --- mllib/common_utils.ml | 12 +++++++++--- mllib/common_utils.mli | 12 ++++++++++-- mllib/common_utils_tests.ml | 26 ++++++++++++++++++++++++++ 3 files changed, 45 insertions(+), 5 deletions(-) diff --git a/mllib/common_utils.ml b/mllib/common_utils.ml index f948dce..b6f3046 100644 --- a/mllib/common_utils.ml +++ b/mllib/common_utils.ml @@ -130,15 +130,21 @@ module String = struct done; if not !r then s else Bytes.to_string b2 - let rec nsplit sep str = + let rec nsplit ?(noempty = true) ?(count = -1) sep str = let len = length str...

...th Failure "int_of_string" -> + with Failure _ -> failwithf "%s: expecting an int64, but got '%s'" test_name arg in pr ", %Ld" i | Bool _, arg, _ -> diff --git a/mllib/common_utils.ml b/mllib/common_utils.ml index f4ddf01..f948dce 100644 --- a/mllib/common_utils.ml +++ b/mllib/common_utils.ml @@ -730,7 +730,7 @@ let compare_version v1 v2 = let rest = Str.matched_group 2 str in let n = try `Number (int_of_string n) - with Failure "int_of_string" -> `String n in +...

v4: - rebase to more recent master - 1/6: using just "quote" instead of "Filename.quote" - 2/6: reformated block of code according to Richards suggestion - 4/6: added tests for nsplit v3: Addressed Pino's comments, namely: - input_ova.ml - untar takes list of paths - renamed untar_partial to untar_metadata - replaced uggly regex with nsplit - tests - test changes

v3: - Split out test for "unix-like" guest OSes into separate commit. - Add guestfish --format=qcow2 to the test (x2). Rich.