Displaying 3 results from an estimated 3 matches for "f8dda0b0".
2019 Jul 31
0
[nbdkit PATCH 8/8] rate: Atomically set CLOEXEC on fds
...hit a problematic system.
[1] http://austingroupbugs.net/view.php?id=411
Signed-off-by: Eric Blake <eblake@redhat.com>
---
filters/rate/rate.c | 2 +-
server/utils.c | 4 ++++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/filters/rate/rate.c b/filters/rate/rate.c
index f8dda0b0..9476a27f 100644
--- a/filters/rate/rate.c
+++ b/filters/rate/rate.c
@@ -204,7 +204,7 @@ maybe_adjust (const char *file, struct bucket *bucket, pthread_mutex_t *lock)
if (!file) return;
- fp = fopen (file, "r");
+ fp = fopen (file, "re");
if (fp == NULL)
return; /...
2019 Jul 31
13
[nbdkit PATCH 0/8] fd leak safety
There's enough here to need a review; some of it probably needs
backporting to stable-1.12.
This probably breaks tests on Haiku or other platforms that have not
been as on-the-ball about atomic CLOEXEC; feel free to report issues
that arise, and I'll help come up with workarounds (even if we end up
leaving a rare fd leak on less-capable systems).
Meanwhile, I'm still working on my
2019 Aug 02
23
[nbdkit PATCH v2 00/17] fd leak safety
This is a major rewrite compared to my v1 series, where I've tried
a lot harder to ensure that we still accommodate building on Haiku
(although I have not actually yet fired up a Haiku VM to try it
for myself). I also managed to make the sh plugin fully parallel,
on capable platforms.
See also my question on patch 10 on whether I've picked the best
naming convention.
Eric Blake (17):