Displaying 3 results from an estimated 3 matches for "f6c34e2cf".
2017 Oct 11
2
[PATCH] v2v: -i vmx: Refuse to load a disk image by accident.
...nto memory and crash. Catch this narrow case and
print an error.
However don't fail if ‘file’ is not installed or if we don't know what
the file is.
---
v2v/parse_vmx.ml | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/v2v/parse_vmx.ml b/v2v/parse_vmx.ml
index 65d5a0edd..f6c34e2cf 100644
--- a/v2v/parse_vmx.ml
+++ b/v2v/parse_vmx.ml
@@ -268,6 +268,18 @@ let remove_vmx_escapes str =
(* Parsing. *)
let rec parse_file vmx_filename =
+ (* One person pointed -i vmx at the VMDK file, resulting in an out
+ * of memory error. Avoid this narrow case.
+ *)
+ let () =
+ l...
2017 Oct 11
1
Re: [PATCH] v2v: -i vmx: Refuse to load a disk image by accident.
...ever don't fail if ‘file’ is not installed or if we don't know what
> > the file is.
> > ---
> > v2v/parse_vmx.ml | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/v2v/parse_vmx.ml b/v2v/parse_vmx.ml
> > index 65d5a0edd..f6c34e2cf 100644
> > --- a/v2v/parse_vmx.ml
> > +++ b/v2v/parse_vmx.ml
> > @@ -268,6 +268,18 @@ let remove_vmx_escapes str =
> >
> > (* Parsing. *)
> > let rec parse_file vmx_filename =
> > + (* One person pointed -i vmx at the VMDK file, resulting in an out
>...
2017 Oct 11
0
Re: [PATCH] v2v: -i vmx: Refuse to load a disk image by accident.
...> print an error.
>
> However don't fail if ‘file’ is not installed or if we don't know what
> the file is.
> ---
> v2v/parse_vmx.ml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/v2v/parse_vmx.ml b/v2v/parse_vmx.ml
> index 65d5a0edd..f6c34e2cf 100644
> --- a/v2v/parse_vmx.ml
> +++ b/v2v/parse_vmx.ml
> @@ -268,6 +268,18 @@ let remove_vmx_escapes str =
>
> (* Parsing. *)
> let rec parse_file vmx_filename =
> + (* One person pointed -i vmx at the VMDK file, resulting in an out
> + * of memory error. Avoid thi...