search for: f663b5b38fff

...' test-virt-sparsify-in-place-fstrim-unsupported.log FAIL test-virt-sparsify-in-place-fstrim-unsupported.sh (exit status: 1) We expect (for the purposes of the regression test) that vfat filesystems cannot be trimmed. It turns out that fstrim for vfat has now been implemented in Linux (commit f663b5b38fff) :-) Thanks Wentao Wang (this is actually great for virt-v2v). So we need to find another filesystem which doesn't support fstrim. Or maybe just delete this regression test. Thoughts? Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programmin...

Since Linux commit f663b5b38fff trimming vfat is now supported by Linux. This broke the test which assumed it was not supported. Use another filesystem (minix) which does not support trimming instead. Thanks: Daniel P. Berrangé and Pino Toscano. --- ...virt-sparsify-in-place-fstrim-unsupported.sh | 17 ++++++++++------- 1 fil...

...ed.log > > FAIL test-virt-sparsify-in-place-fstrim-unsupported.sh (exit status: 1) > > > > We expect (for the purposes of the regression test) that vfat > > filesystems cannot be trimmed. It turns out that fstrim for vfat has > > now been implemented in Linux (commit f663b5b38fff) :-) Thanks > > Wentao Wang (this is actually great for virt-v2v). > > > > So we need to find another filesystem which doesn't support fstrim. > > Or maybe just delete this regression test. > > > > Thoughts? > > Presumably something ancient like ext...

This addresses the feedback on v1 here: https://www.redhat.com/archives/libguestfs/2018-September/msg00023.html Rich.

...in-place-fstrim-unsupported.log > FAIL test-virt-sparsify-in-place-fstrim-unsupported.sh (exit status: 1) > > We expect (for the purposes of the regression test) that vfat > filesystems cannot be trimmed. It turns out that fstrim for vfat has > now been implemented in Linux (commit f663b5b38fff) :-) Thanks > Wentao Wang (this is actually great for virt-v2v). > > So we need to find another filesystem which doesn't support fstrim. > Or maybe just delete this regression test. > > Thoughts? Presumably something ancient like ext2 will not support it, and is unlikely t...

...L test-virt-sparsify-in-place-fstrim-unsupported.sh (exit status: 1) > > > > > > We expect (for the purposes of the regression test) that vfat > > > filesystems cannot be trimmed. It turns out that fstrim for vfat has > > > now been implemented in Linux (commit f663b5b38fff) :-) Thanks > > > Wentao Wang (this is actually great for virt-v2v). > > > > > > So we need to find another filesystem which doesn't support fstrim. > > > Or maybe just delete this regression test. > > > > > > Thoughts? > > > &g...

...-in-place-fstrim-unsupported.sh (exit status: 1) > > > > > > > > We expect (for the purposes of the regression test) that vfat > > > > filesystems cannot be trimmed. It turns out that fstrim for vfat has > > > > now been implemented in Linux (commit f663b5b38fff) :-) Thanks > > > > Wentao Wang (this is actually great for virt-v2v). > > > > > > > > So we need to find another filesystem which doesn't support fstrim. > > > > Or maybe just delete this regression test. > > > > > > > &gt...

Since Linux commit f663b5b38fff trimming vfat is now supported by Linux. This broke the test which assumed it was not supported. Use another filesystem (minix) which does not support trimming instead. Thanks: Daniel P. Berrangé and Pino Toscano. --- ...est-virt-sparsify-in-place-fstrim-unsupported.sh | 13 ++++++------- tests...