search for: f638149

...D and GET requests, the SSL certificate has only been validated on the HEAD request. It should be validated on both. --- lib/Sys/VirtV2V/Transfer/ESX.pm | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/lib/Sys/VirtV2V/Transfer/ESX.pm b/lib/Sys/VirtV2V/Transfer/ESX.pm index f638149..5d6b586 100644 --- a/lib/Sys/VirtV2V/Transfer/ESX.pm +++ b/lib/Sys/VirtV2V/Transfer/ESX.pm @@ -143,6 +143,8 @@ sub get_volume my $died = $r->header('X-Died'); die($died) if (defined($died)); + $self->verify_certificate($r) unless ($self->{_v2v_noverify})...

We were seeing 100% failure rates transferring 10G disk images from ESX on a particular setup. We also weren't spotting the transfer failure, and dying with a strange error from libguestfs. These 2 patches fix the error check which should have made it obvious what was failing, and the underlying error.