Displaying 7 results from an estimated 7 matches for "f20dfb8".
2017 May 14
8
[PATCH 1/3] Fix ERROR: trailing statements should be on next line
From: Maciej Fijalkowski <macfij7 at wp.pl>
Signed-off-by: Maciej Fijalkowski <macfij7 at wp.pl>
---
drivers/net/virtio_net.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 9320d96..f20dfb8 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -217,7 +217,8 @@ static void give_pages(struct receive_queue *rq, struct page *page)
struct page *end;
/* Find end of list, sew whole thing into vi->rq.pages. */
- for (end = page; end->private; end = (struct page *...
2017 May 14
8
[PATCH 1/3] Fix ERROR: trailing statements should be on next line
From: Maciej Fijalkowski <macfij7 at wp.pl>
Signed-off-by: Maciej Fijalkowski <macfij7 at wp.pl>
---
drivers/net/virtio_net.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 9320d96..f20dfb8 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -217,7 +217,8 @@ static void give_pages(struct receive_queue *rq, struct page *page)
struct page *end;
/* Find end of list, sew whole thing into vi->rq.pages. */
- for (end = page; end->private; end = (struct page *...
2017 May 15
0
[PATCH 2/3] Fix ERROR: Macros with complex values should be enclosed in parentheses
...p.pl>
>
> Signed-off-by: Maciej Fijalkowski <macfij7 at wp.pl>
This is not a complex value.
> ---
> drivers/net/virtio_net.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index f20dfb8..6c8170c 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -2663,7 +2663,7 @@ static struct virtio_device_id id_table[] = {
> };
>
> #define VIRTNET_FEATURES \
> - VIRTIO_NET_F_CSUM, VIRTIO_NET_F_GUEST_CSUM, \
> + (VIRTIO_NET_F_CSUM, VIRTIO_NE...
2017 May 15
0
[PATCH 1/3] Fix ERROR: trailing statements should be on next line
...ciej Fijalkowski <macfij7 at wp.pl>
I prefer the original form - ; isn't a full statement.
> ---
> drivers/net/virtio_net.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 9320d96..f20dfb8 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -217,7 +217,8 @@ static void give_pages(struct receive_queue *rq, struct page *page)
> struct page *end;
>
> /* Find end of list, sew whole thing into vi->rq.pages. */
> - for (end = page; en...
2017 May 15
1
[PATCH 1/3] Fix ERROR: trailing statements should be on next line
...;
> I prefer the original form - ; isn't a full statement.
>
> > ---
> > drivers/net/virtio_net.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> > index 9320d96..f20dfb8 100644
> > --- a/drivers/net/virtio_net.c
> > +++ b/drivers/net/virtio_net.c
> > @@ -217,7 +217,8 @@ static void give_pages(struct receive_queue *rq, struct page *page)
> > struct page *end;
> >
> > /* Find end of list, sew whole thing into vi->rq.pages....
2017 May 14
0
[PATCH 2/3] Fix ERROR: Macros with complex values should be enclosed in parentheses
From: Maciej Fijalkowski <macfij7 at wp.pl>
Signed-off-by: Maciej Fijalkowski <macfij7 at wp.pl>
---
drivers/net/virtio_net.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index f20dfb8..6c8170c 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -2663,7 +2663,7 @@ static struct virtio_device_id id_table[] = {
};
#define VIRTNET_FEATURES \
- VIRTIO_NET_F_CSUM, VIRTIO_NET_F_GUEST_CSUM, \
+ (VIRTIO_NET_F_CSUM, VIRTIO_NET_F_GUEST_CSUM, \
VIRTIO_NET_F_MAC, \...
2017 May 15
1
[PATCH 1/3] Fix ERROR: trailing statements should be on next line
...;
> I prefer the original form - ; isn't a full statement.
>
> > ---
> > drivers/net/virtio_net.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> > index 9320d96..f20dfb8 100644
> > --- a/drivers/net/virtio_net.c
> > +++ b/drivers/net/virtio_net.c
> > @@ -217,7 +217,8 @@ static void give_pages(struct receive_queue *rq, struct page *page)
> > struct page *end;
> >
> > /* Find end of list, sew whole thing into vi->rq.pages....