search for: f0f0ec49

...assumptions in the plugin that all requests are in-bounds. Note that > if the plugin gains a larger size, we merely never access the new tail > of the file (when the NBD protocol ever gains dynamic resize support, > we'll get to revisit how the retry filter fits in). > > Fixes: f0f0ec49 > Signed-off-by: Eric Blake <eblake@redhat.com> I'm inclined to say we should document that the retry filter only works with reasonable plugins and document those assumptions, but as you've written the code now let's go with this. Rich. > filters/retry/retry.c | 23 +++++...

...bug: could not recover after 5 retries The code is correct (there were six attempts, but that corresponds to 5 retries after the initial attempt; comments mention that retry=0 turns the filter into a no-op but even that requires an initial attempt). So all we need to adjust is the output. Fixes: f0f0ec49 Signed-off-by: Eric Blake <eblake@redhat.com> --- I'm pushing this in response to https://bugzilla.redhat.com/1819240 At the same time, I'm looking at whether qemu-img should be tweaked to have a mode where it gives up on the first EIO error, rather than plowing on through the rest o...

...ould result in violating assumptions in the plugin that all requests are in-bounds. Note that if the plugin gains a larger size, we merely never access the new tail of the file (when the NBD protocol ever gains dynamic resize support, we'll get to revisit how the retry filter fits in). Fixes: f0f0ec49 Signed-off-by: Eric Blake <eblake@redhat.com> --- filters/retry/retry.c | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/filters/retry/retry.c b/filters/retry/retry.c index 840d7383..cf8f5246 100644 --- a/filters/retry/retry.c +++ b/filters/retry/retry.c @@ -148,6...

...ies > > The code is correct (there were six attempts, but that corresponds to > 5 retries after the initial attempt; comments mention that retry=0 > turns the filter into a no-op but even that requires an initial > attempt). So all we need to adjust is the output. > > Fixes: f0f0ec49 > Signed-off-by: Eric Blake <eblake at redhat.com> > --- > > I'm pushing this in response to https://bugzilla.redhat.com/1819240 > At the same time, I'm looking at whether qemu-img should be tweaked > to have a mode where it gives up on the first EIO error, rather t...

I'm still working on another set of patches to have reopen call .finalize/.prepare (so that another filter can safely appear between retry and the plugin), but for tonight, these are the patches I think are ready to go. Eric Blake (4): retry: Handle can_fua and can_fast_zero changes tests: Test retry with different fua/fast-zero flags server: Close backends if a filter's .open fails

I still don't have .prepare/.finalize working cleanly across reopen, but did find a nasty bug where a botched assertion means we failed to notice reads beyond EOF in both the xz and retry filter. Refactoring backend.c will make .finalize work easier. Eric Blake (5): xz: Avoid reading beyond EOF retry: Check size before transactions tests: Test retry when get_size values change

Includes a rework of the previously posted patch for --run improvements (mostly with improved comments and commit message; I decided that waiting for the captive nbdkit to exit was overkill), and four new patches. The tests are intentionally separate, to allow rearranging the order of the series to see the failures being fixed. Eric Blake (6): server: Propagate unexpected nbdkit failure with

I think this is my last round of patches for issues I identified with the retry filter. With this in place, it should be safe to interject another filter in between retry and the plugin. Eric Blake (5): retry: Don't call into closed plugin tests: Refactor test-retry-reopen-fail.sh tests: Enhance retry test to cover failed reopen server: Move prepare/finalize/close recursion to