search for: extraterresti

...is: if (flag_copy_stdin && close (flag_copy_fd) == -1) { perror ("close"); return -1; } /* Get the exit status of the command. */ if (waitpid (pid, &r, 0) != pid) { perror ("waitpid"); return -1; } close() does not return an error unless extraterrestial circumstances occur, and even then the fd is no longer in use by the process. As such, I would argue checking for errors here is not necessary. Note that prior sample does not check. In case an error was returned, the code fails to waitpid() for the child. -- Mateusz Guzik

...return -1; > > } > > > > /* Get the exit status of the command. */ > > if (waitpid (pid, &r, 0) != pid) { > > perror ("waitpid"); > > return -1; > > } > > > > > > close() does not return an error unless extraterrestial circumstances occur, > > and even then the fd is no longer in use by the process. As such, I would argue > > checking for errors here is not necessary. Note that prior sample does not check. > > The code for flag_copy_stdin & flag_copy_fd is unrelated to the bit > quoted...

When running commands in the mounted guest (using the "command" API, and APIs based on it), provide the /dev/null from the appliance as open fd for stdin. Commands usually assume stdin is open if they didn't close it explicitly, so this should avoid crashes or misbehavings due to that. --- daemon/command.c | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-)

...= -1) { > perror ("close"); > return -1; > } > > /* Get the exit status of the command. */ > if (waitpid (pid, &r, 0) != pid) { > perror ("waitpid"); > return -1; > } > > > close() does not return an error unless extraterrestial circumstances occur, > and even then the fd is no longer in use by the process. As such, I would argue > checking for errors here is not necessary. Note that prior sample does not check. The code for flag_copy_stdin & flag_copy_fd is unrelated to the bit quoted above, see above for the...

...months 9412 FL Studio 7 installer fails to register Vorbis codec in system.ini 11621 putty.exe in telnet mode don't display anything 13313 Half life 2 hangs with a high cpu usage at a certain point in the game 14271 Inital size of scroll bar "thumb" incorrect 14847 UFO Extraterrestials: Problems with mouse cursor and textures. 15364 Build broken when CFLAGS="-Wall -Werror" is used 15460 blocky shadow-like model edges in Sid Meier's Pirates! 17021 CHM help menu only shows "Printer icons" 17582 Version/install test crashes on OpenSolaris 200...