search for: extra_javac_flag

...iably fix because you have to know somehow a magic path. For more details, see: https://blogs.oracle.com/darcy/entry/bootclasspath_older_source https://blogs.oracle.com/darcy/entry/how_to_cross_compile_for Anyway, remove the voodoo from configure.ac. As a side effect, this allows you to set the EXTRA_JAVAC_FLAGS environment variable before ./configure with any extra javac flags that you want. --- m4/guestfs_java.m4 | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/m4/guestfs_java.m4 b/m4/guestfs_java.m4 index 649e21f..82cdc40 100644 --- a/m4/guestfs_java.m4 +++ b/m4/guestfs_java.m4 @@ -123,1...

This commit starts to split our massive, monolithic configure.ac file into smaller files, using the m4_include mechanism to combine them. I don't know if we should really do this, so I'm open to comments about it. However: - Our configure.ac script is 1800+ lines long, and that's pretty long. - configure.ac lacks structure; splitting it up might improve that. - From what I read,

...le.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/java/Makefile.am b/java/Makefile.am > index fa5b45c..a76a9d1 100644 > --- a/java/Makefile.am > +++ b/java/Makefile.am > @@ -68,7 +68,7 @@ clean-local: > if HAVE_JAVA > > JAVAC_FLAGS = $(EXTRA_JAVAC_FLAGS) -encoding utf-8 > -JAVADOC_FLAGS = -encoding utf-8 > +JAVADOC_FLAGS = -encoding utf-8 -Xdoclint:none I'd say it would be much better to fix the issues doclint issues, if possible, rather than disabling all of them. -- Pino Toscano

...java/Makefile.am | 11 +++++++++++ m4/guestfs-java.m4 | 5 ++--- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/java/Makefile.am b/java/Makefile.am index 376d89d17..81c20f266 100644 --- a/java/Makefile.am +++ b/java/Makefile.am @@ -77,6 +77,9 @@ if HAVE_JAVA JAVAC_FLAGS = $(EXTRA_JAVAC_FLAGS) -encoding utf-8 JAVADOC_FLAGS = -encoding utf-8 +if !HAVE_JAVAH +JAVAC_FLAGS += -h . +endif # Java source. @@ -125,10 +128,18 @@ libguestfs_jni_la_LDFLAGS = -version-info $(JNI_VERSION_INFO) -shared BUILT_SOURCES = com_redhat_et_libguestfs_GuestFS.h +if HAVE_JAVAH + com_redhat_et_libg...

>From Apple's xdr.h: "If your code invokes an xdrproc_t callback, it must be modified to pass a third parameter, which may simply be zero." --- src/proto.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/proto.c b/src/proto.c index 92ae84d..57f4882 100644 --- a/src/proto.c +++ b/src/proto.c @@ -252,7 +252,12 @@ guestfs___send (guestfs_h *g, int proc_nr, *

...off-doclint-in-jdk-8-javadoc.html --- java/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/java/Makefile.am b/java/Makefile.am index fa5b45c..a76a9d1 100644 --- a/java/Makefile.am +++ b/java/Makefile.am @@ -68,7 +68,7 @@ clean-local: if HAVE_JAVA JAVAC_FLAGS = $(EXTRA_JAVAC_FLAGS) -encoding utf-8 -JAVADOC_FLAGS = -encoding utf-8 +JAVADOC_FLAGS = -encoding utf-8 -Xdoclint:none # Java source. -- 1.9.3

Two (not related to each other) refactorings: Patches 1-12 split configure.ac into smaller files using the m4_include mechanism. Patches 13-15 split out parts of guestfs.pod (ie. guestfs(3)) into three new manual pages: guestfs-hacking(3) - how to extend and contribute to libguestfs guestfs-internals(3) - architecture and internals guestfs-security(3) - security and CVEs Patch 16 is a

...ity. The "RHEV-APT" utility is only installed when the output hypervisor is oVirt or RHV. A problem with virt-v2v running out of memory when doing an SELinux relabel of the guest filesystem should now be resolved. Language bindings Setting "EXTRA_JAVAC_FLAGS" before ./configure allows you to add arbitrary flags to "javac" when compiling the Java bindings. Use of any libguestfs API which returned a single struct, from Perl or Java bindings, would have leaked memory. This has now been fixed (Pino Toscano)....