search for: external_functions

By splitting up large C files we can make parallel compiles a bit faster. Rich.

...true + +let is_documented = + fun x -> match x.visibility with + | VPublic | VStateTest -> true + | VBindTest | VDebug | VInternal -> false + +let is_fish = + fun x -> match x.visibility with + | VPublic | VDebug -> true + | VStateTest | VBindTest | VInternal -> false + let external_functions = - List.filter (fun x -> not x.internal) all_functions + List.filter is_external all_functions let internal_functions = - List.filter (fun x -> x.internal) all_functions + List.filter is_internal all_functions + +let documented_functions = + List.filter is_documented all_functions +...

..._TUPLE_ELEMENT(args_tuple,(i)+1)) "; @@ -229,7 +229,7 @@ extern int64_t get_int64 (ETERM *term); List.iter ( fun { name = name } -> - pr "ETERM *run_%s (ETERM *message);\n" name + pr "ETERM *run_%s (ETERM *args_tuple);\n" name ) (actions |> external_functions |> sort); pr "\n"; @@ -355,7 +355,7 @@ instead of erl_interface. c_function = c_function; c_optarg_prefix = c_optarg_prefix } -> pr "\n"; pr "ETERM *\n"; - pr "run_%s (ETERM *message)\n" name; + pr "run_%s (E...

Hello. We found the following problem with MC JIT, on ARM it can't generate valid code for instruction "bl <external_function>" like: bl printf Because the ELF file in memory generated by MC JIT does not have the .plt section, but we need to have the following code to be emitted in it: .plt:00008290 STR LR, [SP,#-4]! .plt:00008294

...pr "}\n" ) external_structs; + + (* generate structs for optional arguments *) List.iter ( fun ({ name = name; shortdesc = shortdesc; style = (ret, args, optargs) }) -> @@ -275,3 +295,120 @@ impl UUID { pr "}\n\n"; ); ) (actions |> external_functions |> sort); + + pr "impl Handle {\n"; + List.iter ( + fun ({ name = name; shortdesc = shortdesc; + style = (ret, args, optargs) } as f) -> + let cname = snake2caml name in + pr " /// %s \n" shortdesc; + pr " pub fn %s" name; + +...

...uot; bitmask,\n"; + pr " }\n"; + pr " }\n"; + pr "}\n"; + pr "impl OptArgs%s {\n" cname; List.iter ( fun optarg -> @@ -296,6 +431,54 @@ impl UUID { ); ) (actions |> external_functions |> sort); + (* extern C APIs *) + pr "extern \"C\" {\n"; + List.iter ( + fun ({ name = name; shortdesc = shortdesc; + style = (ret, args, optargs) } as f) -> + let cname = snake2caml name in + pr "fn %s(g: *const guestfs_h" f.c_function...

...r_type i arg; - pr ",\n" - ) (args_of_optargs optargs); - pr " },\n"; - ); - pr " name => \"%s\",\n" name; - pr " description => %S,\n" shortdesc; - pr " },\n"; - ) (actions |> external_functions |> sort); - pr ");\n\n"; - - pr "# Add aliases to the introspection hash.\n"; - let i = ref 0 in - List.iter ( - fun { name = name; non_c_aliases = non_c_aliases } -> - List.iter ( - fun alias -> - pr "my %%ielem%d = %%{$guestfs_introspe...

...e; in_docs = false; internal = true; tests = []; shortdesc = "internal hotplugging operation"; longdesc = "\ @@ -11054,11 +11054,23 @@ let non_daemon_functions, daemon_functions = (* All functions. *) let all_functions = non_daemon_functions @ daemon_functions +let external_functions = + List.filter (fun x -> not x.internal) all_functions + +let internal_functions = + List.filter (fun x -> x.internal) all_functions + (* In some places we want the functions to be displayed sorted * alphabetically, so this is useful: *) let all_functions_sorted = List.sort action_co...

...@@ -680,7 +680,7 @@ gboolean guestfs_session_close (GuestfsSession *session, GError **err); "; List.iter ( - fun ({ name = name; style = style } as f) -> + fun ({ name; style } as f) -> generate_gobject_proto name style f; pr ";\n"; ) (actions |> external_functions |> sort); @@ -936,11 +936,10 @@ guestfs_session_close (GuestfsSession *session, GError **err) let literal = Str.regexp "\\(^\\|\n\\)[ \t]+\\([^\n]*\\)\\(\n\\|$\\)" in List.iter ( - fun ({ name = name; style = (ret, args, optargs as style); - cancellable = cancellab...

...;Vec<String>" + ); + pr ") -> OptArgs%s {\n" cname; + pr " OptArgs%s { _%s: Some(%s), ..self }\n" cname n n; + pr " }\n" + ) optargs; + pr "}\n\n"; + ); + ) (actions |> external_functions |> sort); -- 2.20.1 (Apple Git-117)

...ucts; List.iter ( @@ -229,7 +229,7 @@ extern int64_t get_int64 (ETERM *term); List.iter ( fun { name } -> - pr "ETERM *run_%s (ETERM *args_tuple);\n" name + pr "int run_%s (ei_x_buff *retbuff, const char *buff, int *index);\n" name ) (actions |> external_functions |> sort); pr "\n"; @@ -247,11 +247,7 @@ and generate_erlang_structs () = #include <string.h> #include <errno.h> -#include <erl_interface.h> -/* We should switch over to using - #include <ei.h> -instead of erl_interface. -*/ +#include <ei.h> #i...

Per my previous email: https://www.redhat.com/archives/libguestfs/2017-September/msg00203.html I'd like to talk about requiring a more modern version of the OCaml compiler. These commits show some of the code changes which would be possible with OCaml >= 3.12 [which it turns out we already require by accident] and also with OCaml >= 4.02. The latter is my favoured option. Rich.

From: Hiroyuki_Katsura <hiroyuki.katsura.0513@gmail.com> --- Makefile.am | 4 ++++ configure.ac | 3 +++ generator/Makefile.am | 3 +++ generator/bindtests.ml | 3 +++ generator/bindtests.mli | 1 + generator/main.ml | 5 +++++ generator/rust.ml | 34 ++++++++++++++++++++++++++++++++++ generator/rust.mli | 19 +++++++++++++++++++

I fixed the patch I submitted before based on comments, and there are some commits which are merged or divided. So, I will re-send all the patches. Regards, Hiroyuki Katsura

...pr " ptr::null()\n"; + pr " },\n"; + ) optargs; + pr " bitmask,\n"; + pr " }\n"; + pr " }\n"; + pr "}\n"; + ); + ) (actions |> external_functions |> sort); + + (* extern C APIs *) + pr "extern \"C\" {\n"; + List.iter ( + fun ({ name = name; shortdesc = shortdesc; + style = (ret, args, optargs) } as f) -> + let cname = snake2caml name in + pr " #[allow(non_snake_case)]\n"; +...

...null()\n"; > + pr " },\n"; > + ) optargs; > + pr " bitmask,\n"; > + pr " }\n"; > + pr " }\n"; > + pr "}\n"; > + ); > + ) (actions |> external_functions |> sort); > + > + (* extern C APIs *) > + pr "extern \"C\" {\n"; > + List.iter ( > + fun ({ name = name; shortdesc = shortdesc; > + style = (ret, args, optargs) } as f) -> > + let cname = snake2caml name in > + pr "...

...pr " ptr::null()\n"; + pr " },\n"; + ) optargs; + pr " bitmask,\n"; + pr " }\n"; + pr " }\n"; + pr "}\n"; + ); + ) (actions |> external_functions |> sort); + + (* extern C APIs *) + pr "extern \"C\" {\n"; + List.iter ( + fun ({ name = name; shortdesc = shortdesc; + style = (ret, args, optargs) } as f) -> + let cname = snake2caml name in + pr " #[allow(non_snake_case)]\n"; +...

Fixes the majority of the pycodestyle issues in the Python bindings, leaving only an overly length line in setup.py. Add a simple optional pycodestyle-based test to avoid regressions in the future. Pino Toscano (7): python: PEP 8: adapt empty lines python: PEP 8: adapt whitespaces in lines python: tests: catch specific exception python: tests: improve variable naming python: tests:

> Is this just trying if the guestfs can be linked with? Yes. In OCaml bindings, there is the corresponding test( https://github.com/libguestfs/libguestfs/blob/master/ocaml/t/guestfs_010_load.ml). I just mimicked it. If it is not required, I will remove it. divided the generated files and handmade files in rust/src/ directory. I'll send this fixed patch to this mailing list. I'm not

On Mon, Jul 08, 2019 at 10:04:57AM +0100, Richard W.M. Jones wrote: >On Mon, Jul 08, 2019 at 10:49:55AM +0200, Martin Kletzander wrote: >> On Mon, Jul 08, 2019 at 10:10:10AM +0200, Pino Toscano wrote: >> >On Saturday, 6 July 2019 13:03:24 CEST Martin Kletzander wrote: >> >>Just one thing, the Cargo.toml includes a version under which the crate would be >>