search for: extentlist

...s after the point where .config_complete may have altered it, and before any connections are permitted. Signed-off-by: Eric Blake <eblake@redhat.com> --- docs/nbdkit-filter.pod | 9 ++++++++- include/nbdkit-filter.h | 3 ++- server/filters.c | 4 ++-- filters/extentlist/extentlist.c | 3 ++- filters/log/log.c | 2 +- filters/rate/rate.c | 2 +- filters/stats/stats.c | 2 +- tests/test-layers-filter.c | 2 +- 8 files changed, 18 insertions(+), 9 deletions(-) diff --git a/docs/nbdkit-filter.pod b/docs/nbdkit-filter.pod index...

...may have altered it, and > before any connections are permitted. > > Signed-off-by: Eric Blake <eblake@redhat.com> > --- > docs/nbdkit-filter.pod | 9 ++++++++- > include/nbdkit-filter.h | 3 ++- > server/filters.c | 4 ++-- > filters/extentlist/extentlist.c | 3 ++- > filters/log/log.c | 2 +- > filters/rate/rate.c | 2 +- > filters/stats/stats.c | 2 +- > tests/test-layers-filter.c | 2 +- > 8 files changed, 18 insertions(+), 9 deletions(-) This is fine. Is this something that we...

...1,6 @@ General ideas for improvements * common/utils/vector.h could be extended and used in other places: - there are some more possible places in the server (anywhere using realloc is suspect) - - nbdkit-vddk-plugin, where it builds the new argv - allow insertion, and use it in nbdkit-extentlist-filter - allow insertion and keep sorted, use it in nbdkit-eval-plugin - same, and use it in common/sparse/sparse.c -- 2.25.0

This extends the vector library with an insert function. It is more expensive than appending, but this does not affect existing code using vector and can be used in new places without making those uses more expensive. We use this function in nbdkit-extentlist-filter, nbdkit-eval-plugin and the sparse library. This is refactoring, so should not affect functionality at all. However during the rewrite of eval it revealed a fencepost error in the loop iterating over method_scripts which is fixed here. --- common/sparse/Makefile.am | 1 + common/ut...

...ervers advertise initialization state to the client: whether the image contains holes, and whether it is known to read as all zeroes. Most filters just pass through the plugin's result (as it is only checked once when first connecting), but we can do useful things in log (mention the setting), extentlist (answer based on the extents we are advertising), noextents (suppress the advertisement), and truncate (advertise sparse support for our added tail hole). Expand a comment in the cache filter about potential future enchnancements. Initial read-only zero status is easy to add through the extentlis...

...W.M. Jones wrote: > This extends the vector library with an insert function. It is more > expensive than appending, but this does not affect existing code using > vector and can be used in new places without making those uses more > expensive. > > We use this function in nbdkit-extentlist-filter, nbdkit-eval-plugin > and the sparse library. > > This is refactoring, so should not affect functionality at all. > However during the rewrite of eval it revealed a fencepost error in > the loop iterating over method_scripts which is fixed here. > --- > common/sparse/...

...| 14 +- server/public.c | 16 ++ plugins/sh/methods.c | 1 + filters/cow/cow.c | 2 +- filters/exitlast/exitlast.c | 2 +- filters/ext2/ext2.c | 2 +- filters/extentlist/extentlist.c | 3 +- filters/gzip/gzip.c | 2 +- filters/limit/limit.c | 2 +- filters/log/log.c | 18 +- filters/partition/partition.c | 2 +- filters/rate/rate.c |...

...overlays > +bad blocks according to a GNU L<ddrescue(1)> mapfile. This is mainly useful > +for testing disk images recovered with ddrescue, to detect which files > +or filesystem structures are impacted, or attempting fsck on them. Oh cool, this sounds very similar to the existing extentlist plugin, but with a difference that extentlist uses the input to decide which portions of the file are advertised as sparse, while this one uses which portions of the file cause EIO errors during read. Is it worth trying to combine the two concepts into one filter, or do we want to keep it ort...

This allows to overlay bad sectors according to the mapfile generated by ddrescue, to then see where sectors are used using fsck and trying to copy files around. Signed-off-by: Fran?ois Revol <revol at free.fr> --- configure.ac | 2 + filters/ddrescue/Makefile.am | 75 +++++++ filters/ddrescue/ddrescue.c | 211

...before any connections are permitted. >> >> Signed-off-by: Eric Blake <eblake@redhat.com> >> --- >> docs/nbdkit-filter.pod | 9 ++++++++- >> include/nbdkit-filter.h | 3 ++- >> server/filters.c | 4 ++-- >> filters/extentlist/extentlist.c | 3 ++- >> filters/log/log.c | 2 +- >> filters/rate/rate.c | 2 +- >> filters/stats/stats.c | 2 +- >> tests/test-layers-filter.c | 2 +- >> 8 files changed, 18 insertions(+), 9 deletions(-) > > This i...

...+- common/sparse/sparse.c | 30 ++++++- common/sparse/sparse.h | 19 ++++- docs/nbdkit-filter.pod | 10 ++- docs/nbdkit-plugin.pod | 23 ++++++ filters/cache/blk.c | 7 +- filters/extentlist/extentlist.c | 28 +++++++ filters/log/log.c | 9 +- filters/log/nbdkit-log-filter.pod | 2 +- filters/noextents/nbdkit-noextents-filter.pod | 11 +-- filters/noextents/noextents.c | 18 +++- filters/truncate/truncate.c...

...bdkit-filter(3)>, L<iptables(8)>, L<tc(8)>. diff --git a/configure.ac b/configure.ac index 0b7d8b7c..0b980238 100644 --- a/configure.ac +++ b/configure.ac @@ -97,6 +97,7 @@ filters="\ cow \ delay \ error \ + exitlast \ ext2 \ extentlist \ fua \ @@ -267,6 +268,7 @@ AC_CHECK_HEADERS([\ alloca.h \ byteswap.h \ endian.h \ + stdatomic.h \ sys/endian.h \ sys/mman.h \ sys/prctl.h \ @@ -1022,6 +1024,7 @@ AC_CONFIG_FILES([Makefile filters/cow/Makefile filters/delay/Makefile...

...rmitted. > >> > >>Signed-off-by: Eric Blake <eblake@redhat.com> > >>--- > >> docs/nbdkit-filter.pod | 9 ++++++++- > >> include/nbdkit-filter.h | 3 ++- > >> server/filters.c | 4 ++-- > >> filters/extentlist/extentlist.c | 3 ++- > >> filters/log/log.c | 2 +- > >> filters/rate/rate.c | 2 +- > >> filters/stats/stats.c | 2 +- > >> tests/test-layers-filter.c | 2 +- > >> 8 files changed, 18 insertions(+), 9 deletions(...

...ilter. + +Use C<nbdkit --dump-config> to find the location of C<$filterdir>. + +=back + +=head1 VERSION + +C<nbdkit-exportname-filter> first appeared in nbdkit 1.22. + +=head1 SEE ALSO + +L<nbdkit(1)>, +L<nbdkit-filter(3)>, +L<nbdkit-ext2-filter(1)>, +L<nbdkit-extentlist-filter(1)>, +L<nbdkit-fua-filter(1)>, +L<nbdkit-nocache-filter(1)>, +L<nbdkit-noparallel-filter(1)>, +L<nbdkit-nozero-filter(1)>, +L<nbdkit-file-plugin(1)>, +L<nbdkit-info-plugin(1)>. + +=head1 AUTHORS + +Eric Blake + +=head1 COPYRIGHT + +Copyright (C) 2020 Re...

...of C<$filterdir>. > + > +=back > + > +=head1 VERSION > + > +C<nbdkit-exportname-filter> first appeared in nbdkit 1.22. > + > +=head1 SEE ALSO > + > +L<nbdkit(1)>, > +L<nbdkit-filter(3)>, > +L<nbdkit-ext2-filter(1)>, > +L<nbdkit-extentlist-filter(1)>, > +L<nbdkit-fua-filter(1)>, > +L<nbdkit-nocache-filter(1)>, > +L<nbdkit-noparallel-filter(1)>, > +L<nbdkit-nozero-filter(1)>, > +L<nbdkit-file-plugin(1)>, > +L<nbdkit-info-plugin(1)>. > + > +=head1 AUTHORS > + > +Eric...

I will be following up to this email with four separate threads each addressed to the appropriate single list, with proposed changes to: - the NBD protocol - qemu: both server and client - libnbd: client - nbdkit: server The feature in question adds a new optional NBD_INFO_ packet to the NBD_OPT_GO portion of handshake, adding up to 16 bits of information that the server can advertise to the

...ilters/cacheextents/Makefile.am | 1 + filters/cow/Makefile.am | 1 + filters/ddrescue/Makefile.am | 1 + filters/delay/Makefile.am | 3 +++ filters/error/Makefile.am | 1 + filters/exitlast/Makefile.am | 3 +++ filters/ext2/Makefile.am | 3 ++- filters/extentlist/Makefile.am | 1 + filters/fua/Makefile.am | 3 +++ filters/gzip/Makefile.am | 1 + filters/ip/Makefile.am | 1 + filters/limit/Makefile.am | 1 + filters/log/Makefile.am | 1 + filters/nocache/Makefile.am | 3 +++ filters/noextents/Makefile....

Here's changes to the file plugin (which I'm happy with) and a new exportname filter (which is still at RFC stage; I need to finish implementing strict mode in .open, and add tests). I also discovered that we really want .list_exports and .open to know when they are used on plaintext vs. tls clients for --tls=on, and we may want to split out a new .default_export callback rather than

This adds a new nbdkit_shutdown() API whereby plugins and filters can request that the server shuts down (asynchronously) during the serving phase. Two new filters are added, one of which depends on this feature and the other not needing it but being somewhat related. Rich.

...https://gitlab.com/akihe/radamsa +* common/include/vector.h could be extended and used in other places: + - there are some more possible places in the server (anywhere using + realloc is suspect) + - nbdkit-vddk-plugin, where it builds the new argv + - allow insertion, and use it in nbdkit-extentlist-filter + - allow insertion and keep sorted, use it in nbdkit-eval-plugin + - same, and use it in common/sparse/sparse.c + Suggestions for plugins ----------------------- -- 2.25.0