search for: ext3_journal_get_write_access

[Re-sending to the ext3 list, with minor edits] I'm in the process of fixing errors generated by the Coverity tool on the Linux kernel, and I would like your comment on a set of problems reported in ext3. The main issue reported is not checking the return code of ext3_journal_get_write_access() in various places. I would like to know if there should be error handling in these cases. The places where the return value is not checked are(in the current kernel version): fs/ext3/inode.c ext3_clear_blocks 1829 fs/ext3/namei.c ext3_append 63...

Hi, why is there a window between statements "err = ext3_journal_get_write_access(handle, this_bh);" and "ext3_journal_dirty_metadata(handle, this_bh);" ? In my test, there is an error in journal_dirty_metadata: jh is null thanks! D.Yang April 1, 2004 ---------------------------------------------------------------------------------------------------------------...

...and t1,0x2,t0 fffffc0000883f5c: 03 00 20 e4 beq t0,fffffc0000883f6c <ext3_bmap+0x3c> fffffc0000883f60: 02 58 40 44 xor t1,0x2,t1 fffffc0000883f64: 2e 02 43 b8 stl_c t1,558(t2) fffffc0000883f68: 58 09 40 e4 beq t1,fffffc00008864cc <ext3_journal_get_write_access+0x5c> fffffc0000883f6c: 10 00 20 e4 beq t0,fffffc0000883fb0 <ext3_bmap+0x80> fffffc0000883f70: 00 01 23 a4 ldq t0,256(t2) fffffc0000883f74: f0 02 01 a6 ldq a0,752(t0) fffffc0000883f78: 08 a1 7d a7 ldq t12,-24312(gp) [...] The ldl_l ....

Hello, I have today released an initial version of extended attributes and access control lists for ext3 (patch against the 2.4.13-ac3 kernel). Eric Jarman <ejarman@acm.org> has contributed a lot to this effort. Since I'm not very much into the innards of ext3, can some of you please take a look at the patch, and see whether it contains any flaws (and tell me which flaws)? Thanks! The