search for: ext2initrd

...n do what I'm guessing it was intended to do. As is, it was a no-op. >From 7c2ff55613598a1295e213cef36600ad61da7ed6 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Tue, 10 Jan 2012 16:55:49 +0100 Subject: [PATCH 1/2] helper: plug three small leaks * helper/ext2initrd.c (read_module_deps): Don't leak filename. (ext2_make_initrd): Don't leak "outfile". * helper/utils.c (load_file): Don't leak a file pointer. --- helper/ext2initrd.c | 4 +++- helper/utils.c | 3 ++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/he...

--- configure.ac | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index da03c9f..7606bca 100644 --- a/configure.ac +++ b/configure.ac @@ -68,7 +68,8 @@ dnl For ArchLinux handler. AC_CHECK_PROG(PACMAN,[pacman],[pacman],[no]) dnl Required programs, libraries. -AC_PATH_PROG([INSMODSTATIC],[insmod.static],[no])

From: Chen Hanxiao <chenhanxiao@gmail.com> ext2initrd.c belongs to supermin4. Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com> --- init/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/init/init.c b/init/init.c index 5ac53e9..fa9460d 100644 --- a/init/init.c +++ b/init/init.c @@ -138,7 +138,7 @@ main () /* XXX...

--- helper/init.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/helper/init.c b/helper/init.c index 0ca3135..2b5dacf 100644 --- a/helper/init.c +++ b/helper/init.c @@ -163,8 +163,10 @@ main () chdir ("/"); - /* Run /init from ext2 filesystem. */ + mount_proc (); print_uptime (); + + /* Run /init from ext2 filesystem. */ execl

...-o febootstrap_supermin_helper-ext2cpio.o `test -f 'ext2cpio.c' || echo './'`ext2cpio.c mv -f .deps/febootstrap_supermin_helper-ext2cpio.Tpo .deps/febootstrap_supermin_helper-ext2cpio.Po gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I.. -Wall -I../lib -g -O2 -MT febootstrap_supermin_helper-ext2initrd.o -MD -MP -MF .deps/febootstrap_supermin_helper-ext2initrd.Tpo -c -o febootstrap_supermin_helper-ext2initrd.o `test -f 'ext2initrd.c' || echo './'`ext2initrd.c ext2initrd.c: In function ???ext2_make_initrd???: ext2initrd.c:183:10: warning: ignoring return value of ???system???, decl...

...-o febootstrap_supermin_helper-ext2cpio.o `test -f 'ext2cpio.c' || echo './'`ext2cpio.c mv -f .deps/febootstrap_supermin_helper-ext2cpio.Tpo .deps/febootstrap_supermin_helper-ext2cpio.Po gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I.. -Wall -I../lib -g -O2 -MT febootstrap_supermin_helper-ext2initrd.o -MD -MP -MF .deps/febootstrap_supermin_helper-ext2initrd.Tpo -c -o febootstrap_supermin_helper-ext2initrd.o `test -f 'ext2initrd.c' || echo './'`ext2initrd.c mv -f .deps/febootstrap_supermin_helper-ext2initrd.Tpo .deps/febootstrap_supermin_helper-ext2initrd.Po gcc -std=gnu99 -DHAV...

...t; edwin> [Wed 19:31] another problem is that the guest can't find cdrom.ko, but I do a drivers/cdrom/cdrom.ko module on the host < edwin> [Wed 19:49] looks like the initrd that is built doesn't contain cdrom.ko... < edwin> [Wed 20:04] febootstrap's helper/ext2initrd.c lacks cdrom.ko Seems to be a bug in febootstrap, also noted, will try to fix. < edwin> [Wed 20:14] ok now I lack the ext2 module in my custom kernel < edwin> [Wed 20:26] hmm now I have ext2.ko, but it still says febootstrap: no ext2 root device found < edwin> [Wed 20:26] what...

...-o febootstrap_supermin_helper-ext2cpio.o `test -f 'ext2cpio.c' || echo './'`ext2cpio.c mv -f .deps/febootstrap_supermin_helper-ext2cpio.Tpo .deps/febootstrap_supermin_helper-ext2cpio.Po gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I.. -Wall -I../lib -g -O2 -MT febootstrap_supermin_helper-ext2initrd.o -MD -MP -MF .deps/febootstrap_supermin_helper-ext2initrd.Tpo -c -o febootstrap_supermin_helper-ext2initrd.o `test -f 'ext2initrd.c' || echo './'`ext2initrd.c mv -f .deps/febootstrap_supermin_helper-ext2initrd.Tpo .deps/febootstrap_supermin_helper-ext2initrd.Po gcc -std=gnu99 -DHAV...

...ng directory `/home/rjones/d/febootstrap/lib' make[2]: Leaving directory `/home/rjones/d/febootstrap/lib' Making all in helper make[2]: Entering directory `/home/rjones/d/febootstrap/helper' gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I.. -Wall -I../lib -g -O2 -MT febootstrap_supermin_helper-ext2initrd.o -MD -MP -MF .deps/febootstrap_supermin_helper-ext2initrd.Tpo -c -o febootstrap_supermin_helper-ext2initrd.o `test -f 'ext2initrd.c' || echo './'`ext2initrd.c mv -f .deps/febootstrap_supermin_helper-ext2initrd.Tpo .deps/febootstrap_supermin_helper-ext2initrd.Po gcc -std=gnu99 -DHAV...

v1 -> v2: - If we split out the init program into a separate init/ directory, that makes it much easier to build against an alternate libc. I tried to build against uClibc, but uClibc requires an entire build chain, which looked like it was going to be a massive ballache. Rich.

...helper/bin2s.pl | 45 --- helper/checksum.c | 119 ------- helper/cpio.c | 279 ---------------- helper/ext2.c | 538 ------------------------------- helper/ext2cpio.c | 418 ------------------------ helper/ext2initrd.c | 281 ---------------- helper/ext2internal.h | 45 --- helper/helper.h | 85 ----- helper/init.c | 537 ------------------------------- helper/kernel.c | 454 -------------------------- helper/main.c...

...per-kernel.Po gcc -std=gnu99 -Wall -I../lib -g -O2 -o febootstrap-supermin-helper febootstrap_supermin_helper-appliance.o febootstrap_supermin_helper-checksum.o febootstrap_supermin_helper-cpio.o febootstrap_supermin_helper-ext2.o febootstrap_supermin_helper-ext2cpio.o febootstrap_supermin_helper-ext2initrd.o febootstrap_supermin_helper-kernel.o febootstrap_supermin_helper-main.o febootstrap_supermin_helper-utils.o ext2init.o -lext2fs -lcom_err -L../lib -lgnu make[2]: Leaving directory `/home/rjones/d/febootstrap/helper' make[2]: Entering directory `/home/rjones/d/febootstrap' ocamlfind ocam...

...per-kernel.Po gcc -std=gnu99 -Wall -I../lib -g -O2 -o febootstrap-supermin-helper febootstrap_supermin_helper-appliance.o febootstrap_supermin_helper-checksum.o febootstrap_supermin_helper-cpio.o febootstrap_supermin_helper-ext2.o febootstrap_supermin_helper-ext2cpio.o febootstrap_supermin_helper-ext2initrd.o febootstrap_supermin_helper-kernel.o febootstrap_supermin_helper-main.o febootstrap_supermin_helper-utils.o ext2init.o -lext2fs -lcom_err -L../lib -lgnu make[2]: Leaving directory `/home/rjones/d/febootstrap/helper' make[2]: Entering directory `/home/rjones/d/febootstrap' ocamlfind ocam...