search for: ext2_open

Applies on top of my pending series for the exportname filter, addressing one of the todo's in that cover letter. Eric Blake (2): filters: Add .export_description wrappers ext2: Supply .list_exports and .default_export filters/ext2/nbdkit-ext2-filter.pod | 3 +- tests/Makefile.am | 16 +++- filters/ext2/ext2.c | 125 +++++++++++++++++++---------

...knob to add. + */ + if (file) + return NULL; + + /* Otherwise, we don't care about export name, so keeping things at + * "" is fine, regardless of the underlying plugin's default. + */ + return ""; +} + /* Create the per-connection handle. */ static void * ext2_open (nbdkit_next_open *next, void *nxdata, @@ -133,9 +164,8 @@ ext2_open (nbdkit_next_open *next, void *nxdata, } /* Save the client exportname in the handle. */ - h->exportname = strdup (exportname); + h->exportname = nbdkit_strdup_intern (exportname); if (h->exportname == NULL) {...

...s fs; /* Filesystem handle. */ ext2_ino_t ino; /* Inode of open file. */ ext2_file_t file; /* File handle. */ + struct nbdkit_next next; /* "name" parameter to ext2fs_open. */ }; /* Create the per-connection handle. */ static void * -ext2_open (int readonly) +ext2_open (nbdkit_next_open *next, void *nxdata, int readonly) { struct handle *h; + + /* Request write access to the underlying plugin, for journal replay. */ + if (next (nxdata, 0) == -1) + return NULL; + + h = calloc (1, sizeof *h); + if (h == NULL) { + nbdkit_error...

...ation may have a glitch if compiled under a different locale than the end binary runs in, but these days, it's uncommon to find someone running in a single-byte locale instead of UTF-8. > +++ b/filters/ext2/ext2.c > /* Create the per-connection handle. */ > static void * > -ext2_open (nbdkit_next_open *next, void *nxdata, int readonly) > +ext2_open (nbdkit_next_open *next, void *nxdata, > + int readonly, const char *exportname) > + > + /* If file == NULL (ie. using exportname) then don't > + * pass the client exportname to the lower layers. >...

...= "nbdkit ext2 filter", - .load = ext2_load, - .unload = ext2_unload, - .config = ext2_config, - .config_complete = ext2_config_complete, - .config_help = ext2_config_help, - .thread_model = ext2_thread_model, - .open = ext2_open, - .prepare = ext2_prepare, - .close = ext2_close, - .can_fua = ext2_can_fua, - .can_cache = ext2_can_cache, - .get_size = ext2_get_size, - .pread = ext2_pread, - .pwrite = ext2_pwrite, - .flush = ext2_flush...

...> - .load = ext2_load, > - .unload = ext2_unload, > - .config = ext2_config, > - .config_complete = ext2_config_complete, > - .config_help = ext2_config_help, > - .thread_model = ext2_thread_model, > - .open = ext2_open, > - .prepare = ext2_prepare, > - .close = ext2_close, > - .can_fua = ext2_can_fua, > - .can_cache = ext2_can_cache, > - .get_size = ext2_get_size, > - .pread = ext2_pread, > - .pwrite = ext2_pwrite,...

There is a small test provided. I tested this a lot more locally and it seems pretty robust. Rich.

.../* Client export name. */ ext2_filsys fs; /* Filesystem handle. */ ext2_ino_t ino; /* Inode of open file. */ ext2_file_t file; /* File handle. */ @@ -120,20 +121,37 @@ struct handle { /* Create the per-connection handle. */ static void * -ext2_open (nbdkit_next_open *next, void *nxdata, int readonly) +ext2_open (nbdkit_next_open *next, void *nxdata, + int readonly, const char *exportname) { struct handle *h; - /* Request write access to the underlying plugin, for journal replay. */ - if (next (nxdata, 0) == -1) - return N...

...xt2fs_get_next_inode: %s\n", error_message(err)); - return -1; - } - ret = btrfs_commit_transaction(trans, root); - BUG_ON(ret); - - return ret; -} /* * Construct a range of the image file. @@ -2586,26 +1805,6 @@ static int copy_dirtiness(struct extent_io_tree *out, return 0; } -int ext2_open(struct convert_fs *fs, const char *name) -{ - int ret; - ext2_filsys ext2_fs; - ret = open_ext2fs(name, &ext2_fs); - if (ret) - return ret; - - fs->privdata = ext2_fs; - fs->blocksize = ext2_fs->blocksize; - fs->label = ext2_fs->super->s_volume_name; - fs->total_bytes = ex...

...y much appreciated. I'd just finished running lvm lvextend. "lvextend -L+L1G /dev/VolGroup00/LogVol00", after adding a new 1G partition (/dev/sda4) to /dev/VolGroup00. [root at ppstest13 ~]# ext2online -d -v /dev/VolGroup00/LogVol00 ext2online v1.1.18 - 2001/03/18 for EXT2FS 0.5b ext2_open ext2_bcache_init new filesystem size 925696 ext2_determine_itoffset setting itoffset to +165 group 2 inode table has offset 2, not 165 group 4 inode table has offset 2, not 165 group 6 inode table has offset 2, not 165 group 8 inode table has offset 2, not 165 group 10 inode table has offset 2, not...

Hi. I'm attempting to setup a box here to be a file-server for all my data. I'm attempting to resize an ext3 partition to demonstrate this capability to myself before fully committing to this system as the primary data storage. I'm having some problems resizing an ext3 filesystem after I've resized the underlying logical volume. Following the ext3 resize, fsck spits out lots

...if (next (nxdata, readonly, exportname) == -1) return NULL; diff --git a/filters/ext2/ext2.c b/filters/ext2/ext2.c index 72b7ac9f..75ac2c4c 100644 --- a/filters/ext2/ext2.c +++ b/filters/ext2/ext2.c @@ -122,7 +122,7 @@ struct handle { /* Create the per-connection handle. */ static void * ext2_open (nbdkit_next_open *next, void *nxdata, - int readonly, const char *exportname) + int readonly, const char *exportname, int is_tls) { struct handle *h; diff --git a/filters/gzip/gzip.c b/filters/gzip/gzip.c index 8323b882..d92e00d9 100644 --- a/filters/gzip/gzip.c +++ b/filt...

It's been several weeks since I posted v2 (I got distracted by improving libnbd to better test things, which in turn surfaced some major memory leak problems in nbdsh that are now fixed). Many of the patches are minor rebases from v2, with the biggest changes being fallout from: - patch 2: rename nbdkit_add_default_export to nbdkit_use_default_export - overall: this missed 1.22, so update

Patch 3 still needs tests added, but it is at least working from my simple command line tests. Eric Blake (3): server: Implement nbdkit_is_tls for use during .open server: Expose final thread_model to filter's .get_ready tlsdummy: New filter docs/nbdkit-filter.pod | 21 +- docs/nbdkit-plugin.pod | 34 ++- docs/nbdkit-tls.pod

Since v1: - rework .can_cache to be tri-state, with default of no advertisement (ripple effect through other patches) - add a lot more patches in order to round out filter support And in the meantime, Rich pushed NBD_CMD_CACHE support into libnbd, so in theory we now have a way to test cache commands through the entire stack. Eric Blake (24): server: Internal hooks for implementing