search for: expose_static_funct

...it would be even harder to comprehend for someone who didn't know what it was supposed to be doing. I wouldn't be opposed to a single macro that wrapped the 'if (Name == "foo") return (uint64_t)&foo;' pattern, which is quite ugly. What do you think of this? #define EXPOSE_STATIC_FUNCTION (fn) if (Name == #fn) return (uint64_t)&fn; And then inside getSymbolAddress: #if ... conditions ... EXPOSE_STATIC_FUNCTION(__aeabi_d2f); EXPOSE_STATIC_FUNCTION(__aeabi_d2iz); EXPOSE_STATIC_FUNCTION(__aeabi_d2lz); etc. #endif -Andy -----Original Message----- From: James Lyon [ma...

...who didn't know what it was supposed to be doing. >> >> I wouldn't be opposed to a single macro that wrapped the 'if (Name == "foo") return (uint64_t)&foo;' pattern, which is quite ugly. >> >> What do you think of this? >> >> #define EXPOSE_STATIC_FUNCTION (fn) if (Name == #fn) return >> (uint64_t)&fn; >> >> And then inside getSymbolAddress: >> >> #if ... conditions ... >> EXPOSE_STATIC_FUNCTION(__aeabi_d2f); >> EXPOSE_STATIC_FUNCTION(__aeabi_d2iz); >> EXPOSE_STATIC_FUNCTION(__aeabi_...

...comprehend for someone who didn't know what it was supposed to be doing. > > I wouldn't be opposed to a single macro that wrapped the 'if (Name == "foo") return (uint64_t)&foo;' pattern, which is quite ugly. > > What do you think of this? > > #define EXPOSE_STATIC_FUNCTION (fn) if (Name == #fn) return (uint64_t)&fn; > > And then inside getSymbolAddress: > > #if ... conditions ... > EXPOSE_STATIC_FUNCTION(__aeabi_d2f); > EXPOSE_STATIC_FUNCTION(__aeabi_d2iz); > EXPOSE_STATIC_FUNCTION(__aeabi_d2lz); > etc. > #endif > &gt...

...comprehend for someone who didn't know what it was supposed to be doing. > > I wouldn't be opposed to a single macro that wrapped the 'if (Name == "foo") return (uint64_t)&foo;' pattern, which is quite ugly. > > What do you think of this? > > #define EXPOSE_STATIC_FUNCTION (fn) if (Name == #fn) return > (uint64_t)&fn; > > And then inside getSymbolAddress: > > #if ... conditions ... > EXPOSE_STATIC_FUNCTION(__aeabi_d2f); > EXPOSE_STATIC_FUNCTION(__aeabi_d2iz); > EXPOSE_STATIC_FUNCTION(__aeabi_d2lz); > etc. > #endif &g...

...who didn't know what it was supposed to be doing. >> >> I wouldn't be opposed to a single macro that wrapped the 'if (Name == "foo") return (uint64_t)&foo;' pattern, which is quite ugly. >> >> What do you think of this? >> >> #define EXPOSE_STATIC_FUNCTION (fn) if (Name == #fn) return >> (uint64_t)&fn; >> >> And then inside getSymbolAddress: >> >> #if ... conditions ... >> EXPOSE_STATIC_FUNCTION(__aeabi_d2f); >> EXPOSE_STATIC_FUNCTION(__aeabi_d2iz); >> EXPOSE_STATIC_FUNCTION(__aeabi...

Well, is the attached version better? I've extended the RTDyldMemoryManager hooks instead to pick up the ARM math functions statically, and left JITMemoryManager alone except for changing the conditional so that it will build with non-glibc libraries. I've also split the original patch up into two parts, to separate the math function fixes from setLastModificationAndAccessTime. The