search for: export_nam

...0; diff --git a/generator/states-newstyle-opt-export-name.c b/generator/states-newstyle-opt-export-name.c index 774c93c..968cea8 100644 --- a/generator/states-newstyle-opt-export-name.c +++ b/generator/states-newstyle-opt-export-name.c @@ -25,6 +25,7 @@ h->sbuf.option.optlen = strlen (h->export_name); h->wbuf = &h->sbuf; h->wlen = sizeof h->sbuf.option; + h->wflags = MSG_MORE; SET_NEXT_STATE (%SEND); return 0; diff --git a/generator/states-newstyle-opt-go.c b/generator/states-newstyle-opt-go.c index eea70cb..06bbaca 100644 --- a/generator/states-newstyle-opt-...

...as evidence of that fact. Let's revert that part of the patch, but improve the documentation to mention that -e is now useful _only_ with --run, and only if the client uses it. This partially reverts commit e71178e9b71403, although for -Wshadow reasons, we now have to name the global variable export_name due to other code in the meantime using parameters named exportname. Signed-off-by: Eric Blake <eblake@redhat.com> --- docs/nbdkit-captive.pod | 12 +++++++++++- docs/nbdkit-protocol.pod | 2 +- docs/nbdkit.pod | 18 ++++++++++++++++++ docs/synopsis.txt | 3 ++- server/i...

Hello, i would like import Data from Sybase DataBase to R-1.5.0 via RODBC. With this i get a connection without problems ! channel <- odbcConnect("ODBCName","LoginName","LoginPass") dataSybase <- sqlFetch(channel,"EPORT_XYZ") ,but when i try this i get a message error ? (Perhaps the _ is a problem, i know that's i.e. not usual to name

On 08/06/2018 07:03 AM, Richard W.M. Jones wrote: > Actually I was wrong, there *is* one substantive change over v1, which > is this: > >> + /* The client is buggy. The last option must be NBD_OPT_GO or >> + * NBD_OPT_EXPORT_NAME. >> + */ >> + else { >> + nbdkit_error ("client options list didn't finish with NBD_OPT_GO " >> + "or NBD_OPT_EXPORT_NAME"); >> + return -1; >> + } As I pointed out in the other mail, this else clause is unreachable....

Appears to have a measurable benefit, see 3/3 for test results. Rich.

Actually I was wrong, there *is* one substantive change over v1, which is this: > + /* The client is buggy. The last option must be NBD_OPT_GO or > + * NBD_OPT_EXPORT_NAME. > + */ > + else { > + nbdkit_error ("client options list didn't finish with NBD_OPT_GO " > + "or NBD_OPT_EXPORT_NAME"); > + return -1; > + } > + > return 0; Current behaviour in nbdkit is that if the last requested option is...

...generator/generator index a72f36c..87a8cdf 100755 --- a/generator/generator +++ b/generator/generator @@ -1066,10 +1066,16 @@ C<\"nbd2\">, etc."; longdesc = "\ For servers which require an export name or can serve different content on different exports, set the C<export_name> to -connect to. This is only relevant for the newstyle protocol. +connect to. The default is the empty string C<\"\">. + +This is only relevant when connecting to servers using the +newstyle protocol as the oldstyle protocol did not support +export names. The NBD protocol li...

...IPTION */ + list_one_export (nbd, NULL); else list_all_exports (nbd, argv[optind]); @@ -256,7 +257,7 @@ main (int argc, char *argv[]) } static void -list_one_export (struct nbd_handle *nbd) +list_one_export (struct nbd_handle *nbd, const char *desc) { int64_t size; char *export_name = NULL; @@ -298,6 +299,8 @@ list_one_export (struct nbd_handle *nbd) /* Might as well use the JSON function to get an escaped string here ... */ print_json_string (export_name); printf (":\n"); + if (desc && *desc) + printf ("\tdescription: %s\n",...

...) static void swfdec_resource_init (SwfdecResource *instance) { - instance->exports = g_hash_table_new (swfdec_str_case_hash, swfdec_str_case_equal); + instance->exports = g_hash_table_new_full (swfdec_str_case_hash, + swfdec_str_case_equal, g_free, g_object_unref); instance->export_names = g_hash_table_new_full (g_direct_hash, g_direct_equal, g_object_unref, g_free); } @@ -290,15 +291,14 @@ swfdec_resource_get_export_name (SwfdecResource *instance, SwfdecCharacter *char return g_hash_table_lookup (instance->export_names, character); } -/* NB: Takes ownership of...

...can do the same, althoug it's not as picky on export names). The DEAD state claims to close() the fd as soon as we detect a problem, where an example problem is requesting an export name not present on the server (NBD_OPT_GO fails, so we move to the DEAD state since we can't retry nbd_set_export_name without a new handle). But since the libnbd code gave up by returning -1, the DEAD state cleanup never runs, and we end up leaving the connection fd open instead, blocking out a second connection until we use nbd_close() to free all resources. Worse, we haven't yet wired up nbd_close into th...

...7,7 @@ and newstyle_state_machine = [ Group ("OPT_STRUCTURED_REPLY", newstyle_opt_structured_reply_state_machine); Group ("OPT_SET_META_CONTEXT", newstyle_opt_set_meta_context_state_machine); Group ("OPT_GO", newstyle_opt_go_state_machine); + Group ("OPT_EXPORT_NAME", newstyle_opt_export_name_state_machine); ] (* Fixed newstyle NBD_OPT_STARTTLS option. *) @@ -565,6 +566,44 @@ and newstyle_opt_go_state_machine = [ }; ] +(* Newstyle NBD_OPT_EXPORT_NAME option. *) +and newstyle_opt_export_name_state_machine = [ + State { + default_state with +...

...* by the client. For security reasons, be careful about: + * + * - Returning more data than is sent by the client. + * + * - Inputs that result in unbounded output. + * + * - Inputs that could hang, crash or exploit the server. + */ +static void * +reflection_open (int readonly) +{ + const char *export_name; + size_t export_name_len; + struct handle *h; + + h = malloc (sizeof *h); + if (h == NULL) { + nbdkit_error ("malloc: %m"); + return NULL; + } + + switch (mode) { + case MODE_EXPORTNAME: + case MODE_BASE64EXPORTNAME: + export_name = nbdkit_export_name (); + if (expor...

...file Y? tar filter ---> file plugin tar-exportname=on exportname=on directory=/my-files ---> directory of tar files It gets worse! At the moment filters and plugins can read the export name sent by the client by calling the global function nbdkit_export_name(). I'm not so worried about filters, but plugins must be able to continue to use this global function. In the scenario above both the tar filter and the file plugin would see the same string (if we did nothing), and it would only make sense to one or the other but never to both. Listing exp...

This isn't quite finished because not all of the tests or examples have been updated, but it demonstrates an idea: Should we forget about the concept of having multiple connections managed under a single handle? In this patch there is a single ‘struct nbd_handle *’ which manages a single state machine and connection (and therefore no nbd_connection). To connect to a multi-conn server you must

...NO_CHANNEL_BINDINGS, &ctx->client, &mech, send_tok, flags, NULL, &ctx->client_creds); and saving off ctx->client for later use. Under the hood, ctx->client is simply a gss_union_name_t. Later on (not much further later), ssh calls if ((ctx->major = gss_export_name(&ctx->minor, ctx->client, &ename))) { ssh_gssapi_error(ctx); return (ctx->major); } Here ctx->client is passed in but gss_export_name assumes that the input name is a krb5_principal. Not surprisingly, the datatype mismatch...

...gt; file plugin > tar-exportname=on exportname=on > directory=/my-files ---> directory of tar files > > It gets worse! At the moment filters and plugins can read the export > name sent by the client by calling the global function > nbdkit_export_name(). I'm not so worried about filters, but plugins > must be able to continue to use this global function. In the scenario > above both the tar filter and the file plugin would see the same > string (if we did nothing), and it would only make sense to one or the > other but never t...

An incremental improvement on top of listing exports. I still think it's worth experimenting with revisiting how our API for list mode should actually work [1] (so that we can reuse a single connection for both grabbing the list and finally using NBD_OPT_GO), but this change was easier to whip together while still thinking about that. [1]

The NBD spec was recently patched (nbd.git commit 7827f3ae and friends) to require NBD_OPT_GO for baseline interoperability, with the aim of fewer servers and clients falling back to NBD_OPT_EXPORT_NAME. And since nbdkit as server recently started supporting NBD_OPT_GO (commit f7dd9799), our nbd client as plugin should take advantage of it. This patch is a prerequisite to teaching the nbd plugin about structured replies, which in turn will allow an implementation of .extents. Signed-off-by: Eri...

I pushed a few of the msys2 patches upstream. I changed the way that $(SHARED_LDFLAGS) works so it's more to my liking, and the others were pushed unchanged. Three patches remain which I'm posting on the mailing list for proper review. Rich.

...its to qemu-nbd source code to provoke various other compliant (if uncommon) server behaviors. Eric Blake (4): starttls: Skip error payload if falling back to unencrypted states: Reject payload to NBD_REP_ACK meta-context: Skip error payload if server lacks meta_context states: Add NBD_OPT_EXPORT_NAME handling generator/Makefile.am | 1 + generator/generator | 53 ++++++++++++++ generator/states-newstyle-opt-export-name.c | 73 +++++++++++++++++++ generator/states-newstyle-opt-go.c | 13 +++- .../states-newstyle-opt-set-meta-cont...