search for: exit_mmap

...e > > + * native instructions with calls to pv ops. > > + */ > > +void __init apply_pv_alternatives(void) > > +{ > > + setup_force_cpu_cap(X86_FEATURE_PV_OPS); > > Not for Xen HVM guests. >From what I can tell, HVM guests still use pv_time_ops and pv_mmu_ops.exit_mmap, right? > > + apply_alternatives(__pv_alt_instructions, __pv_alt_instructions_end); > > +} > > > This is a problem (at least for Xen PV guests): > apply_alternatives()->text_poke_early()->local_irq_save()->...'cli'->death. Ah, right. > It might be...

...e > > + * native instructions with calls to pv ops. > > + */ > > +void __init apply_pv_alternatives(void) > > +{ > > + setup_force_cpu_cap(X86_FEATURE_PV_OPS); > > Not for Xen HVM guests. >From what I can tell, HVM guests still use pv_time_ops and pv_mmu_ops.exit_mmap, right? > > + apply_alternatives(__pv_alt_instructions, __pv_alt_instructions_end); > > +} > > > This is a problem (at least for Xen PV guests): > apply_alternatives()->text_poke_early()->local_irq_save()->...'cli'->death. Ah, right. > It might be...

Lguest and Xen pv-guests are the only users of pv_mmu_ops (with the one exception of the .exit_mmap member, which is being used by Xen HVM-guests, too). As it is possible now to build a kernel without Xen pv-guest support while keeping PVH and PVHVM support, I thought about putting most pv_mmu_ops functions in #ifdef CONFIG_XEN_HAS_PVMMU sections. If there wouldn't be lguest... So my questi...

Lguest and Xen pv-guests are the only users of pv_mmu_ops (with the one exception of the .exit_mmap member, which is being used by Xen HVM-guests, too). As it is possible now to build a kernel without Xen pv-guest support while keeping PVH and PVHVM support, I thought about putting most pv_mmu_ops functions in #ifdef CONFIG_XEN_HAS_PVMMU sections. If there wouldn't be lguest... So my questi...

...changed, 607 insertions(+), 25 deletions(-) > [snip] > diff --git a/mm/mmu_notifier.c b/mm/mmu_notifier.c > index 367670cfd02b7b..d02d3c8c223eb7 100644 > --- a/mm/mmu_notifier.c > +++ b/mm/mmu_notifier.c [snip] > * because mm->mm_users > 0 during mmu_notifier_register and exit_mmap > @@ -52,17 +286,24 @@ struct mmu_notifier_mm { > * can't go away from under us as exit_mmap holds an mm_count pin > * itself. > */ > -void __mmu_notifier_release(struct mm_struct *mm) > +static void mn_hlist_release(struct mmu_notifier_mm *mmn_mm, > + struc...

...DELL PowerEdge1950. However, a trouble blocked me during the machines run after two days. The machines crashed and the syslog said it got the following messages: ------------------ part dump of /var/log/messages ---------------------- ..... Jul 25 02:15:02 vega2008 kernel: [<c045bc58>] ? exit_mmap+0x93/0xc9 Jul 25 02:15:02 vega2008 kernel: [<c04214c2>] ? mmput+0x25/0x68 Jul 25 02:15:02 vega2008 kernel: [<c046e9c9>] ? flush_old_exec+0x4f8/0x777 Jul 25 02:15:02 vega2008 kernel: [<c046dfcf>] ? kernel_read+0x32/0x43 Jul 25 02:15:02 vega2008 kernel: [<c0490e60>] ? load...

...t;] ? release_pages+0xf4/0x14d [354008.101038] [<ffffffff810de78b>] ? free_pages_and_swap_cache+0x48/0x60 [354008.101045] [<ffffffff810cf527>] ? tlb_flush_mmu+0x37/0x50 [354008.101049] [<ffffffff810cf54c>] ? tlb_finish_mmu+0xc/0x31 [354008.101054] [<ffffffff810d5e79>] ? exit_mmap+0xc4/0xe9 [354008.101060] [<ffffffff81044b82>] ? mmput+0x56/0xf8 [354008.101064] [<ffffffff81049d07>] ? exit_mm+0x117/0x122 [354008.101069] [<ffffffff8107115b>] ? arch_local_irq_disable+0x7/0x8 [354008.101074] [<ffffffff81350487>] ? _raw_spin_lock_irq+0xa/0x14 [354008.10...

...[<ffffffff81042041>] untrack_pfn+0xa1/0xb0 [ 3009.876201] [<ffffffff8111a59b>] unmap_single_vma+0x86b/0x8e0 [ 3009.885895] [<ffffffff81100f16>] ? release_pages+0x196/0x1f0 [ 3009.895488] [<ffffffff8111a65c>] unmap_vmas+0x4c/0xa0 [ 3009.905134] [<ffffffff8111c8fa>] exit_mmap+0x9a/0x180 [ 3009.914706] [<ffffffff81064e72>] mmput+0x52/0xd0 [ 3009.924252] [<ffffffff810652b7>] dup_mm+0x3c7/0x510 [ 3009.933839] [<ffffffff81065fd5>] copy_process+0xac5/0x14a0 [ 3009.943430] [<ffffffff81066af3>] do_fork+0x53/0x360 [ 3009.952843] [<ffffffff810b25c...

...all other cases they are a NOP. In the end both callbacks are meant to register an address space with the underlying hypervisor, so there needs to be only a single callback for that purpose. So merge them to a common callback .mmu.enter_mmap (in contrast to the corresponding already existing .mmu.exit_mmap). As the first parameter of the old callbacks isn't used, drop it from the replacement one. Signed-off-by: Juergen Gross <jgross at suse.com> Reviewed-by: Boris Ostrovsky <boris.ostrovsky at oracle.com> --- V2: - expand commit message (Srivatsa S. Bhat) --- arch/x86/include/asm/m...

On Tue, Oct 29, 2019 at 10:04:45PM +0000, Kuehling, Felix wrote: > > * because mm->mm_users > 0 during mmu_notifier_register and exit_mmap > > @@ -52,17 +286,24 @@ struct mmu_notifier_mm { > > * can't go away from under us as exit_mmap holds an mm_count pin > > * itself. > > */ > > -void __mmu_notifier_release(struct mm_struct *mm) > > +static void mn_hlist_release(struct mmu_notifier_m...

...native instructions with calls to pv ops. >>> + */ >>> +void __init apply_pv_alternatives(void) >>> +{ >>> + setup_force_cpu_cap(X86_FEATURE_PV_OPS); >> Not for Xen HVM guests. > From what I can tell, HVM guests still use pv_time_ops and > pv_mmu_ops.exit_mmap, right? Right, I forgot about that one. >>> + >>> void __init_or_module apply_paravirt(struct paravirt_patch_site *start, >>> struct paravirt_patch_site *end) >>> { >>> diff --git a/arch/x86/kernel/cpu/hypervisor.c b/arch/x86/kernel/cpu/hy...

...0x14d > [354008.101038] [<ffffffff810de78b>] ? > free_pages_and_swap_cache+0x48/0x60 > [354008.101045] [<ffffffff810cf527>] ? tlb_flush_mmu+0x37/0x50 > [354008.101049] [<ffffffff810cf54c>] ? tlb_finish_mmu+0xc/0x31 > [354008.101054] [<ffffffff810d5e79>] ? exit_mmap+0xc4/0xe9 > [354008.101060] [<ffffffff81044b82>] ? mmput+0x56/0xf8 > [354008.101064] [<ffffffff81049d07>] ? exit_mm+0x117/0x122 > [354008.101069] [<ffffffff8107115b>] ? arch_local_irq_disable+0x7/0x8 > [354008.101074] [<ffffffff81350487>] ? _raw_spin_lock_irq...

On Mon, Jul 22, 2019 at 11:44:24AM +0200, Christoph Hellwig wrote: > Currently nouveau_svm_fault expects nouveau_range_fault to never unlock > mmap_sem, but the latter unlocks it for a random selection of error > codes. Fix this up by always unlocking mmap_sem for non-zero return > values in nouveau_range_fault, and only unlocking it in the caller > for successful returns. >

...0x3f [<c0103e94>] do_softirq+0x38/0x3f ======================= [<c0103dc2>] do_IRQ+0x70/0x7a [<c0102c1a>] common_interrupt+0x27/0x2b [<c014b5d8>] kmem_cache_free+0x27/0x2b [<c013dac4>] free_pgtables+0x31/0x63 [<c01421ab>] exit_mmap+0x6a/0xb6 [<c0115f53>] mmput+0x1f/0x76 [<c011a58d>] do_exit+0x173/0x32b [<c011a7f7>] sys_exit_group+0x0/0xd [<c01029f3>] sysenter_past_esp+0x54/0x75 printk: 64425470 messages suppressed. netfront: rx->offset: 0, size: 4294967295 printk:...

...t;] zap_pte_range+0x1d9/0x226 Jul 2 16:40:40 lvs2 kernel: [<c0159bf9>] zap_pmd_range+0x42/0x68 Jul 2 16:40:40 lvs2 kernel: [<c0159c58>] unmap_page_range+0x39/0x5f Jul 2 16:40:40 lvs2 kernel: [<c0159d7f>] unmap_vmas+0x101/0x1f8 Jul 2 16:40:40 lvs2 kernel: [<c015ed4a>] exit_mmap+0xb8/0x1d0 Jul 2 16:40:40 lvs2 kernel: [<c0121bb4>] mmput+0xb3/0xd6 Jul 2 16:40:40 lvs2 kernel: [<c0127248>] do_exit+0x255/0x59c Jul 2 16:40:40 lvs2 kernel: [<c0127727>] sys_exit_group+0x0/0xd Jul 2 16:40:40 lvs2 kernel: [<c0317637>] syscall_call+0x7/0xb Jul 2 16:40...

...kernel: Call Trace: Jul 11 10:14:01 mail kernel: [<c1078901>] ? print_bad_pte+0x13a/0x14b Jul 11 10:14:01 mail kernel: [<c107b206>] ? unmap_vmas+0x33b/0x62d Jul 11 10:14:01 mail kernel: [<c10272cc>] ? try_to_wake_up+0x206/0x210 Jul 11 10:14:01 mail kernel: [<c107ccc7>] ? exit_mmap+0x8c/0x107 Jul 11 10:14:01 mail kernel: [<c102976f>] ? mmput+0x1c/0x8c Jul 11 10:14:01 mail kernel: [<c102c850>] ? exit_mm+0xdc/0xe4 Jul 11 10:14:01 mail kernel: [<c103da3c>] ? hrtimer_try_to_cancel+0x55/0x5b Jul 11 10:14:01 mail kernel: [<c104dd0d>] ? acct_collect+0x77/...

...r I can avoid the bug if I used the original CentOS kernel code, not the one from www.kernel.org. Are there anyone who meet the similar trouble? Thanks a lot. ------------------ part dump of /var/log/messages ---------------------- ..... Jul 25 02:15:02 vega2008 kernel: [<c045bc58>] ? exit_mmap+0x93/0xc9 Jul 25 02:15:02 vega2008 kernel: [<c04214c2>] ? mmput+0x25/0x68 Jul 25 02:15:02 vega2008 kernel: [<c046e9c9>] ? flush_old_exec+0x4f8/0x777 Jul 25 02:15:02 vega2008 kernel: [<c046dfcf>] ? kernel_read+0x32/0x43 Jul 25 02:15:02 vega2008 kernel: [<c0490e60>] ? load...

...ABLE_LEVELS >= 3 */ - .pte_val = PTE_IDENT, - .pgd_val = PTE_IDENT, + .pv_mmu_ops.pte_val = PTE_IDENT, + .pv_mmu_ops.pgd_val = PTE_IDENT, - .make_pte = PTE_IDENT, - .make_pgd = PTE_IDENT, + .pv_mmu_ops.make_pte = PTE_IDENT, + .pv_mmu_ops.make_pgd = PTE_IDENT, - .dup_mmap = paravirt_nop, - .exit_mmap = paravirt_nop, - .activate_mm = paravirt_nop, + .pv_mmu_ops.dup_mmap = paravirt_nop, + .pv_mmu_ops.exit_mmap = paravirt_nop, + .pv_mmu_ops.activate_mm = paravirt_nop, - .lazy_mode = { + .pv_mmu_ops.lazy_mode = { .enter = paravirt_nop, .leave = paravirt_nop, .flush = paravirt_nop, },...

...if }, - .pv_misc_ops = { - .set_lazy_mode = paravirt_nop, - }, - .pv_mmu_ops = { .pagetable_setup_start = native_pagetable_setup_start, .pagetable_setup_done = native_pagetable_setup_done, @@ -400,6 +444,11 @@ struct paravirt_ops paravirt_ops = { .dup_mmap = paravirt_nop, .exit_mmap = paravirt_nop, .activate_mm = paravirt_nop, + + .lazy_mode = { + .enter = paravirt_nop, + .leave = paravirt_nop, + }, }, }; @@ -417,7 +466,6 @@ static void __init __used pv_aliases(voi substructure(pv_info); substructure(pv_init_ops); - substructure(pv_misc_ops); substr...

...if }, - .pv_misc_ops = { - .set_lazy_mode = paravirt_nop, - }, - .pv_mmu_ops = { .pagetable_setup_start = native_pagetable_setup_start, .pagetable_setup_done = native_pagetable_setup_done, @@ -400,6 +444,11 @@ struct paravirt_ops paravirt_ops = { .dup_mmap = paravirt_nop, .exit_mmap = paravirt_nop, .activate_mm = paravirt_nop, + + .lazy_mode = { + .enter = paravirt_nop, + .leave = paravirt_nop, + }, }, }; @@ -417,7 +466,6 @@ static void __init __used pv_aliases(voi substructure(pv_info); substructure(pv_init_ops); - substructure(pv_misc_ops); substr...