search for: event_triggered

...gt; > > > > > > typo should be "trigger" > > > > > > > > > > > > > > > > > > > OK, thanks for this. I will correct it in the next version > > > > > > > > > > > > > > vq->event_triggered will be set to true. It will no longer be > > > > > > > > set to false. Unless we explicitly call virtqueue_enable_cb_delayed > > > > > > > > or virtqueue_enable_cb_prepare > > > > > > > > > > > > > > > &gt...

...("virtio: fix up virtio_disable_cb") > > > > > > if we disable the napi_tx. when we triger a tx interrupt, the > > > > typo should be "trigger" > > > > OK, thanks for this. I will correct it in the next version > > > > vq->event_triggered will be set to true. It will no longer be > > > set to false. Unless we explicitly call virtqueue_enable_cb_delayed > > > or virtqueue_enable_cb_prepare > > > > > > if we disable the napi_tx, It will only be called when the tx ring > > > buffer is relati...

...o_ring.c index 71e16b53e9c1..88f0b16b11b8 100644 --- a/drivers/virtio/virtio_ring.c +++ b/drivers/virtio/virtio_ring.c @@ -113,6 +113,9 @@ struct vring_virtqueue { /* Last used index we've seen. */ u16 last_used_idx; + /* Hint for event idx: already triggered no need to disable. */ + bool event_triggered; + union { /* Available for split ring */ struct { @@ -739,7 +742,10 @@ static void virtqueue_disable_cb_split(struct virtqueue *_vq) if (!(vq->split.avail_flags_shadow & VRING_AVAIL_F_NO_INTERRUPT)) { vq->split.avail_flags_shadow |= VRING_AVAIL_F_NO_INTERRUPT; - if (!vq-&...

Hi Michael, Albert, Albert Huang wrote on Sat, Mar 25, 2023 at 06:56:33PM +0800: > in virtio_net, if we disable the napi_tx, when we triger a tx interrupt, > the vq->event_triggered will be set to true. It will no longer be set to > false. Unless we explicitly call virtqueue_enable_cb_delayed or > virtqueue_enable_cb_prepare. This patch (commited as 35395770f803 ("virtio_ring: don't update event idx on get_buf") in next-20230327 apparently breaks 9p, as re...

is the below same as what I posted or different? how? On Sat, Mar 25, 2023 at 06:56:33PM +0800, Albert Huang wrote: > in virtio_net, if we disable the napi_tx, when we triger a tx interrupt, > the vq->event_triggered will be set to true. It will no longer be set to > false. Unless we explicitly call virtqueue_enable_cb_delayed or > virtqueue_enable_cb_prepare. > > If we disable the napi_tx, it will only be called when the tx ring > buffer is relatively small. > > Because event_triggered i...

...m> wrote: > > From: "huangjie.albert" <huangjie.albert at bytedance.com> > > fix commit 8d622d21d248 ("virtio: fix up virtio_disable_cb") > > if we disable the napi_tx. when we triger a tx interrupt, the typo should be "trigger" > vq->event_triggered will be set to true. It will no longer be > set to false. Unless we explicitly call virtqueue_enable_cb_delayed > or virtqueue_enable_cb_prepare > > if we disable the napi_tx, It will only be called when the tx ring > buffer is relatively small: > virtio_net->start_xmit: >...

With the implementation of napi-tx in virtio driver, we clean tx descriptors from rx napi handler, for the purpose of reducing tx complete interrupts. But this introduces a race where tx complete interrupt has been raised, but the handler finds there is no work to do because we have done the work in the previous rx interrupt handler. A similar issue exists with polling from start_xmit, it is

With the implementation of napi-tx in virtio driver, we clean tx descriptors from rx napi handler, for the purpose of reducing tx complete interrupts. But this introduces a race where tx complete interrupt has been raised, but the handler finds there is no work to do because we have done the work in the previous rx interrupt handler. A similar issue exists with polling from start_xmit, it is

On 17 Mar 2015, at 14:07, Robert Stanford wrote: > Hello, I?d like to use the new event triggers in 2.5, but the docs > haven?t been updated yet. > > I?ve managed to gather from the source that the config xml needs to > contain an ?event? node with a ?trigger? attribute, but I > don?t know what the trigger options are. > > Anyone used this or have any idea? Hey, great

Hello, I?d like to use the new event triggers in 2.5, but the docs haven?t been updated yet. I?ve managed to gather from the source that the config xml needs to contain an ?event? node with a ?trigger? attribute, but I don?t know what the trigger options are. Anyone used this or have any idea? Cheers, Rob Stanford

On Thu, Sep 3, 2015 at 6:45 PM, Kostya Serebryany <kcc at google.com> wrote: > Did you build the Postgres code with -fsanitize-coverage=... ? Yes: CC = clang CFLAGS = -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -Wno-unused-command-line-argument -g -O0 -fsanitize=address

Looks correct. Can you post the output of libFuzzer here? Something like #0 READ cov: 0 bits: 0 units: 97701 exec/s: 0 #1 pulse cov: 732 bits: 0 units: 97701 exec/s: 0 #2 pulse cov: 737 bits: 0 units: 97701 exec/s: 1 #4 pulse cov: 858 bits: 0 units: 97701 exec/s: 2 #8 pulse cov: 880 bits: 0 units: 97701 exec/s: 4 On Thu, Sep 3, 2015 at 10:50 AM, Greg Stark