search for: event_run

...;>>> On Wed, May 29, 2019 at 11:22:40AM +0800, Jason Wang wrote: >>>>>> On 2019/5/28 ??6:56, Stefano Garzarella wrote: >>>>>>> @@ -690,6 +693,9 @@ static void virtio_vsock_remove(struct virtio_device *vdev) >>>>>>> vsock->event_run = false; >>>>>>> mutex_unlock(&vsock->event_lock); >>>>>>> + /* Flush all pending works */ >>>>>>> + virtio_vsock_flush_works(vsock); >>>>>>> + >>>>>>> /* Flush all device wri...

...;>>> On Wed, May 29, 2019 at 11:22:40AM +0800, Jason Wang wrote: >>>>>> On 2019/5/28 ??6:56, Stefano Garzarella wrote: >>>>>>> @@ -690,6 +693,9 @@ static void virtio_vsock_remove(struct virtio_device *vdev) >>>>>>> vsock->event_run = false; >>>>>>> mutex_unlock(&vsock->event_lock); >>>>>>> + /* Flush all pending works */ >>>>>>> + virtio_vsock_flush_works(vsock); >>>>>>> + >>>>>>> /* Flush all device wri...

...29, 2019 at 11:22:40AM +0800, Jason Wang wrote: >>>>>>>> On 2019/5/28 ??6:56, Stefano Garzarella wrote: >>>>>>>>> @@ -690,6 +693,9 @@ static void virtio_vsock_remove(struct virtio_device *vdev) >>>>>>>>> vsock->event_run = false; >>>>>>>>> mutex_unlock(&vsock->event_lock); >>>>>>>>> + /* Flush all pending works */ >>>>>>>>> + virtio_vsock_flush_works(vsock); >>>>>>>>> + >>>>>>&...

...;>>> /* Reset all connected sockets when the device disappear */ >>>>> vsock_for_each_connected_socket(virtio_vsock_reset_sock); >>>>> @@ -690,6 +693,9 @@ static void virtio_vsock_remove(struct virtio_device *vdev) >>>>> vsock->event_run = false; >>>>> mutex_unlock(&vsock->event_lock); >>>>> + /* Flush all pending works */ >>>>> + virtio_vsock_flush_works(vsock); >>>>> + >>>>> /* Flush all device writes and interrupts, device will not use an...

...;>>> /* Reset all connected sockets when the device disappear */ >>>>> vsock_for_each_connected_socket(virtio_vsock_reset_sock); >>>>> @@ -690,6 +693,9 @@ static void virtio_vsock_remove(struct virtio_device *vdev) >>>>> vsock->event_run = false; >>>>> mutex_unlock(&vsock->event_lock); >>>>> + /* Flush all pending works */ >>>>> + virtio_vsock_flush_works(vsock); >>>>> + >>>>> /* Flush all device writes and interrupts, device will not use an...

...gt; - flush_work(&vsock->send_pkt_work); > - > /* Reset all connected sockets when the device disappear */ > vsock_for_each_connected_socket(virtio_vsock_reset_sock); > > @@ -690,6 +693,9 @@ static void virtio_vsock_remove(struct virtio_device *vdev) > vsock->event_run = false; > mutex_unlock(&vsock->event_lock); > > + /* Flush all pending works */ > + virtio_vsock_flush_works(vsock); > + > /* Flush all device writes and interrupts, device will not use any > * more buffers. > */ > @@ -726,6 +732,11 @@ static void...

...gt; - flush_work(&vsock->send_pkt_work); > - > /* Reset all connected sockets when the device disappear */ > vsock_for_each_connected_socket(virtio_vsock_reset_sock); > > @@ -690,6 +693,9 @@ static void virtio_vsock_remove(struct virtio_device *vdev) > vsock->event_run = false; > mutex_unlock(&vsock->event_lock); > > + /* Flush all pending works */ > + virtio_vsock_flush_works(vsock); > + > /* Flush all device writes and interrupts, device will not use any > * more buffers. > */ > @@ -726,6 +732,11 @@ static void...

...d_pkt_work); >>> - >>> /* Reset all connected sockets when the device disappear */ >>> vsock_for_each_connected_socket(virtio_vsock_reset_sock); >>> @@ -690,6 +693,9 @@ static void virtio_vsock_remove(struct virtio_device *vdev) >>> vsock->event_run = false; >>> mutex_unlock(&vsock->event_lock); >>> + /* Flush all pending works */ >>> + virtio_vsock_flush_works(vsock); >>> + >>> /* Flush all device writes and interrupts, device will not use any >>> * more buffers. >&g...

...d_pkt_work); >>> - >>> /* Reset all connected sockets when the device disappear */ >>> vsock_for_each_connected_socket(virtio_vsock_reset_sock); >>> @@ -690,6 +693,9 @@ static void virtio_vsock_remove(struct virtio_device *vdev) >>> vsock->event_run = false; >>> mutex_unlock(&vsock->event_lock); >>> + /* Flush all pending works */ >>> + virtio_vsock_flush_works(vsock); >>> + >>> /* Flush all device writes and interrupts, device will not use any >>> * more buffers. >&g...

...19 at 11:22:40AM +0800, Jason Wang wrote: > > > > > > > On 2019/5/28 ??6:56, Stefano Garzarella wrote: > > > > > > > > @@ -690,6 +693,9 @@ static void virtio_vsock_remove(struct virtio_device *vdev) > > > > > > > > vsock->event_run = false; > > > > > > > > mutex_unlock(&vsock->event_lock); > > > > > > > > + /* Flush all pending works */ > > > > > > > > + virtio_vsock_flush_works(vsock); > > > > > > > > + > > >...

...t; > > On Wed, May 29, 2019 at 11:22:40AM +0800, Jason Wang wrote: > > > > > On 2019/5/28 ??6:56, Stefano Garzarella wrote: > > > > > > @@ -690,6 +693,9 @@ static void virtio_vsock_remove(struct virtio_device *vdev) > > > > > > vsock->event_run = false; > > > > > > mutex_unlock(&vsock->event_lock); > > > > > > + /* Flush all pending works */ > > > > > > + virtio_vsock_flush_works(vsock); > > > > > > + > > > > > > /* Flush all device...

...54,7 @@ struct virtio_vsock { * must be accessed with rx_lock held. */ struct mutex rx_lock; + bool rx_run; int rx_buf_nr; int rx_buf_max_nr; @@ -60,6 +62,7 @@ struct virtio_vsock { * vqs[VSOCK_VQ_EVENT] must be accessed with event_lock held. */ struct mutex event_lock; + bool event_run; struct virtio_vsock_event event_list[8]; u32 guest_cid; @@ -94,6 +97,10 @@ static void virtio_transport_loopback_work(struct work_struct *work) spin_unlock_bh(&vsock->loopback_list_lock); mutex_lock(&vsock->rx_lock); + + if (!vsock->rx_run) + goto out; + while (!lis...

...54,7 @@ struct virtio_vsock { * must be accessed with rx_lock held. */ struct mutex rx_lock; + bool rx_run; int rx_buf_nr; int rx_buf_max_nr; @@ -60,6 +62,7 @@ struct virtio_vsock { * vqs[VSOCK_VQ_EVENT] must be accessed with event_lock held. */ struct mutex event_lock; + bool event_run; struct virtio_vsock_event event_list[8]; u32 guest_cid; @@ -94,6 +97,10 @@ static void virtio_transport_loopback_work(struct work_struct *work) spin_unlock_bh(&vsock->loopback_list_lock); mutex_lock(&vsock->rx_lock); + + if (!vsock->rx_run) + goto out; + while (!lis...

During the review of "[PATCH] vsock/virtio: Initialize core virtio vsock before registering the driver", Stefan pointed out some possible issues in the .probe() and .remove() callbacks of the virtio-vsock driver. This series tries to solve these issues: - Patch 1 postpones the 'the_virtio_vsock' assignment at the end of the .probe() to avoid that some sockets queue works when

During the review of "[PATCH] vsock/virtio: Initialize core virtio vsock before registering the driver", Stefan pointed out some possible issues in the .probe() and .remove() callbacks of the virtio-vsock driver. This series tries to solve these issues: - Patch 1 postpones the 'the_virtio_vsock' assignment at the end of the .probe() to avoid that some sockets queue works when

...&vsock->send_pkt_work); > > - > > /* Reset all connected sockets when the device disappear */ > > vsock_for_each_connected_socket(virtio_vsock_reset_sock); > > @@ -690,6 +693,9 @@ static void virtio_vsock_remove(struct virtio_device *vdev) > > vsock->event_run = false; > > mutex_unlock(&vsock->event_lock); > > + /* Flush all pending works */ > > + virtio_vsock_flush_works(vsock); > > + > > /* Flush all device writes and interrupts, device will not use any > > * more buffers. > > */ > >...

...> > > > /* Reset all connected sockets when the device disappear */ > > > > vsock_for_each_connected_socket(virtio_vsock_reset_sock); > > > > @@ -690,6 +693,9 @@ static void virtio_vsock_remove(struct virtio_device *vdev) > > > > vsock->event_run = false; > > > > mutex_unlock(&vsock->event_lock); > > > > + /* Flush all pending works */ > > > > + virtio_vsock_flush_works(vsock); > > > > + > > > > /* Flush all device writes and interrupts, device will not use any >...

During the review of "[PATCH] vsock/virtio: Initialize core virtio vsock before registering the driver", Stefan pointed out some possible issues in the .probe() and .remove() callbacks of the virtio-vsock driver. This series tries to solve these issues: - Patch 1 adds RCU critical sections to avoid use-after-free of 'the_virtio_vsock' pointer. - Patch 2 stops workers before to

During the review of "[PATCH] vsock/virtio: Initialize core virtio vsock before registering the driver", Stefan pointed out some possible issues in the .probe() and .remove() callbacks of the virtio-vsock driver. This series tries to solve these issues: - Patch 1 adds RCU critical sections to avoid use-after-free of 'the_virtio_vsock' pointer. - Patch 2 stops workers before to

During the review of "[PATCH] vsock/virtio: Initialize core virtio vsock before registering the driver", Stefan pointed out some possible issues in the .probe() and .remove() callbacks of the virtio-vsock driver. This series tries to solve these issues: - Patch 1 adds RCU critical sections to avoid use-after-free of 'the_virtio_vsock' pointer. - Patch 2 stops workers before to