search for: estimate_target_size

...Checking for sufficient free disk space in the guest"); + let mpstats = get_mpstats g in check_free_space mpstats; - - (* Estimate space required on target for each disk. Note this is a max. *) - message (f_"Estimating space required on target for each disk"); - let targets = estimate_target_size mpstats targets in - - output#check_target_free_space source targets; + check_target_free_space mpstats source targets output; (* Conversion. *) let guestcaps = @@ -594,11 +571,29 @@ and inspect_source g root_choice = if verbose () then printf "%s%!" (string_of_inspect inspec...

...(quote qemu_uri) (quote options) overlay_file in - if verbose () then printf "%s\n%!" cmd; + debug "%s" cmd; if Sys.command cmd <> 0 then error (f_"qemu-img command failed, see earlier errors"); @@ -453,16 +452,14 @@ and estimate_target_size mpstats targets = sum ( List.map (fun { mp_statvfs = s } -> s.G.blocks *^ s.G.bsize) mpstats ) in - if verbose () then - printf "estimate_target_size: fs_total_size = %Ld [%s]\n%!" - fs_total_size (human_size fs_total_size); + debug "estimate_target_size...

Add a Common_utils.debug function for printing messages only when in verbose mode. Rich.

....\n\nUse the '-of <format>' option to select a different output format for the converted guest.\n\nOther output formats are not supported at the moment, although might be considered in future."); - - (* output#prepare_targets will fill in the target_file field. - * estimate_target_size will fill in the target_estimated_size field. - * actual_target_size will fill in the target_actual_size field. - *) - { target_file = ""; target_format = format; - target_estimated_size = None; - target_actual_size = None; - target_overla...

This series is a second attempt to add a mode of virt-v2v operation where it leaves the config and disk image conversion, rollback on errors, registering with the destination hypervisor, etc. to a third-party toolset, and performs only tuning of the guest OS to run in the KVM-based hypervisor. The first 14 patches are just refactoring and rearrangement of the code, factoring the implementation

...printf "mpstats:\n"; List.iter (print_mpstat Pervasives.stdout) mpstats @@ -264,7 +264,7 @@ let rec main () = (* Estimate space required on target for each disk. Note this is a max. *) msg (f_"Estimating space required on target for each disk"); - let targets = estimate_target_size ~verbose mpstats targets in + let targets = estimate_target_size mpstats targets in output#check_target_free_space source targets; @@ -285,9 +285,9 @@ let rec main () = with Not_found -> error (f_"virt-v2v is unable to convert this guest type (%s/%s)")...

...compressed with qcow2. *) + if compressed && format <> "qcow2" then + error (f_"the --compressed flag is only allowed when the output format is qcow2 (-of qcow2)"); + (* output#prepare_targets will fill in the target_file field. * estimate_target_size will fill in the target_estimated_size field. * actual_target_size will fill in the target_actual_size field. @@ -757,7 +762,7 @@ and get_target_firmware inspect guestcaps source output = and delete_target_on_exit = ref true -and copy_targets targets input output output_alloc = +and...

.. and a lot of refactoring. https://bugzilla.redhat.com/show_bug.cgi?id=1167623 Rich.

https://bugzilla.redhat.com/show_bug.cgi?id=1167623

RHV was connecting to the VMware source in order to find out the virtual disk size of the source disk(s), duplicating logic that virt-v2v already provides. This makes that information available using a new ‘virt-v2v --print-target option’. Note in order to get all the information, this has to actually perform the conversion step, so it takes 30 seconds or so before we reach the point where the

...exit 0 + ); + message (f_"Assigning disks to buses"); let target_buses = Target_bus_assignment.target_bus_assignment source guestcaps in @@ -487,8 +505,6 @@ and do_fstrim g inspect = * sdb final estimate size = 3 - (3*1.35/4) = 1.9875 GB *) and estimate_target_size mpstats overlays = - let sum = List.fold_left (+^) 0L in - (* (1) *) let fs_total_size = sum ( diff --git a/v2v/virt-v2v.pod b/v2v/virt-v2v.pod index e6f08d1e6..a92ae9f88 100644 --- a/v2v/virt-v2v.pod +++ b/v2v/virt-v2v.pod @@ -794,6 +794,20 @@ C<root>. You will get an error if v...

...exit 0 + ); + message (f_"Assigning disks to buses"); let target_buses = Target_bus_assignment.target_bus_assignment source guestcaps in @@ -487,8 +500,6 @@ and do_fstrim g inspect = * sdb final estimate size = 3 - (3*1.35/4) = 1.9875 GB *) and estimate_target_size mpstats overlays = - let sum = List.fold_left (+^) 0L in - (* (1) *) let fs_total_size = sum ( diff --git a/v2v/virt-v2v.pod b/v2v/virt-v2v.pod index 303fe425c..af3f4d6b1 100644 --- a/v2v/virt-v2v.pod +++ b/v2v/virt-v2v.pod @@ -794,6 +794,17 @@ C<root>. You will get an error if v...

...exit 0 + ); + message (f_"Assigning disks to buses"); let target_buses = Target_bus_assignment.target_bus_assignment source guestcaps in @@ -487,8 +495,6 @@ and do_fstrim g inspect = * sdb final estimate size = 3 - (3*1.35/4) = 1.9875 GB *) and estimate_target_size mpstats overlays = - let sum = List.fold_left (+^) 0L in - (* (1) *) let fs_total_size = sum ( @@ -617,6 +623,25 @@ and get_target_formats cmdline output overlays = format ) overlays +and print_estimate overlays = + let estimates = + List.map ( + fun { ov_overlay_fi...

...exit 0 + ); + message (f_"Assigning disks to buses"); let target_buses = Target_bus_assignment.target_bus_assignment source guestcaps in @@ -487,8 +495,6 @@ and do_fstrim g inspect = * sdb final estimate size = 3 - (3*1.35/4) = 1.9875 GB *) and estimate_target_size mpstats overlays = - let sum = List.fold_left (+^) 0L in - (* (1) *) let fs_total_size = sum ( @@ -617,6 +623,25 @@ and get_target_formats cmdline output overlays = format ) overlays +and print_estimate overlays = + let estimates = + List.map ( + fun { ov_overlay_fi...

v4: - Same as v3, but depends on and uses new --machine-readable work. Rich.

...2v/v2v.ml +++ b/v2v/v2v.ml @@ -133,7 +133,7 @@ let rec main () = | In_place -> rcaps_from_source source in - do_convert g inspect source output rcaps in + do_convert g inspect source output rcaps cmdline.force_interfaces in g#umount_all (); @@ -557,7 +557,7 @@ and estimate_target_size mpstats overlays = ) (* Conversion. *) -and do_convert g inspect source output rcaps = +and do_convert g inspect source output rcaps interfaces = (match inspect.i_product_name with | "unknown" -> message (f_"Converting the guest to run on KVM") @@ -573,7 +573...

v6: - Make the text output a bit nicer. - Changes as suggested to Measure_disk module temp file & json parsing. - Use jq to test JSON output. - Retest.

v5: - Normal output modified approx as suggested in previous email. - Machine readable output uses JSON.

...-- a/v2v/v2v.ml +++ b/v2v/v2v.ml @@ -133,7 +133,7 @@ let rec main () = | In_place -> rcaps_from_source source in - do_convert g inspect source output rcaps in + do_convert g inspect source output rcaps cmdline.static_ips in g#umount_all (); @@ -557,7 +557,7 @@ and estimate_target_size mpstats overlays = ) (* Conversion. *) -and do_convert g inspect source output rcaps = +and do_convert g inspect source output rcaps interfaces = (match inspect.i_product_name with | "unknown" -> message (f_"Converting the guest to run on KVM") @@ -573,7 +573...

...;.\n\nUse the '-of <format>' option to select a different output format for the converted guest.\n\nOther output formats are not supported at the moment, although might be considered in future"); (* output#prepare_targets will fill in the target_file field. * estimate_target_size will fill in the target_estimated_size field. @@ -348,7 +348,7 @@ and inspect_source g root_choice = let root = match roots with | [] -> - error (f_"no root device found in this operating system image."); + error (f_"no root device found in this operating sy...