search for: error_reportf_err

...e_sec = cpu_to_le64(stbuf.st_ctim.tv_sec); > + rarg->info.time_nsec = cpu_to_le32(stbuf.st_ctim.tv_nsec); > + > + rarg->ioc = qio_channel_new_fd(fd, &err); You should just use qio_channel_open_path() and avoid the earlier call to open() > + if (err) { > + error_reportf_err(err, "cannot create io channel: "); > + goto out; > + } > + > + qio_channel_set_blocking(rarg->ioc, false, &err); > + qio_channel_add_watch(rarg->ioc, G_IO_IN, pstore_async_read_fn, rarg, > + free_rarg_fn); > + g_f...

...e_sec = cpu_to_le64(stbuf.st_ctim.tv_sec); > + rarg->info.time_nsec = cpu_to_le32(stbuf.st_ctim.tv_nsec); > + > + rarg->ioc = qio_channel_new_fd(fd, &err); You should just use qio_channel_open_path() and avoid the earlier call to open() > + if (err) { > + error_reportf_err(err, "cannot create io channel: "); > + goto out; > + } > + > + qio_channel_set_blocking(rarg->ioc, false, &err); > + qio_channel_add_watch(rarg->ioc, G_IO_IN, pstore_async_read_fn, rarg, > + free_rarg_fn); > + g_f...

...> + rarg->ioc = qio_channel_new_fd(fd, &err); > > You should just use qio_channel_open_path() and avoid the earlier > call to open() I did it because to call fstat() using the fd and wanted to keep the generic ioc pointer. > > > + if (err) { > > + error_reportf_err(err, "cannot create io channel: "); > > + goto out; > > + } > > + > > + qio_channel_set_blocking(rarg->ioc, false, &err); > > + qio_channel_add_watch(rarg->ioc, G_IO_IN, pstore_async_read_fn, rarg, > > +...

...rarg->info.type); + rarg->info.flags = cpu_to_le32(rarg->info.flags); + rarg->info.time_sec = cpu_to_le64(stbuf.st_ctim.tv_sec); + rarg->info.time_nsec = cpu_to_le32(stbuf.st_ctim.tv_nsec); + + rarg->ioc = qio_channel_new_fd(fd, &err); + if (err) { + error_reportf_err(err, "cannot create io channel: "); + goto out; + } + + qio_channel_set_blocking(rarg->ioc, false, &err); + qio_channel_add_watch(rarg->ioc, G_IO_IN, pstore_async_read_fn, rarg, + free_rarg_fn); + g_free(filename); + return 1; + +ou...

...second values are exposed with names of the form > > st_atimensec. > > Thanks for the info. > > > > > > > > > > > > + > > > + rarg->ioc = qio_channel_new_fd(fd, &err); > > > + if (err) { > > > + error_reportf_err(err, "cannot create io channel: "); > > > + goto out; > > > + } > > > + > > > + qio_channel_set_blocking(rarg->ioc, false, &err); > > > + qio_channel_add_watch(rarg->ioc, G_IO_IN, pstore_async_read_fn, rarg, > >...

Hello, This is another iteration of the virtio-pstore work. In this patchset I addressed most of feedbacks from previous version and drooped the support for PSTORE_TYPE_CONSOLE for simplicity. It'll be added once the basic implementation * changes in v3) - use QIOChannel API (Stefan, Daniel) - add bound check for malcious guests (Daniel) - drop support PSTORE_TYPE_CONSOLE for now

Hello, This is another iteration of the virtio-pstore work. In this patchset I addressed most of feedbacks from previous version and drooped the support for PSTORE_TYPE_CONSOLE for simplicity. It'll be added once the basic implementation * changes in v3) - use QIOChannel API (Stefan, Daniel) - add bound check for malcious guests (Daniel) - drop support PSTORE_TYPE_CONSOLE for now

Hello, This is another iteration of the virtio-pstore work. I've addressed all comments from Daniel Berrange on the qemu side. * changes in v4) - use qio_channel_file_new_path() (Daniel) - rename to delete_old_pstore_file (Daniel) - convert G_REMOVE_SOURCE to FALSE (Daniel) * changes in v3) - use QIOChannel API (Stefan, Daniel) - add bound check for malcious guests

Hello, This is another iteration of the virtio-pstore work. I've addressed all comments from Daniel Berrange on the qemu side. * changes in v4) - use qio_channel_file_new_path() (Daniel) - rename to delete_old_pstore_file (Daniel) - convert G_REMOVE_SOURCE to FALSE (Daniel) * changes in v3) - use QIOChannel API (Stefan, Daniel) - add bound check for malcious guests